Detect browser width instead of the screen width #837
Conversation
|
It looks like this was the original code I had written. We noticed that this wasn't working with device emulation on chrome. I'll revisit this. |
|
Thanks for the PR. The problem here is that I'm confused with how |
|
I see what you mean. I'll take another look into this and see if there is a better way to handle it. |
|
It seems to be related to the mobile "visual viewport" : http://www.quirksmode.org/mobile/viewports2.html I haven't digested all of this yet, but we might need to just pick one and go with it. I'm not sure which way is more "standard". |
|
I have been looking into this further and it appears to me that the current PR should be the preferred way to detect viewport size. The innerWidth method will return the browser viewport. A fallback to the clientWidth method is acceptable to detect the width of the document itself. There are cases where the document could expand past the browser's actual viewport. The viewport meta tag should be used to set the viewport width to match the device width. The http://client-test.devnxs.net/demos/display.html site does not set a viewport meta tag so it will use the browsers default layout width. In Safari on iPhone that is 980px, but other browsers will vary. The innerWidth/clientWidth method would give us this value which would still be technically correct in regard to the page width. |
|
@agabel |
…ebid-official-0.17.0 to release/1.12.0 * commit 'bce975978c2c088d301d120b949d38080ca9d314': Add changelog entry. Prebid Release 0.17.0 remove hb_pb targeting key for deal bids with no cpm (prebid#881) Fix for bug prebid#866 (prebid#867) Allow changing of 'ga' global variable (prebid#832) emit auction end event before bidsBackHandler callback (prebid#884) Add Widespace adapter (prebid#846) prevent rubicon adapter from registering two bids on exceptions (prebid#854) Code Refactoring - Upgrading end point. (prebid#826) Ignore test html pages (prebid#878) Detect browser width instead of the screen width (prebid#837) New aardvark adapter with support for aliasing (prebid#875) Add Fidelity adapter (prebid#862) Adkernel adapter aliasing (prebid#857) 0.16.1-pre
…12.0 to master * commit '728f1763ce2a282a757546e934199313a4771a21': Fix failing unit test on CI. Add changelog entry. Prebid Release 0.17.0 remove hb_pb targeting key for deal bids with no cpm (prebid#881) Fix for bug prebid#866 (prebid#867) Allow changing of 'ga' global variable (prebid#832) emit auction end event before bidsBackHandler callback (prebid#884) Add Widespace adapter (prebid#846) prevent rubicon adapter from registering two bids on exceptions (prebid#854) Code Refactoring - Upgrading end point. (prebid#826) Ignore test html pages (prebid#878) Detect browser width instead of the screen width (prebid#837) New aardvark adapter with support for aliasing (prebid#875) Add Fidelity adapter (prebid#862) Adkernel adapter aliasing (prebid#857) 0.16.1-pre
Type of change
Description of change
Currently the size mapping is detecting the user's screen width instead of the browser. This change will use the browser width to determine which size mapping should be used.