Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python lesson sequence and accessing files as binary #1777

Closed
svmelton opened this issue May 18, 2020 · 10 comments · Fixed by #1997
Closed

Python lesson sequence and accessing files as binary #1777

svmelton opened this issue May 18, 2020 · 10 comments · Fixed by #1997
Assignees

Comments

@svmelton
Copy link
Contributor

I received a note from a reader who is having problems with this lesson and is using Windows. It appears to be the same error referenced in #1768. @walshbr would you be able to take a look at this, or would you rather I tag someone else in?
screenshot

@walshbr
Copy link
Contributor

walshbr commented May 18, 2020

Same error message as the other one, but a different context. I don't immediately know how to troubleshoot errors like these, and I don't have access to a Windows machine to help facilitate it. Could you check with someone else? Sorry!

@svmelton
Copy link
Contributor Author

Would someone from @programminghistorian/technical-team be able to take a look at this?

@jenniferisasi
Copy link
Contributor

I am afraid I don't know Python nor do I have a Windows machine with me.

@acrymble
Copy link

Sorry we obviously made mistakes when doing to 2 to 3 migration #1460. @JoshuaGOB helped with the Windows files. Maybe he can advise?

@JoshuaGOB
Copy link
Contributor

I think it's a matter of eliminating the binary option in open but I don't have a Windows computer to check this on right now. Will try to get access soon but if someone does try:
f = open('helloworld.html','w')

@walshbr
Copy link
Contributor

walshbr commented May 19, 2020

FWIW - #1611 - the wb component was specifically added to address an error on Windows machines. So definitely would want to double check instances of it to make sure that taking it out doesn't re-introduce the other error.

@walshbr walshbr changed the title User issue in Creating and Viewing HTML files with Python Python lesson sequence and accessing files as binary May 26, 2020
@walshbr
Copy link
Contributor

walshbr commented May 26, 2020

Just a note that I've renamed this ticket to reflect the particular bug that was initially reported. It overlaps with #1777 as part of larger debugging needed for the python lesson sequence.

@mariajoafana
Copy link
Contributor

Lets bring this up in the next Project Team meeting

@rivaquiroga
Copy link
Member

Hi everyone!
@jairomelo, one of our bug assessors, confirmed that @JoshuaGOB proposal is the one that can fix the problem. He also checked the solution on Windows. Changes in the English and Spanish version are ready to merge: #1997.

@spapastamkou and @DanielAlvesLABDH: if this lesson ("Creating and Viewing HTML files with Python") is under translation, please take into account these changes.

@DanielAlvesLABDH
Copy link
Contributor

@daniellesanchesDH por favor veja se a lição indicada pela Riva é uma das que está a ser traduzida. Se for avise os colegas para estarem atentos a estas alterações

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants