-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug on 'Creating and Viewing HTML files with Python' #1997
Conversation
A few things: Those lines were specifically introduced as an attempt to fix an earlier error. Here is the one that introduced the 'b' - #1630. It was a proposed solution here - #407. So can you just confirm that the things work as expected and run on windows with the change? I don't understand windows file formats enough to be able to comment. But the other thing to note is that, as these files are part of the Python sequence, you also need to update with the changes in these files - /assets/python-lessons.zip and python-es-lecciones.zip. There is a different zip file for each python lesson, and IIRC, you'll need to just make sure you update the zip files following the one in which the error appears. And the 'wb' usage actually appears in several places.…I'm trying to get a list to you. It would be great to be able to grab all of those now. |
We might have just been pointed to the two files you pinpointed based on where the bugs were reported, but they'll be issues throughout the Python sequence. |
Yes, it was checked on Windows. I'll check the zip files. Thanks for noting that! |
Awesome - thank you! |
Regarding the previous change that added the 'b', I suspect that we trusted the solution proposed by a reader without checking it on Windows 😬 |
Closes #1777 + propagates changes to Spanish translation
Checklist
- [ ] if the text needs to be translated, assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing edtor in your PR. Please follow the translation request guidelines when writing your PR descriptionCloses #ISSUENUMBER
to the description aboveIf you are having difficulty fixing Travis errors, first consult https://github.com/programminghistorian/jekyll/wiki/Making-Technical-Contributions carefully, especially "Common Travis Errors". Then contact the technical team if you need further help.