Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing unused redirect_from lessons #2095

Merged
merged 5 commits into from
Mar 25, 2021
Merged

removing unused redirect_from lessons #2095

merged 5 commits into from
Mar 25, 2021

Conversation

ZoeLeBlanc
Copy link
Member

@ZoeLeBlanc ZoeLeBlanc commented Mar 24, 2021

This PR removes unused redirect_from field from lessons and preserves redirects for actual redirects. Also closes #2093

Checklist

  • Assign yourself in the "Assignees" menu
  • Assign at least one individual or team to "Reviewers"
    • if the text needs to be translated, assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing edtor in your PR. Please follow the translation request guidelines when writing your PR description
  • Add the appropriate "Label"
  • Ensure the status checks pass
  • Check the live preview of your PR on Netlify
  • If this PR closes an open issue, add the phrase Closes #ISSUENUMBER to the description above

If you are having difficulty fixing build errors, first consult https://github.com/programminghistorian/jekyll/wiki/Making-Technical-Contributions carefully, especially "Common Build Errors". Then contact the technical team if you need further help.

@walshbr
Copy link
Contributor

walshbr commented Mar 25, 2021

Great! @ZoeLeBlanc I think that seems to have done it, but @jenniferisasi should take a look and approve as well, since she was the one who found the original errors in it.

Also you should probably note that this closes #2093, right?

@ZoeLeBlanc ZoeLeBlanc removed the request for review from jenniferisasi March 25, 2021 13:18
@ZoeLeBlanc ZoeLeBlanc merged commit 167f509 into gh-pages Mar 25, 2021
@ZoeLeBlanc ZoeLeBlanc deleted the redirect_issues branch March 25, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants