Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A workflow to auto bump versions #510

Merged
merged 3 commits into from
Sep 9, 2022
Merged

A workflow to auto bump versions #510

merged 3 commits into from
Sep 9, 2022

Conversation

Rishit-dagli
Copy link
Contributor

@Rishit-dagli Rishit-dagli commented Sep 9, 2022 •
edited
Loading

What this PR does / why we need it:

Updating versions on behalf of the contributor since we already have a run that checks the version would be very helpful as discussed in yesterday's meeting and in #500 . With this PR being merged we should expect the contributing workflow to look like this:

  • Contributor makes a PR not necessarily running the version.sh file themselves
  • Reviewer decides if it needs to be a patch, minor or major
  • Reviewer comments one of of the following the PR (these comments have no effects if made on an issue):
    • /version major
    • /version minor
    • /version patch
  • GitHub Actions makes the required changes and adds a commit to the same PR
  • GitHub Actions adds the appropriate label, one of:
    • version/major
    • version/minor
    • version/patch

Special notes for your reviewer:

Before merging this PR we need to create labels: version/minor, version/major and version/patch

Closes #500

If applicable:

  • this PR has an associated PR with documentation in akri-docs (WIP, this also requires changes to some documentation in this repo which are made in Update PR template in accordance to new workflow #511)
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • version has been updated appropriately (./version.sh)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

@Rishit-dagli Rishit-dagli mentioned this pull request Sep 9, 2022
Merged
9 tasks
@Rishit-dagli
Copy link
Contributor Author

Rishit-dagli commented Sep 9, 2022 •
edited
Loading

Here is an end-to-end example of this workflow in action: Rishit-dagli/akri-500#2

here is the action run for this: https://github.com/Rishit-dagli/akri-500/actions/runs/3021935595

PS: This uses ubuntu-20.04 instead of ubuntu-latest like in this PR since GitHub seemed to be indefinitely queuing ubuntu-latest runners

@Rishit-dagli
A workflow to auto update versions
7723b0a 
Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>
@Rishit-dagli Rishit-dagli force-pushed the Rishit-dagli-version-workflow branch from a534ac5 to 7723b0a Compare September 9, 2022 11:12
@kate-goldenring
Copy link
Contributor

@Rishit-dagli this is great and LGTM! We can update the dev docs after this to explain usage. I added the label. @Britel @bfjelds @adithyaj @romoh @jiria, any objections?

@bfjelds
Copy link
Collaborator

bfjelds commented Sep 9, 2022

love it!!

@Rishit-dagli
Don't run on comment delete
717834b 
Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>
@Rishit-dagli
Allow to checkout on a fork
a04bb38 
Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>
@Rishit-dagli Rishit-dagli force-pushed the Rishit-dagli-version-workflow branch from 90b2084 to a04bb38 Compare September 9, 2022 17:03
@Rishit-dagli
Copy link
Contributor Author

Rishit-dagli commented Sep 9, 2022 •
edited
Loading

@bfjelds I addressed the comments with the latest commits, and it now seems to work well with forks too 🥳

Feel free to see a sample run of this workflow at Rishit-dagli/akri-500#4

@kate-goldenring kate-goldenring merged commit d3b4803 into project-akri:main Sep 9, 2022
@Rishit-dagli Rishit-dagli deleted the Rishit-dagli-version-workflow branch September 10, 2022 05:00
@Rishit-dagli Rishit-dagli mentioned this pull request Sep 10, 2022
Merged
@romoh
Copy link
Contributor

romoh commented Sep 12, 2022

Thanks for doing that change @Rishit-dagli !

leoluKL pushed a commit to leoluKL/akri that referenced this pull request Sep 23, 2022
@Rishit-dagli
A workflow to auto bump versions (project-akri#510)
8c8d74e 
* A workflow to auto update versions

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* Don't run on comment delete

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* Allow to checkout on a fork

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>
Signed-off-by: Leo Lu <leolu@microsoft.com>
adithyaj added a commit that referenced this pull request Oct 19, 2022
@adithyaj @kate-goldenring
@Rishit-dagli @karok2m @github-actions
Rust toolchain update to 1.63.0 (#507)
d1f7571 
* Use latest version of clap in webhook to remove unmaintained ansi_term dep

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>

* Bump version

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>

* update toml files to v1.63.0 (latest)

Signed-off-by: Adithya J <adjayach@microsoft.com>

* update rust version + use env var in command

Signed-off-by: Adithya J <adjayach@microsoft.com>

* update toolchain + actions

Signed-off-by: Adithya J <adjayach@microsoft.com>

* update readme with new latest version

Signed-off-by: Adithya J <adjayach@microsoft.com>

* revert tarpaulin to 0.20.1, 0.21.0 is not on docker hub yet

Signed-off-by: Adithya J <adjayach@microsoft.com>

* Use `containerd` as default container runtime socket for standard Kubernetes (#508)

* Update tests

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* Update helm templates

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* Update helm values

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* Update helm lint commands

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* Updates tests

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* Update version

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* Remove Kubernetes 1.16

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* bump version

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>

* A workflow to auto bump versions (#510)

* A workflow to auto update versions

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* Don't run on comment delete

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* Allow to checkout on a fork

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* Update PR template (#511)

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* kubernetes version update

Signed-off-by: Adithya J <adjayach@microsoft.com>

* adding self as a code maintainer

Signed-off-by: Adithya J <adithyajay@gmail.com>

* Add cri-socket arg, get logs for k8s

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* add images to CTR for containerd

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* Add status on fail (best effort)

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* taint appropriate labels

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* Helm: Enabling passing multi-line strings for custom.configuration.discoveryDetails parameter in Helm values. (#522)

* Enabling passing multi-line strings for custom.configuration.discoveryDetails.

Signed-off-by: Karapet Kostandyan <kakostan@microsoft.com>

* Helm: Enabled usage of network connection for custom discovery handler. (#523)

* Helm: Enabled usage of network connection for custom discovery handler.

Signed-off-by: Karapet Kostandyan <kakostan@microsoft.com>

* Update k3s, microk8s

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* Update patch version

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Update patch version

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix borrow deref ref and use as_ref instead of to_string as linter specifies

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* needless match lint

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* Rust format update + ignoring derive PartialEq and Eq check.
prost has an issue where it does not derive Eq along with PartialEq.
Bypassing this until this is solved

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* invalid ip address msg now reworded to invalid socket address
updating check for that

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* update opcua to 0.11.0 to fix out of bounds write + uncontrolled resource consumption

Signed-off-by: Adithya J <adithyajay@gmail.com>

* Cargo.lock was previously pushed, updated with latest dependencies

Signed-off-by: Adithya J <adithyajay@gmail.com>

* Update to version 0.8.22

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* update toml files to v1.63.0 (latest)

Signed-off-by: Adithya J <adjayach@microsoft.com>

* update rust version + use env var in command

Signed-off-by: Adithya J <adjayach@microsoft.com>

* update toolchain + actions

Signed-off-by: Adithya J <adjayach@microsoft.com>

* update readme with new latest version

Signed-off-by: Adithya J <adjayach@microsoft.com>

* revert tarpaulin to 0.20.1, 0.21.0 is not on docker hub yet

Signed-off-by: Adithya J <adjayach@microsoft.com>

* fix borrow deref ref and use as_ref instead of to_string as linter specifies

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* needless match lint

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* Rust format update + ignoring derive PartialEq and Eq check.
prost has an issue where it does not derive Eq along with PartialEq.
Bypassing this until this is solved

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* invalid ip address msg now reworded to invalid socket address
updating check for that

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* version 0.8.23

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
Signed-off-by: Adithya J <adjayach@microsoft.com>
Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>
Signed-off-by: Adithya J <adithyajay@gmail.com>
Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>
Signed-off-by: Karapet Kostandyan <kakostan@microsoft.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kate Goldenring <kate.goldenring@fermyon.com>
Co-authored-by: Adithya J <adjayach@microsoft.com>
Co-authored-by: Rishit Dagli <rishit.dagli@gmail.com>
Co-authored-by: Karapet Kostandyan <karapet.kostandyan@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfjelds bfjelds bfjelds approved these changes

@kate-goldenring kate-goldenring kate-goldenring approved these changes

@jiria jiria Awaiting requested review from jiria

@Britel Britel Awaiting requested review from Britel

@romoh romoh Awaiting requested review from romoh

Assignees
No one assigned
Labels
same version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create workflow to update version on behalf of contributor
4 participants
@Rishit-dagli @kate-goldenring @bfjelds @romoh