Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Enabled usage of network connection for custom discovery handler. #523

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

karok2m
Copy link
Contributor

@karok2m karok2m commented Sep 27, 2022

What this PR does / why we need it:

This PR adds ability to use networked connection for connecting to custom discovery handler from AKRI agent.

The PR introduces 2 parameters in deployment\helm\values.yaml file of the Helm chart:

custom:
  ...
  # discovery defines a set of values for a custom discovery handler DaemonSet
  discovery:
    ...
    # useNetworkConnection specifies whether the discovery handler should make a networked connection
    # with Agents, using its pod IP address when registering
    useNetworkConnection: false
    # port specifies (when useNetworkConnection is true) the port on which the discovery handler advertises its discovery service
    port: 10000

Then those parameters are processed in deployment\helm\templates\custom-discovery-handler.yaml to expose the specified port and add POD_IP environment variable that can be used by the discovery handler to register itself with AKRI agent.

This aligns configuration of custom discovery handler with the others which already have useNetworkConnection and port parameters.

Special notes for your reviewer:

The changes are only on the Helm chart side. No changes were added to the Rust code, so cargo-related checkboxes below are irrelevant.

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

Signed-off-by: Karapet Kostandyan <kakostan@microsoft.com>
@karok2m karok2m force-pushed the feature/custom_port branch from c6f1df0 to d8181e8 Compare September 27, 2022 17:49
@kate-goldenring
Copy link
Contributor

/version patch

@github-actions github-actions bot added the version/patch Patch version change is needed label Oct 7, 2022
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kate-goldenring
Copy link
Contributor

@karok2m sorry for the delay on this! Thank you for getting our custom templates up to speed with our other protocols.

@kate-goldenring kate-goldenring merged commit ec3999f into project-akri:main Oct 7, 2022
adithyaj added a commit that referenced this pull request Oct 19, 2022
* Use latest version of clap in webhook to remove unmaintained ansi_term dep

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>

* Bump version

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>

* update toml files to v1.63.0 (latest)

Signed-off-by: Adithya J <adjayach@microsoft.com>

* update rust version + use env var in command

Signed-off-by: Adithya J <adjayach@microsoft.com>

* update toolchain + actions

Signed-off-by: Adithya J <adjayach@microsoft.com>

* update readme with new latest version

Signed-off-by: Adithya J <adjayach@microsoft.com>

* revert tarpaulin to 0.20.1, 0.21.0 is not on docker hub yet

Signed-off-by: Adithya J <adjayach@microsoft.com>

* Use `containerd` as default container runtime socket for standard Kubernetes (#508)

* Update tests

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* Update helm templates

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* Update helm values

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* Update helm lint commands

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* Updates tests

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* Update version

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* Remove Kubernetes 1.16

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* bump version

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>

* A workflow to auto bump versions (#510)

* A workflow to auto update versions

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* Don't run on comment delete

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* Allow to checkout on a fork

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* Update PR template (#511)

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>

* kubernetes version update

Signed-off-by: Adithya J <adjayach@microsoft.com>

* adding self as a code maintainer

Signed-off-by: Adithya J <adithyajay@gmail.com>

* Add cri-socket arg, get logs for k8s

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* add images to CTR for containerd

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* Add status on fail (best effort)

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* taint appropriate labels

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* Helm: Enabling passing multi-line strings for custom.configuration.discoveryDetails parameter in Helm values. (#522)

* Enabling passing multi-line strings for custom.configuration.discoveryDetails.

Signed-off-by: Karapet Kostandyan <kakostan@microsoft.com>

* Helm: Enabled usage of network connection for custom discovery handler. (#523)

* Helm: Enabled usage of network connection for custom discovery handler.

Signed-off-by: Karapet Kostandyan <kakostan@microsoft.com>

* Update k3s, microk8s

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* Update patch version

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Update patch version

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix borrow deref ref and use as_ref instead of to_string as linter specifies

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* needless match lint

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* Rust format update + ignoring derive PartialEq and Eq check.
prost has an issue where it does not derive Eq along with PartialEq.
Bypassing this until this is solved

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* invalid ip address msg now reworded to invalid socket address
updating check for that

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* update opcua to 0.11.0 to fix out of bounds write + uncontrolled resource consumption

Signed-off-by: Adithya J <adithyajay@gmail.com>

* Cargo.lock was previously pushed, updated with latest dependencies

Signed-off-by: Adithya J <adithyajay@gmail.com>

* Update to version 0.8.22

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* update toml files to v1.63.0 (latest)

Signed-off-by: Adithya J <adjayach@microsoft.com>

* update rust version + use env var in command

Signed-off-by: Adithya J <adjayach@microsoft.com>

* update toolchain + actions

Signed-off-by: Adithya J <adjayach@microsoft.com>

* update readme with new latest version

Signed-off-by: Adithya J <adjayach@microsoft.com>

* revert tarpaulin to 0.20.1, 0.21.0 is not on docker hub yet

Signed-off-by: Adithya J <adjayach@microsoft.com>

* fix borrow deref ref and use as_ref instead of to_string as linter specifies

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* needless match lint

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* Rust format update + ignoring derive PartialEq and Eq check.
prost has an issue where it does not derive Eq along with PartialEq.
Bypassing this until this is solved

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* invalid ip address msg now reworded to invalid socket address
updating check for that

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

* version 0.8.23

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
Signed-off-by: Adithya J <adjayach@microsoft.com>
Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>
Signed-off-by: Adithya J <adithyajay@gmail.com>
Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>
Signed-off-by: Karapet Kostandyan <kakostan@microsoft.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kate Goldenring <kate.goldenring@fermyon.com>
Co-authored-by: Adithya J <adjayach@microsoft.com>
Co-authored-by: Rishit Dagli <rishit.dagli@gmail.com>
Co-authored-by: Karapet Kostandyan <karapet.kostandyan@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@karok2m karok2m deleted the feature/custom_port branch February 15, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version/patch Patch version change is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants