Update PR template in accordance to new workflow #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rishit-dagli
requested review from
bfjelds,
kate-goldenring,
jiria,
Britel and
romoh
as code owners
9 tasks
Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com>
Rishit-dagli
force-pushed
the
Rishit-dagli-docs-version-workflow
branch
from
a2791a8
to
16e4490
Compare
kate-goldenring
approved these changes
Sep 9, 2022
leoluKL
pushed a commit
to leoluKL/akri
that referenced
this pull request
Sep 23, 2022
Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com> Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com> Signed-off-by: Leo Lu <leolu@microsoft.com>
adithyaj
added a commit
that referenced
this pull request
Oct 19, 2022
* Use latest version of clap in webhook to remove unmaintained ansi_term dep Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com> * Bump version Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com> * update toml files to v1.63.0 (latest) Signed-off-by: Adithya J <adjayach@microsoft.com> * update rust version + use env var in command Signed-off-by: Adithya J <adjayach@microsoft.com> * update toolchain + actions Signed-off-by: Adithya J <adjayach@microsoft.com> * update readme with new latest version Signed-off-by: Adithya J <adjayach@microsoft.com> * revert tarpaulin to 0.20.1, 0.21.0 is not on docker hub yet Signed-off-by: Adithya J <adjayach@microsoft.com> * Use `containerd` as default container runtime socket for standard Kubernetes (#508) * Update tests Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com> * Update helm templates Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com> * Update helm values Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com> * Update helm lint commands Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com> * Updates tests Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com> * Update version Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com> * Remove Kubernetes 1.16 Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com> Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com> * bump version Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com> * A workflow to auto bump versions (#510) * A workflow to auto update versions Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com> * Don't run on comment delete Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com> * Allow to checkout on a fork Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com> * Update PR template (#511) Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com> Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com> * kubernetes version update Signed-off-by: Adithya J <adjayach@microsoft.com> * adding self as a code maintainer Signed-off-by: Adithya J <adithyajay@gmail.com> * Add cri-socket arg, get logs for k8s Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com> * add images to CTR for containerd Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com> * Add status on fail (best effort) Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com> * taint appropriate labels Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com> * Helm: Enabling passing multi-line strings for custom.configuration.discoveryDetails parameter in Helm values. (#522) * Enabling passing multi-line strings for custom.configuration.discoveryDetails. Signed-off-by: Karapet Kostandyan <kakostan@microsoft.com> * Helm: Enabled usage of network connection for custom discovery handler. (#523) * Helm: Enabled usage of network connection for custom discovery handler. Signed-off-by: Karapet Kostandyan <kakostan@microsoft.com> * Update k3s, microk8s Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com> * Update patch version Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update patch version Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix borrow deref ref and use as_ref instead of to_string as linter specifies Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com> * needless match lint Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com> * Rust format update + ignoring derive PartialEq and Eq check. prost has an issue where it does not derive Eq along with PartialEq. Bypassing this until this is solved Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com> * invalid ip address msg now reworded to invalid socket address updating check for that Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com> * update opcua to 0.11.0 to fix out of bounds write + uncontrolled resource consumption Signed-off-by: Adithya J <adithyajay@gmail.com> * Cargo.lock was previously pushed, updated with latest dependencies Signed-off-by: Adithya J <adithyajay@gmail.com> * Update to version 0.8.22 Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com> * update toml files to v1.63.0 (latest) Signed-off-by: Adithya J <adjayach@microsoft.com> * update rust version + use env var in command Signed-off-by: Adithya J <adjayach@microsoft.com> * update toolchain + actions Signed-off-by: Adithya J <adjayach@microsoft.com> * update readme with new latest version Signed-off-by: Adithya J <adjayach@microsoft.com> * revert tarpaulin to 0.20.1, 0.21.0 is not on docker hub yet Signed-off-by: Adithya J <adjayach@microsoft.com> * fix borrow deref ref and use as_ref instead of to_string as linter specifies Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com> * needless match lint Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com> * Rust format update + ignoring derive PartialEq and Eq check. prost has an issue where it does not derive Eq along with PartialEq. Bypassing this until this is solved Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com> * invalid ip address msg now reworded to invalid socket address updating check for that Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com> * version 0.8.23 Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com> Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com> Signed-off-by: Adithya J <adjayach@microsoft.com> Signed-off-by: Rishit Dagli <rishit.dagli@gmail.com> Signed-off-by: Adithya J <adithyajay@gmail.com> Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com> Signed-off-by: Karapet Kostandyan <kakostan@microsoft.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Kate Goldenring <kate.goldenring@fermyon.com> Co-authored-by: Adithya J <adjayach@microsoft.com> Co-authored-by: Rishit Dagli <rishit.dagli@gmail.com> Co-authored-by: Karapet Kostandyan <karapet.kostandyan@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR follows #510 which proposes introducing a new workflow for auto bumping the versions. This PR removes running
./version.shform the PR template which I think there is no need for now, what do you think?Special notes for your reviewer:
If applicable:
cargo fmt)cargo build)cargo clippy)cargo test)cargo doc)./version.sh)