Skip to content

Conversation

@kianfar77
Copy link
Collaborator

This PR cleans and moves the docs to glow.

WIP.
Most of the text is polished.
Linked notebooks needs to be polished.

kianfar77 and others added 15 commits October 15, 2019 15:47
Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>
Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>
* oops

* fix pipe transformer cleanup

Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>
Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>
Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>
Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>
Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>
Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>
Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>
Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>
Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>
Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>
Signed-off-by: Henry D <henrydavidge@gmail.com>
Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>
* Add glue fns

Signed-off-by: Karen Feng <karen.feng@databricks.com>

* Address comments

Signed-off-by: Karen Feng <karen.feng@databricks.com>
Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>
Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>
Copy link
Contributor

@henrydavidge henrydavidge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me as a first cut. Feel free to merge after addressing comments, and we can patch it up.

Also, could you remove the .. include:: /shared/products.rst from the bottom of each page?

Copy link
Contributor

@henrydavidge henrydavidge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding explicit approval

Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>
@kianfar77 kianfar77 merged commit abbe645 into projectglow:master Oct 16, 2019
henrydavidge added a commit to henrydavidge/glow that referenced this pull request Jun 22, 2020
…rojectglow#16)

* Flatten info fields and include sample ids by default in VCF reader

* add log4j.properties

* add test for default schema

Signed-off-by: Henry Davidge <hhd@databricks.com>
henrydavidge pushed a commit to henrydavidge/glow that referenced this pull request Jun 22, 2020
* Fix Glow tests (projectglow#6)

* oops

* fix pipe transformer cleanup

Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>

* Update log4j.properties

Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>

* livehtml

Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>

* fix

Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>

* more docs

Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>

* more docs

Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>

* Add license header (projectglow#9)

Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>

* add CONTIBURING.md (projectglow#10)

Signed-off-by: Henry D <henrydavidge@gmail.com>
Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>

* notebook addresses

Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>

* glow to Glow

Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>

* more docs

Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>

* sidebar width

Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>

* utility

Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>

* [HLS-353] Add utility function docs (projectglow#12)

* Add glue fns

Signed-off-by: Karen Feng <karen.feng@databricks.com>

* Address comments

Signed-off-by: Karen Feng <karen.feng@databricks.com>
Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>

* comments addressed

Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>

Signed-off-by: Henry Davidge <hhd@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants