String tweaks #1391
Merged
String tweaks #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t lessons of the past.
…ata. This seems to be some code evolution side effects. Back when there was a custom string class, we couldn't really error when we finally saw the string was bad so we had to return the empty string, but now that full validation is done up front, it can error out.
adellahlou
pushed a commit
to adellahlou/protobuf
that referenced
this pull request
Apr 20, 2023
rinarakaki
pushed a commit
to rinarakaki/protobuf
that referenced
this pull request
Aug 30, 2023
Once merged, the changes to ~`upb-ruby.h`~ `glue.c` in protocolbuffers#11483 can be reverted without breaking the FFI feature branch. Closes protocolbuffers#1391 COPYBARA_INTEGRATE_REVIEW=protocolbuffers/upb#1391 from JasonLunn:ffi 5c3a5b8901a3017e12c96a9ea5ab2603a489fd1f PiperOrigin-RevId: 547373759
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.