-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONTRIBUTING: Ensure pip
gets upgraded; install wheel
#3060
base: master
Are you sure you want to change the base?
CONTRIBUTING: Ensure pip
gets upgraded; install wheel
#3060
Conversation
Homogenize how to activate venv (use `source` instead of `.`)
Why install wheel? Users should use The embedded pip that's installed by the |
python3 -m venv venv | ||
source venv/bin/activate | ||
pip install -U pip wheel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python3 -m venv venv | |
source venv/bin/activate | |
pip install -U pip wheel | |
python3 -m venv --upgrade-deps venv | |
source venv/bin/activate |
Not sure when this was added, but guessing it's been around for a while? Using virutalenv
ensures a recent versions of everything and is faster, but is not builtin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch, this was added in Python 3.9. One of the problems of being on a Mac... ;)
$ docker run --rm -it quay.io/pypa/manylinux_2_24_x86_64:latest bash
# python3.6 -m venv --help
# python3.7 -m venv --help
# python3.8 -m venv --help
# python3.9 -m venv --help
@@ -59,6 +59,7 @@ system with CMake 3.14+: | |||
```bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
```bash | |
```console |
Not something for now, but these should likely be changed (and prompts added).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, fine with me, we can't support --upgrade-deps
unless we make this 3.9+ only, and installing wheel is likely not needed, but if you really want it, I'll leave that up to you.
We might want to add a noxfile.py
, that might make "fly-by" contributing easier.
Homogenize how to activate venv (use
source
instead of.
)Description
While briefly investigating a possible new issue (#2972 (comment)), was doing my local build env. Re-read
CONTRIBUTING
, and noted the followigng:pip-9.0.1
, as installed by Ubuntu 18.04'spython3-venv
package, was emitting warnings likeCache entry deserialization failed, entry ignored
(due to version mismatch).wheel
.This addresess those points.
Suggested changelog entry:
N/A