Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING: Ensure pip gets upgraded; install wheel #3060

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CONTRIBUTING: Ensure pip gets upgraded; install wheel #3060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ system with CMake 3.14+:
```bash
Copy link
Collaborator

@henryiii henryiii Jun 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```bash
```console

Not something for now, but these should likely be changed (and prompts added).

python3 -m venv venv
source venv/bin/activate
pip install -U pip wheel
Comment on lines 60 to +62
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python3 -m venv venv
source venv/bin/activate
pip install -U pip wheel
python3 -m venv --upgrade-deps venv
source venv/bin/activate

Not sure when this was added, but guessing it's been around for a while? Using virutalenv ensures a recent versions of everything and is faster, but is not builtin.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, this was added in Python 3.9. One of the problems of being on a Mac... ;)

$ docker run --rm -it quay.io/pypa/manylinux_2_24_x86_64:latest bash
# python3.6 -m venv --help
# python3.7 -m venv --help
# python3.8 -m venv --help
# python3.9 -m venv --help

pip install -r tests/requirements.txt
cmake -S . -B build -DDOWNLOAD_CATCH=ON -DDOWNLOAD_EIGEN=ON
cmake --build build -j4
Expand Down Expand Up @@ -233,7 +234,8 @@ recent CMake and Python 3):

```bash
python3 -m venv venv
. venv/bin/activate
source venv/bin/activate
pip install -U pip wheel
pip install pytest
cmake -S . -B build-intel -DCMAKE_CXX_COMPILER=$(which icpc) -DDOWNLOAD_CATCH=ON -DDOWNLOAD_EIGEN=ON -DPYBIND11_WERROR=ON
```
Expand Down