FIX: Use logo_url instead deprecated logo in theme (#1094) #1097

nicoa · 2023-01-02T09:07:18Z

Hey, quickly fixed the issue described in #1094 - from a quick look over the code it seems that this is nowhere else used (and favicon neither, which was as well deprecated in sphinx).

resolves #1094

…rovided (pydata#1094)

choldgraf

This looks correct to me - i believe this new configuration value was present as is sphinx 4 so we should be ok as long as we are willing to drop support for sphinx 3- ( our policy on this is here: https://pydata-sphinx-theme.readthedocs.io/en/stable/community/topics.html#supporting-new-sphinx-versions).

Can you also change the favicon and logo in our conf.py file in the documentation?

nicoa · 2023-01-02T16:01:05Z

Sounds good :) from the pyproject.toml it seems we already pin to sphinx>=4.2, so this shouldn't be a problem.

To me it seems that the handling of html_logo and html_favicon in conf.py didn't change from looking at sphinx docs - could you guide me what you would expect to be in need of adjustment?

Further: It seems the tests didn't yet take up sphinx 6.0 as the docs rely on myst-nb which pins sphinx<6 - I'll create a ticket over there, but with this the tests are not helpful currently (and wouldn't have catched the error neither).

drammock

looks like the right fix, but would be good to have a test that fails on main and passes on this PR. Can we add a CI job that omits myst-nb from installation (and specifically requests sphinx==6)?

choldgraf · 2023-01-03T17:01:39Z

Agreed 👍 we really don't need Myst nb for all of our tests (or must is the other docs dependencies). Maybe we can only install the base requirements for our tests, and have a single test job install our documentation dependencies?

nicoa · 2023-01-03T18:34:11Z

It seems other packages are also requiring sphinx<6. Would you be fine with having an additional step that simply overrides the existing install and forces to sphinx>=6? this would allow to test for upstream versions without the hassle of making some doc packages optional (I'm not that familiar with the code and can't see what needs to be adjusted then in addition).

If you disagree and prefer the partial removal of myst-nb, I'd probably open a ticket to move the discussion around what exactly needs adjustment to get "newest version tests" out of this PR.

Edit / Update: looks like only myst-nb and sphinx-design are affected:

pip install --dry-run numpydoc | grep "Would install"
pip install --dry-run myst-nb | grep "Would install"
pip install --dry-run linkify-it-py | grep "Would install"
pip install --dry-run pytest | grep "Would install"
pip install --dry-run pytest-regressions | grep "Would install"
pip install --dry-run rich | grep "Would install"
pip install --dry-run sphinxext-rediraffe | grep "Would install"
pip install --dry-run sphinx-sitemap | grep "Would install"
pip install --dry-run ablog | grep "Would install"
pip install --dry-run jupyter_sphinx | grep "Would install"
pip install --dry-run pandas | grep "Would install"
pip install --dry-run plotly | grep "Would install"
pip install --dry-run matplotlib | grep "Would install"
pip install --dry-run numpy | grep "Would install"
pip install --dry-run xarray | grep "Would install"
pip install --dry-run sphinx-copybutton | grep "Would install"
pip install --dry-run sphinx-design | grep "Would install"
pip install --dry-run sphinx-togglebutton | grep "Would install"
pip install --dry-run nbsphinx | grep "Would install"
pip install --dry-run pytest | grep "Would install"
pip install --dry-run pytest-cov | grep "Would install"
pip install --dry-run codecov | grep "Would install"
pip install --dry-run colorama | grep "Would install"


Would install Babel-2.11.0 Jinja2-3.1.2 MarkupSafe-2.1.1 Pygments-2.14.0 Sphinx-6.0.0 alabaster-0.7.12 certifi-2022.12.7 charset-normalizer-2.1.1 docutils-0.19 idna-3.4 imagesize-1.4.1 importlib-metadata-6.0.0 numpydoc-1.5.0 packaging-22.0 pytz-2022.7 requests-2.28.1 snowballstemmer-2.2.0 sphinxcontrib-applehelp-1.0.2 sphinxcontrib-devhelp-1.0.2 sphinxcontrib-htmlhelp-2.0.0 sphinxcontrib-jsmath-1.0.1 sphinxcontrib-qthelp-1.0.3 sphinxcontrib-serializinghtml-1.1.5 urllib3-1.26.13 zipp-3.11.0
Would install Babel-2.11.0 Jinja2-3.1.2 MarkupSafe-2.1.1 PyYAML-6.0 Pygments-2.14.0 SQLAlchemy-1.4.45 Sphinx-5.3.0 alabaster-0.7.12 appnope-0.1.3 asttokens-2.2.1 attrs-22.2.0 backcall-0.2.0 certifi-2022.12.7 charset-normalizer-2.1.1 click-8.1.3 comm-0.1.2 debugpy-1.6.4 decorator-5.1.1 docutils-0.19 entrypoints-0.4 executing-1.2.0 fastjsonschema-2.16.2 greenlet-2.0.1 idna-3.4 imagesize-1.4.1 importlib-metadata-6.0.0 ipykernel-6.19.4 ipython-8.8.0 jedi-0.18.2 jsonschema-4.17.3 jupyter-cache-0.5.0 jupyter_client-7.4.8 jupyter_core-5.1.2 markdown-it-py-2.1.0 matplotlib-inline-0.1.6 mdit-py-plugins-0.3.3 mdurl-0.1.2 myst-nb-0.17.1 myst-parser-0.18.1 nbclient-0.5.13 nbformat-5.7.1 nest-asyncio-1.5.6 packaging-22.0 parso-0.8.3 pexpect-4.8.0 pickleshare-0.7.5 platformdirs-2.6.2 prompt-toolkit-3.0.36 psutil-5.9.4 ptyprocess-0.7.0 pure-eval-0.2.2 pyrsistent-0.19.3 python-dateutil-2.8.2 pytz-2022.7 pyzmq-24.0.1 requests-2.28.1 six-1.16.0 snowballstemmer-2.2.0 sphinxcontrib-applehelp-1.0.2 sphinxcontrib-devhelp-1.0.2 sphinxcontrib-htmlhelp-2.0.0 sphinxcontrib-jsmath-1.0.1 sphinxcontrib-qthelp-1.0.3 sphinxcontrib-serializinghtml-1.1.5 stack-data-0.6.2 tabulate-0.9.0 tornado-6.2 traitlets-5.8.0 typing_extensions-4.4.0 urllib3-1.26.13 wcwidth-0.2.5 zipp-3.11.0
Would install linkify-it-py-2.0.0 uc-micro-py-1.0.1
Would install attrs-22.2.0 exceptiongroup-1.1.0 iniconfig-1.1.1 packaging-22.0 pluggy-1.0.0 pytest-7.2.0 tomli-2.0.1
Would install PyYAML-6.0 attrs-22.2.0 exceptiongroup-1.1.0 iniconfig-1.1.1 packaging-22.0 pluggy-1.0.0 pytest-7.2.0 pytest-datadir-1.4.1 pytest-regressions-2.4.1 tomli-2.0.1
Would install Pygments-2.14.0 commonmark-0.9.1 rich-13.0.0
Would install Babel-2.11.0 Jinja2-3.1.2 MarkupSafe-2.1.1 Pygments-2.14.0 Sphinx-6.0.0 alabaster-0.7.12 certifi-2022.12.7 charset-normalizer-2.1.1 docutils-0.19 idna-3.4 imagesize-1.4.1 importlib-metadata-6.0.0 packaging-22.0 pytz-2022.7 requests-2.28.1 snowballstemmer-2.2.0 sphinxcontrib-applehelp-1.0.2 sphinxcontrib-devhelp-1.0.2 sphinxcontrib-htmlhelp-2.0.0 sphinxcontrib-jsmath-1.0.1 sphinxcontrib-qthelp-1.0.3 sphinxcontrib-serializinghtml-1.1.5 sphinxext-rediraffe-0.2.7 urllib3-1.26.13 zipp-3.11.0
Would install Babel-2.11.0 Jinja2-3.1.2 MarkupSafe-2.1.1 Pygments-2.14.0 Sphinx-6.0.0 alabaster-0.7.12 certifi-2022.12.7 charset-normalizer-2.1.1 docutils-0.19 idna-3.4 imagesize-1.4.1 importlib-metadata-6.0.0 packaging-22.0 pytz-2022.7 requests-2.28.1 snowballstemmer-2.2.0 sphinx-sitemap-2.4.0 sphinxcontrib-applehelp-1.0.2 sphinxcontrib-devhelp-1.0.2 sphinxcontrib-htmlhelp-2.0.0 sphinxcontrib-jsmath-1.0.1 sphinxcontrib-qthelp-1.0.3 sphinxcontrib-serializinghtml-1.1.5 urllib3-1.26.13 zipp-3.11.0
Would install Babel-2.11.0 Jinja2-3.1.2 MarkupSafe-2.1.1 Pygments-2.14.0 Sphinx-6.0.0 ablog-0.10.33 alabaster-0.7.12 certifi-2022.12.7 charset-normalizer-2.1.1 docutils-0.19 feedgen-0.9.0 idna-3.4 imagesize-1.4.1 importlib-metadata-6.0.0 invoke-1.7.3 lxml-4.9.2 packaging-22.0 python-dateutil-2.8.2 pytz-2022.7 requests-2.28.1 six-1.16.0 snowballstemmer-2.2.0 sphinxcontrib-applehelp-1.0.2 sphinxcontrib-devhelp-1.0.2 sphinxcontrib-htmlhelp-2.0.0 sphinxcontrib-jsmath-1.0.1 sphinxcontrib-qthelp-1.0.3 sphinxcontrib-serializinghtml-1.1.5 urllib3-1.26.13 watchdog-2.2.1 zipp-3.11.0
Would install Babel-2.11.0 Jinja2-3.1.2 MarkupSafe-2.1.1 Pygments-2.14.0 Sphinx-6.0.0 alabaster-0.7.12 appnope-0.1.3 asttokens-2.2.1 attrs-22.2.0 backcall-0.2.0 beautifulsoup4-4.11.1 bleach-5.0.1 certifi-2022.12.7 charset-normalizer-2.1.1 comm-0.1.2 debugpy-1.6.4 decorator-5.1.1 defusedxml-0.7.1 docutils-0.19 entrypoints-0.4 executing-1.2.0 fastjsonschema-2.16.2 idna-3.4 imagesize-1.4.1 importlib-metadata-6.0.0 ipykernel-6.19.4 ipython-8.8.0 ipywidgets-8.0.4 jedi-0.18.2 jsonschema-4.17.3 jupyter-sphinx-0.4.0 jupyter_client-7.4.8 jupyter_core-5.1.2 jupyterlab-pygments-0.2.2 jupyterlab-widgets-3.0.5 matplotlib-inline-0.1.6 mistune-2.0.4 nbclient-0.7.2 nbconvert-7.2.7 nbformat-5.7.1 nest-asyncio-1.5.6 packaging-22.0 pandocfilters-1.5.0 parso-0.8.3 pexpect-4.8.0 pickleshare-0.7.5 platformdirs-2.6.2 prompt-toolkit-3.0.36 psutil-5.9.4 ptyprocess-0.7.0 pure-eval-0.2.2 pyrsistent-0.19.3 python-dateutil-2.8.2 pytz-2022.7 pyzmq-24.0.1 requests-2.28.1 six-1.16.0 snowballstemmer-2.2.0 soupsieve-2.3.2.post1 sphinxcontrib-applehelp-1.0.2 sphinxcontrib-devhelp-1.0.2 sphinxcontrib-htmlhelp-2.0.0 sphinxcontrib-jsmath-1.0.1 sphinxcontrib-qthelp-1.0.3 sphinxcontrib-serializinghtml-1.1.5 stack-data-0.6.2 tinycss2-1.2.1 tornado-6.2 traitlets-5.8.0 urllib3-1.26.13 wcwidth-0.2.5 webencodings-0.5.1 widgetsnbextension-4.0.5 zipp-3.11.0
Would install numpy-1.24.1 pandas-1.5.2 python-dateutil-2.8.2 pytz-2022.7 six-1.16.0
Would install plotly-5.11.0 tenacity-8.1.0
Would install Pillow-9.4.0 contourpy-1.0.6 cycler-0.11.0 fonttools-4.38.0 kiwisolver-1.4.4 matplotlib-3.6.2 numpy-1.24.1 packaging-22.0 pyparsing-3.0.9 python-dateutil-2.8.2 six-1.16.0
Would install numpy-1.24.1
Would install numpy-1.24.1 packaging-22.0 pandas-1.5.2 python-dateutil-2.8.2 pytz-2022.7 six-1.16.0 xarray-2022.12.0
Would install Babel-2.11.0 Jinja2-3.1.2 MarkupSafe-2.1.1 Pygments-2.14.0 Sphinx-6.0.0 alabaster-0.7.12 certifi-2022.12.7 charset-normalizer-2.1.1 docutils-0.19 idna-3.4 imagesize-1.4.1 importlib-metadata-6.0.0 packaging-22.0 pytz-2022.7 requests-2.28.1 snowballstemmer-2.2.0 sphinx-copybutton-0.5.1 sphinxcontrib-applehelp-1.0.2 sphinxcontrib-devhelp-1.0.2 sphinxcontrib-htmlhelp-2.0.0 sphinxcontrib-jsmath-1.0.1 sphinxcontrib-qthelp-1.0.3 sphinxcontrib-serializinghtml-1.1.5 urllib3-1.26.13 zipp-3.11.0
Would install Babel-2.11.0 Jinja2-3.1.2 MarkupSafe-2.1.1 Pygments-2.14.0 Sphinx-5.3.0 alabaster-0.7.12 certifi-2022.12.7 charset-normalizer-2.1.1 docutils-0.19 idna-3.4 imagesize-1.4.1 importlib-metadata-6.0.0 packaging-22.0 pytz-2022.7 requests-2.28.1 snowballstemmer-2.2.0 sphinx_design-0.3.0 sphinxcontrib-applehelp-1.0.2 sphinxcontrib-devhelp-1.0.2 sphinxcontrib-htmlhelp-2.0.0 sphinxcontrib-jsmath-1.0.1 sphinxcontrib-qthelp-1.0.3 sphinxcontrib-serializinghtml-1.1.5 urllib3-1.26.13 zipp-3.11.0
Would install Babel-2.11.0 Jinja2-3.1.2 MarkupSafe-2.1.1 Pygments-2.14.0 Sphinx-6.0.0 alabaster-0.7.12 certifi-2022.12.7 charset-normalizer-2.1.1 docutils-0.19 idna-3.4 imagesize-1.4.1 importlib-metadata-6.0.0 packaging-22.0 pytz-2022.7 requests-2.28.1 snowballstemmer-2.2.0 sphinx-togglebutton-0.3.2 sphinxcontrib-applehelp-1.0.2 sphinxcontrib-devhelp-1.0.2 sphinxcontrib-htmlhelp-2.0.0 sphinxcontrib-jsmath-1.0.1 sphinxcontrib-qthelp-1.0.3 sphinxcontrib-serializinghtml-1.1.5 urllib3-1.26.13 zipp-3.11.0
Would install Babel-2.11.0 Jinja2-3.1.2 MarkupSafe-2.1.1 Pygments-2.14.0 Sphinx-6.0.0 alabaster-0.7.12 attrs-22.2.0 beautifulsoup4-4.11.1 bleach-5.0.1 certifi-2022.12.7 charset-normalizer-2.1.1 defusedxml-0.7.1 docutils-0.19 entrypoints-0.4 fastjsonschema-2.16.2 idna-3.4 imagesize-1.4.1 importlib-metadata-6.0.0 jsonschema-4.17.3 jupyter_client-7.4.8 jupyter_core-5.1.2 jupyterlab-pygments-0.2.2 mistune-2.0.4 nbclient-0.7.2 nbconvert-7.2.7 nbformat-5.7.1 nbsphinx-0.8.11 nest-asyncio-1.5.6 packaging-22.0 pandocfilters-1.5.0 platformdirs-2.6.2 pyrsistent-0.19.3 python-dateutil-2.8.2 pytz-2022.7 pyzmq-24.0.1 requests-2.28.1 six-1.16.0 snowballstemmer-2.2.0 soupsieve-2.3.2.post1 sphinxcontrib-applehelp-1.0.2 sphinxcontrib-devhelp-1.0.2 sphinxcontrib-htmlhelp-2.0.0 sphinxcontrib-jsmath-1.0.1 sphinxcontrib-qthelp-1.0.3 sphinxcontrib-serializinghtml-1.1.5 tinycss2-1.2.1 tornado-6.2 traitlets-5.8.0 urllib3-1.26.13 webencodings-0.5.1 zipp-3.11.0
Would install attrs-22.2.0 exceptiongroup-1.1.0 iniconfig-1.1.1 packaging-22.0 pluggy-1.0.0 pytest-7.2.0 tomli-2.0.1
Would install attrs-22.2.0 coverage-7.0.2 exceptiongroup-1.1.0 iniconfig-1.1.1 packaging-22.0 pluggy-1.0.0 pytest-7.2.0 pytest-cov-4.0.0 tomli-2.0.1
Would install certifi-2022.12.7 charset-normalizer-2.1.1 codecov-2.1.12 coverage-7.0.2 idna-3.4 requests-2.28.1 urllib3-1.26.13
Would install colorama-0.4.6

nicoa · 2023-01-03T20:05:12Z

I'd happily file a new PR for additional tests, please leave your comments at the issue #1099 .

choldgraf · 2023-01-14T10:43:32Z

I've added a deprecation warning for this one so that it doesn't surprise people. I think that this is now ready to go.

choldgraf · 2023-01-14T10:50:54Z

ah nevermind, I rolled back my last commit, that's because I didn't understand the Sphinx change properly. I believe that only the template API was changed, not the user-facing API. This is a purely under-the-hood change from Sphinx, so html_logo is still the correct config, it is only on the Jinja side we needed to change this, and thus I don't think we need any deprecation cycles for this.

I think we can just merge this

nicoa · 2023-01-14T11:36:27Z

Exactly, that confused me at the beginning as well - thanks for the clarification!

nicoa · 2023-01-14T12:30:02Z

Hey, as you are already involved here, maybe one of you (@choldgraf @12rambau @drammock ) could have a look here #1113 as well, as per the first review here it was stated that it should be nice to have the tests on main failing and the ones on this branch (rebased then) passing, which would be made possible by that one.

If it is fine as it is: feel free to merge this without further notice :-)

In any case: thanks for your helpful suggestions!

choldgraf · 2023-01-14T13:42:30Z

I think that we should merge this one in, because it solves our immediate problem. I'm OK not having a test for it since this is an under-the-hood change and it's basically just updating a deprecation, rather than a bug per-se.

I think we can discuss other options for installing dependencies in the tests, but we don't want that to block this one IMO.

* Fix extra whitespace in sidebars (pydata#1115) * Fix extra whitespace in sidebars * Searchbox * Update src/pydata_sphinx_theme/__init__.py Co-authored-by: Daniel McCloy <dan@mccloy.info> * make test pass * Fix template filter to remove empty files * ABlog in template test * Move clear search button to primary sidebar * Move search clear button to top of article Co-authored-by: Daniel McCloy <dan@mccloy.info> * FIX: Use logo_url instead deprecated logo in theme (pydata#1094) (pydata#1097) resolves pydata#1094 * ENH/MAINT: avoid overwriting the HtmlTranslator (pydata#1105) Co-authored-by: Chris Holdgraf <choldgraf@gmail.com> Fix pydata#143 Fix pydata#94 * fix: align sidebar sliding with the buttons (pydata#1123) * fix: aline the sidebar sliding with the buttons * build: force test to run on all platform if one platform is failing we cannot see if it's platform related as the other were closed * fix: use correct path for documentation logo * MAINT: Improve font sizing (pydata#1129) Fix pydata#1001 * MAINT: Refactor workflows to reduce test dependencies (pydata#1136) * MAINT: update prerelease workflow (pydata#1140) * ABlog: Updates for new HTML structure (pydata#1118) * ABlog: Updates for new HTML structure * Update templates for latest release * Bump to dev0 * Standardize logo image behavior between Sphinx and this theme (pydata#1132) Co-authored-by: Daniel McCloy <dan@mccloy.info> Co-authored-by: Chris Holdgraf <choldgraf@gmail.com> Co-authored-by: Chris Holdgraf <choldgraf@berkeley.edu> * 0.13.0rc1 * Build(deps): Bump http-cache-semantics from 4.1.0 to 4.1.1 (pydata#1154) * DOC: Use only shield.io for badges in README (pydata#1152) * Copyright semicolon (pydata#1160) * FIX: Flex behavior should shrink header items instead of brand (pydata#1158) Co-authored-by: Chris Holdgraf <choldgraf@gmail.com> Fixes pydata#1143 * STYLE: lint the documentation with Doc8 (pydata#1150) Fix pydata#1139 * Add test for internationalization and translations (pydata#1138) * FIX: Javascript incorrect check for variable (pydata#1166) * MAINT: update pypi classifiers (pydata#1153) Fix pydata#1106 * remove emoji from landing page (pydata#1151) * add fa icons instead of emoji * remove fix for emojis * use markup for readme emojis * use pst-color-primary instead of sd-text-primary * make our semantic colors available as classes * try again --------- Co-authored-by: Daniel McCloy <dan@mccloy.info> * FIX: Narrow scope of style rule for GitHub & GitLab link shortening (pydata#1167) Fixes pydata#1156 * ENH: Add breadcrumbs to article header (pydata#1142) * ENH: Add breadcrumbs to article header * Update src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/breadcrumbs.html Co-authored-by: Tania Allard <taniar.allard@gmail.com> * More fixes * Improving nested page behavior * Documenting breadcrumbs * Update src/pydata_sphinx_theme/assets/styles/components/_breadcrumbs.scss Co-authored-by: Rambaud Pierrick <12rambau@users.noreply.github.com> * Breacrumbs have link color --------- Co-authored-by: Tania Allard <taniar.allard@gmail.com> Co-authored-by: Rambaud Pierrick <12rambau@users.noreply.github.com> * Degrade gracefully when JavaScript is disabled (pydata#1146) * Fix header vertical spacing and jupyter-sphinx cells (pydata#1164) Fixes undefined * RLS: v0.13.0rc2 (pydata#1170) * DOCS: admonition customization (pydata#1155) * first draft of the admonition customization * typo in doc link * flesh out admon. customization example; DRY * use :code:rst instead of :literal: * Update docs/_static/custom.css --------- Co-authored-by: Daniel McCloy <dan@mccloy.info> * Fix article header CSS (pydata#1171) * “Edit this page” → “Edit on GitHub/GitLab/Bitbucket” (pydata#1177) * “Edit this page” → “Edit on GitHub/GitLab/Bitbucket” Fixes pydata#1172 * Add tests * Fix typo * Properly handle default_mode=auto when writing logos (pydata#1183) We used to only defaulting to the light version when `default_mode` was undefined, not when it was explicitly set to `auto`. We also need to handle the latter, as the new test shows. Closes pydata#1180 Co-authored-by: Jérémy Bobbio (Lunar) <lunar@softwareheritage.org> * fix: correctly add DOM listeners (pydata#1179) fix adding DOM listeners * maint: update GitLab URL tests (pydata#1186) Co-authored-by: JoerivanEngelen <joerivanengelen@hotmail.com> * Standardize template structure in more sections (pydata#1184) * Standardize template structure in all sections * Fixing footer behavior * Update docs/user_guide/layout.rst Co-authored-by: Daniel McCloy <dan@mccloy.info> * Remove use of id= as much as possible --------- Co-authored-by: Daniel McCloy <dan@mccloy.info> * maint: remove sphinx-panels support; remove deprecated config shims (pydata#1188) * Minor style improvements to ablog (pydata#1185) * RLS: v0.13.0rc3 * dev0 * FIX: Some style bugs (pydata#1191) * FIX: Some style bugs * Move link word wrap to global rule * DOCS: Add internationalization instructions (pydata#1178) Co-authored-by: James McKinney <26463+jpmckinney@users.noreply.github.com> * Refactor contributing docs to be more modular (pydata#1173) * Dev0 * Fix github gitlab brand (pydata#1194) * RLS: v0.13.0rc4 * FIX: Make wide equations scroll (pydata#1196) * Fix math scrollbars for realz (pydata#1198) * Fix math scrollbars for realz * Update src/pydata_sphinx_theme/assets/styles/content/_math.scss * Update src/pydata_sphinx_theme/assets/styles/content/_math.scss * copy_logo_images: do not render dynamic Sphinx template content (pydata#1204) * copy_logo_images: do not render dynamic Sphinx template content when copying logo image files * Update src/pydata_sphinx_theme/__init__.py --------- Co-authored-by: Chris Holdgraf <choldgraf@gmail.com> * Add conditional check for last-updated template (pydata#1201) * Add conditional check for last-updated template * Whitespace * Properly set configuration with app.builder.theme_options (pydata#1199) * Properly set configuration * Dict to values * Making it explicit in a function * Better name * Fix test * Foot * Revert complex config set * Clarify docs * Use CSS transform for skip link (pydata#1206) * feat: Add full i18n support (pydata#1192) Co-authored-by: Daniel McCloy <dan@mccloy.info> Co-authored-by: James McKinney <26463+jpmckinney@users.noreply.github.com> Co-authored-by: Chris Holdgraf <choldgraf@berkeley.edu> Co-authored-by: Chris Holdgraf <choldgraf@gmail.com> * Dev0 * FIX: Remove icon links component when no icon links given (pydata#1209) * RLS: 0.13.0rc5 * dev0 * FIX: Get theme options in a more robust way (pydata#1214) * RLS: v0.13.0rc6 * Make heading-style use the font-weight-heading value (pydata#1213) * Make heading-style use the font-weight-heading value * Separate font-weight setting for content headers and admonitions * Flip var to be consistent with --pst-font-weight-heading instead * RLS: v0.13.0 * bump: dev0 * DOCS: Remove <p> from announcement sample text (pydata#1223) --------- Co-authored-by: Chris Holdgraf <choldgraf@berkeley.edu> Co-authored-by: Daniel McCloy <dan@mccloy.info> Co-authored-by: Nico Albers <nico.albers@aboutyou.com> Co-authored-by: Chris Holdgraf <choldgraf@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brendan Heberlein <bheberlein@wisc.edu> Co-authored-by: Tania Allard <taniar.allard@gmail.com> Co-authored-by: Lunar <lunar@debian.org> Co-authored-by: Jean Abou-Samra <jean@abou-samra.fr> Co-authored-by: Jérémy Bobbio (Lunar) <lunar@softwareheritage.org> Co-authored-by: JoerivanEngelen <joerivanengelen@hotmail.com> Co-authored-by: James McKinney <26463+jpmckinney@users.noreply.github.com> Co-authored-by: James Addison <55152140+jayaddison@users.noreply.github.com> Co-authored-by: Veronica Berglyd Olsen <1619840+vkbo@users.noreply.github.com>

FIX: use logo_url instead deprecated logo in theme if no theme_logo p…

bf78285

…rovided (pydata#1094)

choldgraf reviewed Jan 2, 2023

View reviewed changes

nicoa mentioned this pull request Jan 2, 2023

allow for sphinx 6.0 executablebooks/MyST-NB#466

Closed

wistuba mentioned this pull request Jan 3, 2023

Downgrading sphinx-opengraph version after failure awslabs/Renate#85

Closed

drammock reviewed Jan 3, 2023

View reviewed changes

drammock mentioned this pull request Jan 3, 2023

pin sphinx < 6.0 mne-tools/mne-bids#1115

Merged

7 tasks

nicoa mentioned this pull request Jan 3, 2023

support sphinx 6 executablebooks/sphinx-design#118

Closed

drammock mentioned this pull request Jan 6, 2023

create additional test without respecting restrictions on sphinx version of dependant packages #1099

Closed

drammock added the impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship label Jan 11, 2023

choldgraf force-pushed the fix/unknown_logo branch from 2b0671d to bf78285 Compare January 14, 2023 10:49

12rambau approved these changes Jan 14, 2023

View reviewed changes

choldgraf changed the title ~~FIX: use logo_url instead deprecated logo in theme if no theme_logo provided (#1094)~~ FIX: Use logo_url instead deprecated logo in theme (#1094) Jan 14, 2023

choldgraf merged commit 6829b62 into pydata:main Jan 14, 2023

nicoa deleted the fix/unknown_logo branch January 14, 2023 14:25

12rambau mentioned this pull request Jan 23, 2023

logo is not display in the "latest" version of the doc #1130

Closed

choldgraf mentioned this pull request Jan 23, 2023

fix: use correct path for documentation logo #1131

Closed

gadomski mentioned this pull request Jan 26, 2023

build(deps): update sphinx requirement from ~=5.3 to ~=6.1 stac-utils/pystac-client#399

Closed

thomasjpfan mentioned this pull request Apr 17, 2023

Updates pydata_sphinx_theme to work with Sphinx >= 6.0 mwaskom/seaborn#3328

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FIX: Use logo_url instead deprecated logo in theme (#1094) #1097

FIX: Use logo_url instead deprecated logo in theme (#1094) #1097

nicoa commented Jan 2, 2023

choldgraf left a comment

nicoa commented Jan 2, 2023 •

edited

Loading

drammock left a comment

choldgraf commented Jan 3, 2023

nicoa commented Jan 3, 2023 •

edited

Loading

nicoa commented Jan 3, 2023

choldgraf commented Jan 14, 2023

choldgraf commented Jan 14, 2023 •

edited

Loading

nicoa commented Jan 14, 2023

nicoa commented Jan 14, 2023 •

edited

Loading

choldgraf commented Jan 14, 2023

FIX: Use logo_url instead deprecated logo in theme (#1094) #1097

FIX: Use logo_url instead deprecated logo in theme (#1094) #1097

Conversation

nicoa commented Jan 2, 2023

choldgraf left a comment

Choose a reason for hiding this comment

nicoa commented Jan 2, 2023 • edited Loading

drammock left a comment

Choose a reason for hiding this comment

choldgraf commented Jan 3, 2023

nicoa commented Jan 3, 2023 • edited Loading

nicoa commented Jan 3, 2023

choldgraf commented Jan 14, 2023

choldgraf commented Jan 14, 2023 • edited Loading

nicoa commented Jan 14, 2023

nicoa commented Jan 14, 2023 • edited Loading

choldgraf commented Jan 14, 2023

nicoa commented Jan 2, 2023 •

edited

Loading

nicoa commented Jan 3, 2023 •

edited

Loading

choldgraf commented Jan 14, 2023 •

edited

Loading

nicoa commented Jan 14, 2023 •

edited

Loading