Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RC version 0.2.0 #98

Merged
merged 152 commits into from
Mar 15, 2024
Merged

RC version 0.2.0 #98

merged 152 commits into from
Mar 15, 2024

Conversation

aburrell
Copy link
Member

@aburrell aburrell commented Feb 26, 2024 •
edited
Loading

Description

Release candidate fulfilling v0.2.0 milestones.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality or documentation)
  • This change requires a documentation update

How Has This Been Tested?

Unit tests and examples

Test Configuration

  • Operating system: OS X Big Sur
  • Version number: Python 3.9
  • Any details about your local setup that are relevant: RC branch of pysat

Checklist:

  • Update the version number
  • Verify and update Zenodo information in .zenodo.json
  • doc tests pass locally
  • activate this branch on readthedocs
  • Upload the test distribution to the testPyPi server: https://test.pypi.org/project/pysatMadrigal/0.2.0rc1/
  • Contacted developers and users about the future release
  • Performed integration tests with downstream packages (include list of these packages)
  • Create a wiki page with the release text: https://github.com/pysat/pysatMadrigal/wiki/v0.2.0
  • After approval, confirm all changes from the RC pull are listed in the wiki release text.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have linted the files updated in this pull request
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

aburrell and others added 30 commits March 2, 2023 16:47
@aburrell
BUG: fixed download stop time
8875a0f 
Fixed the definition of the download stop time, not assuming it has a daily cadence.
@aburrell
ENH: added DMSP SSJ instrument
b9582f9 
Added an instrument for the DMSP SSJ auroral boundary data.
@aburrell
DOC: updated the supported instruments
fb9113e 
Added the DMSP SSJ instrument to the docs.
@aburrell
DOC: updated changelog
255c052 
Added a summary of the changes to the changelog.
@aburrell
MAINT: removed temporary code
06ad0c9 
Removed code needed to handle failure of pysat to allow local definitions of start/stop times.
@aburrell
DOC: updated CHANGELOG
96d3e89 
Updated changelog with a description of this pull.
@aburrell
MAINT: updated pysat version limit
dbf8b60 
Updated the pysat version limit to the next release that will include all the necessary changes for pysatMadrigal to work as expected.
@aburrell
Merge pull request #85 from pysat/rc_v0.1.0
5e74477 
Rc v0.1.0
@jklenzing
TST: add rc install workflow
dc99c8e
@jklenzing
MAINT: update pip syntax
22437e3
@jklenzing
DOC: update changelog
aece8aa
@jklenzing
MAINT: set to push
120699d
@jklenzing
TST: set to workflow_dispatch
d739546
@jklenzing
Update pip_rc_install.yml
bd6c6c2
@jklenzing
Update test_requirements.txt
6e7658a
@jklenzing
ENH: add version to package
87fb3ca
@jklenzing
DOC: add docstring
c18d806
@aburrell
MAINT: remove ssj from general pandas
76b7021 
Because DMSP SSJ requires annual loading, it cannot be handled correctly by the general pandas instrument.
@jklenzing
Merge pull request #86 from pysat/tst/ga_updates
b465b50 
MAINT: GA updates
@aburrell
BUG: add sphinx version limit
8c70783 
Fix CI docs tests with a sphinx version limit.
@aburrell
STY: made flake8 updates
673c668 
Updated the docstring and import style.
@aburrell
STY: update flake8
8b30f43 
Attempt to update flake8 so PEP8 tests pass.
@aburrell
STY: removed extra blank line
06d472d 
Removed an extra blank line in a docstring.
@aburrell
BUG: fixed variable case
1185105 
Fixed variable names to lowercase, to comply with pysat standards.
@aburrell
Merge pull request #81 from pysat/dmsp_ssj4
15a95df 
ENH: Added a DMSP SSJ instrument
@aburrell
Merge pull request #87 from pysat/dmsp_ssj4
445f617 
Recent changes update
@aburrell
Merge pull request #82 from pysat/update_pysat_remote_file_list
822d3cc 
Update pysat remote file list
@aburrell
TST: added windows to CI
01591fc 
Added Windows to CI, may or may not work.
@aburrell
TST: added close statement
1e20399 
Added a close statement to help Windows OS.
@aburrell
BUG: removed the AE data
7335346 
Removed the AE data from the general madrigal instrument, as they have a very large file and by default have duplicated times.
rstoneback
rstoneback reviewed Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@rstoneback rstoneback left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass through, review not quite complete. Release is looking good!

ACKNOWLEDGEMENTS.md Outdated Show resolved Hide resolved
docs/supported_instruments.rst Outdated Show resolved Hide resolved
docs/supported_instruments.rst Outdated Show resolved Hide resolved
docs/supported_instruments.rst Outdated Show resolved Hide resolved
pysatMadrigal/instruments/dmsp_ivm.py Show resolved Hide resolved
pysatMadrigal/instruments/omni2_imf.py Outdated Show resolved Hide resolved
pysatMadrigal/instruments/omni2_imf.py Outdated Show resolved Hide resolved
pysatMadrigal/instruments/omni2_imf.py Outdated Show resolved Hide resolved
pysatMadrigal/instruments/omni2_imf.py Outdated Show resolved Hide resolved
pysatMadrigal/tests/test_instruments.py Show resolved Hide resolved
rstoneback
rstoneback reviewed Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@rstoneback rstoneback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second pass complete. Turns out I was close to the end first time round.

pysatMadrigal/tests/test_methods_general.py Show resolved Hide resolved
pysatMadrigal/tests/test_methods_general.py Show resolved Hide resolved
pysatMadrigal/tests/test_methods_gnss.py Show resolved Hide resolved
@aburrell @rstoneback
MAINT: applied suggestions
72d6224 
Applied suggestions from code review.

Co-authored-by: Russell Stoneback <github@stoneris.com>
@aburrell
DOC: improve DMSP SSJ init
6c2fc0d 
Improve the user output for the DMSP SSJ instrument.
@aburrell @rstoneback
MAINT: applied code review
ea2ff92 
Found more code review comments and made changes.

Co-authored-by: Russell Stoneback <github@stoneris.com>
@aburrell aburrell requested a review from rstoneback March 11, 2024 22:02
@aburrell @rstoneback
DOC: add TODO statements
a2d7a3f 
Added TODO statements for new issues.

Co-authored-by: Russell Stoneback <github@stoneris.com>
@aburrell aburrell requested a review from rstoneback March 12, 2024 15:18
@aburrell
BUG: fix TODO formatting
d09a808 
Use the correct TODO formatting.
aburrell
aburrell commented Mar 13, 2024
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
aburrell
aburrell commented Mar 13, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@aburrell
REV: python 3.12 failing on mac
5af4b31 
Remove support for 3.12 from this release.
@aburrell
Copy link
Member Author

Poking @rstoneback and @JonathonMSmith for a review!

@rstoneback
Copy link
Collaborator

I've been trying to sort out where the reduction in testing coverage came from but coveralls has been giving me gateway errors for a couple days. Still is. Don't want to keep holding things up.

@aburrell
Copy link
Member Author

@rstoneback it's because we can't download the LoS data (it's too big to handle through GH Actions). Coveralls has been stretched lately 😿

aburrell
aburrell commented Mar 15, 2024
View reviewed changes
Copy link
Member Author

@aburrell aburrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a line in the changelog that needs to be fixed.

CHANGELOG.md Outdated Show resolved Hide resolved
@aburrell
MAINT: Update CHANGELOG.md
3d512a2 
Support for python 3.12 was removed until a documented issue can be solved.
@aburrell aburrell merged commit e07ca36 into main Mar 15, 2024
21 of 23 checks passed
@aburrell aburrell deleted the rc_version_0.2.0 branch March 18, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklenzing jklenzing jklenzing approved these changes

@rstoneback rstoneback rstoneback approved these changes

@JonathonMSmith JonathonMSmith Awaiting requested review from JonathonMSmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@aburrell @rstoneback @jklenzing