Skip to content

Translate library/exceptions part 2/3 #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

mindihx
Copy link
Collaborator

@mindihx mindihx commented Jul 13, 2024

issue: #806

@mindihx
Copy link
Collaborator Author

mindihx commented Sep 4, 2024

@mattwang44
這兩個 pr 再麻煩你幫忙看看有沒有人有時間可以 review 了,謝謝~
#920
#938

@mattwang44
Copy link
Collaborator

@mattwang44 這兩個 pr 再麻煩你幫忙看看有沒有人有時間可以 review 了,謝謝~ #920 #938

抱歉我這兩天會找時間看 🙏🏽
conflict 可以麻煩你幫忙修掉嗎~

@mindihx
Copy link
Collaborator Author

mindihx commented Sep 6, 2024

@mattwang44 這兩個 pr 再麻煩你幫忙看看有沒有人有時間可以 review 了,謝謝~ #920 #938

抱歉我這兩天會找時間看 🙏🏽 conflict 可以麻煩你幫忙修掉嗎~

不急啦只是怕它們被遺忘XD,看你時間安排~
conflict 我可能要週日晚上再弄

@mindihx mindihx requested a review from mattwang44 September 8, 2024 13:14
Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattwang44 mattwang44 merged commit 99fa2cc into python:3.12 Sep 9, 2024
1 check passed
@mindihx mindihx deleted the library/exceptions branch September 11, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants