Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added draft chapter to typing spec for enumerations. #1759

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

erictraut
Copy link
Collaborator

This is the same set of changes as PR #1591. The CI script that enforces CLA signing was confused, so it didn't permit merging the original PR.

This is the same set of changes as PR python#1591. The CI script that enforces CLA signing was confused, so it didn't permit merging the original PR.
@erictraut
Copy link
Collaborator Author

This set of changes was approved by the TC, so merging.

@erictraut erictraut merged commit 459e610 into python:main Jun 3, 2024
5 checks passed
@erictraut erictraut deleted the enum_spec_fresh branch June 3, 2024 05:55
@srittau
Copy link
Collaborator

srittau commented Jun 3, 2024

For future reference: The PR was still mergeable for me (by clicking a big red checkbox to skip branch protection rules).

@erictraut
Copy link
Collaborator Author

OK, good to know. It wasn't mergeable by me, so you must have additional privileges.

carljm added a commit to carljm/typing that referenced this pull request Jun 12, 2024
* main:
  Adds links to Python Discourse and ruff to typing.readthedocs.io (python#1774)
  Conformance tests: Mark pytype as passing annotations_coroutines (python#1771)
  Conformance tests: Fix manual scoring discrepancy for pyre (python#1770)
  Updated conformance test results for pyright 1.1.366. (python#1768)
  Spec: "Distributing type information": add links to PEPs 484 and 561; add a new anchor for easy intersphinx referencing (python#1767)
  Implemented conformance tests for Enums chapter. (python#1764)
  Fixed two bugs in the conformance test: (python#1763)
  Fixed two small typos in Enums chapter that I discovered when writing… (python#1762)
  Typo fix: Replace `TypeVar` with `TypeVarTuple` in a docs example (python#1760)
  Added draft chapter to typing spec for enumerations. (python#1759)
  List pip as an explicit dependency for the conformance tests (python#1757)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants