Conformance tests: Fix manual scoring discrepancy for pyre #1770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pyre infers "Literal[1]" instead of "int", which seems legal. Change the test to get an int from a function parameter instead, so that all type checkers are aligned. Part of python#1692.
erictraut
approved these changes
Jun 7, 2024
carljm
added a commit
to carljm/typing
that referenced
this pull request
Jun 12, 2024
* main: Adds links to Python Discourse and ruff to typing.readthedocs.io (python#1774) Conformance tests: Mark pytype as passing annotations_coroutines (python#1771) Conformance tests: Fix manual scoring discrepancy for pyre (python#1770) Updated conformance test results for pyright 1.1.366. (python#1768) Spec: "Distributing type information": add links to PEPs 484 and 561; add a new anchor for easy intersphinx referencing (python#1767) Implemented conformance tests for Enums chapter. (python#1764) Fixed two bugs in the conformance test: (python#1763) Fixed two small typos in Enums chapter that I discovered when writing… (python#1762) Typo fix: Replace `TypeVar` with `TypeVarTuple` in a docs example (python#1760) Added draft chapter to typing spec for enumerations. (python#1759) List pip as an explicit dependency for the conformance tests (python#1757)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pyre infers "Literal[1]" instead of "int", which seems legal. Change
the test to get an int from a function parameter instead, so that all
type checkers are aligned.
Part of #1692.