Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix: Replace TypeVar with TypeVarTuple in a docs example #1760

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Typo fix: Replace TypeVar with TypeVarTuple in a docs example #1760

merged 1 commit into from
Jun 3, 2024

Conversation

Sachaa-Thanasius
Copy link
Contributor

@Sachaa-Thanasius Sachaa-Thanasius commented Jun 3, 2024

Current text from a subsection within 'TypeVarTuple':

Ts1 = TypeVar('Ts1')
Ts2 = TypeVar('Ts2')

IntTuple = Tuple[int, *Ts1]
IntFloatTuple = IntTuple[float, *Ts2]  # Valid

It's a small thing, but those first two variables should TypeVarTuple instances, I think; the example doesn't really make sense otherwise. Seems to be a typo from the original PEP.

@Sachaa-Thanasius Sachaa-Thanasius marked this pull request as ready for review June 3, 2024 18:28
Copy link
Collaborator

@erictraut erictraut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good catch.

@erictraut erictraut merged commit 0a47e56 into python:main Jun 3, 2024
5 checks passed
@Sachaa-Thanasius Sachaa-Thanasius deleted the fix/typevartuple-type branch June 3, 2024 18:38
carljm added a commit to carljm/typing that referenced this pull request Jun 12, 2024
* main:
  Adds links to Python Discourse and ruff to typing.readthedocs.io (python#1774)
  Conformance tests: Mark pytype as passing annotations_coroutines (python#1771)
  Conformance tests: Fix manual scoring discrepancy for pyre (python#1770)
  Updated conformance test results for pyright 1.1.366. (python#1768)
  Spec: "Distributing type information": add links to PEPs 484 and 561; add a new anchor for easy intersphinx referencing (python#1767)
  Implemented conformance tests for Enums chapter. (python#1764)
  Fixed two bugs in the conformance test: (python#1763)
  Fixed two small typos in Enums chapter that I discovered when writing… (python#1762)
  Typo fix: Replace `TypeVar` with `TypeVarTuple` in a docs example (python#1760)
  Added draft chapter to typing spec for enumerations. (python#1759)
  List pip as an explicit dependency for the conformance tests (python#1757)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants