Fix EEPROM_DRIVER=legacy_stm32_flash #20457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regression was introduced in commit bebfdad
|
This regression was introduced by the 2022 Nov 26 cycle. |
|
I want to remove it but we're still dependent on ChibiOS being fixed -- I've asked a couple of times for a fix to be applied but it hasn't been done. Might re-raise the issue. |
zvecr
approved these changes
May 8, 2023
tzarc
approved these changes
May 15, 2023
shieldsd
pushed a commit
to shieldsd/qmk_firmware
that referenced
this pull request
May 18, 2023
sudish
added a commit
to sudish/qmk_firmware
that referenced
this pull request
May 21, 2023
* upstream/master: (52 commits) `qmk generate-make-dependencies` improvements (qmk#21001) scramble: Add XOSC delay for startup (qmk#20991) [Keyboard] Add Fancytech Fancyalice66 (qmk#20647) Define RGB_DI_PIN directly instead of using another define (qmk#20983) Add Cepstrum Rev. 1 Keyboard (qmk#20721) [Keyboard] Add Moondrop Dash75 (qmk#20890) Revert to last known working version (qmk#20967) Bump anothrNick/github-tag-action from 1.64.0 to 1.65.0 (qmk#20964) Update tg4x RGB LED count (qmk#20955) Fix EEPROM_DRIVER=legacy_stm32_flash (qmk#20457) Generate `make` dependency file during build for info.json's etc. (qmk#20451) hazel/bad_wings update (qmk#20947) jotix keymap update (qmk#20902) Far better VSCode intellisense support using clangd. (qmk#20382) Add new keyboard "Ergomirage" (qmk#20655) [Keyboard] Add Zwag75 keyboard (qmk#20757) [Keyboard] Add kibou/fukuro (qmk#20771) [Keyboard] Add Teleport TKL (qmk#20469) momokai tap_* rgb modes and bootmagic key update (qmk#20126) [Keymap] Add caps word enable to dshields keymaps (qmk#20862) ...
coquizen
pushed a commit
to coquizen/qmk_firmware
that referenced
this pull request
Jun 22, 2023
autoferrit
pushed a commit
to SpaceRockMedia/bastardkb-qmk
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
regression was introduced in commit bebfdad
Types of Changes
Issues Fixed or Closed by This PR
Checklist
- I tested only that it goes from not compiling to compiling.