Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nullbitsco/scramble: Add XOSC delay for startup #20991

Merged
merged 1 commit into from
May 20, 2023

Conversation

jaygreco
Copy link
Contributor

Description

XOSC delay needs to be set on SCRABMLE V2 for proper boot. Tested and working on all of our engineering/production units.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team May 19, 2023 19:10
@drashna drashna added the bug label May 19, 2023
@drashna
Copy link
Member

drashna commented May 19, 2023

I've run into this myself, and can confirm that this works (and is already supported in the version of the pico-sdk we use)

For reference, this is (likely) related to this issue:
raspberrypi/pico-sdk#457

@zvecr zvecr merged commit 449240f into qmk:master May 20, 2023
sudish added a commit to sudish/qmk_firmware that referenced this pull request May 21, 2023
* upstream/master: (52 commits)
  `qmk generate-make-dependencies` improvements (qmk#21001)
  scramble: Add XOSC delay for startup (qmk#20991)
  [Keyboard] Add Fancytech Fancyalice66 (qmk#20647)
  Define RGB_DI_PIN directly instead of using another define (qmk#20983)
  Add Cepstrum Rev. 1 Keyboard (qmk#20721)
  [Keyboard] Add Moondrop Dash75 (qmk#20890)
  Revert to last known working version (qmk#20967)
  Bump anothrNick/github-tag-action from 1.64.0 to 1.65.0 (qmk#20964)
  Update tg4x RGB LED count (qmk#20955)
  Fix EEPROM_DRIVER=legacy_stm32_flash (qmk#20457)
  Generate `make` dependency file during build for info.json's etc. (qmk#20451)
  hazel/bad_wings update  (qmk#20947)
  jotix keymap update (qmk#20902)
  Far better VSCode intellisense support using clangd. (qmk#20382)
  Add new keyboard "Ergomirage" (qmk#20655)
  [Keyboard] Add Zwag75 keyboard (qmk#20757)
  [Keyboard] Add kibou/fukuro (qmk#20771)
  [Keyboard] Add Teleport TKL (qmk#20469)
  momokai tap_* rgb modes and bootmagic key update (qmk#20126)
  [Keymap] Add caps word enable to dshields keymaps (qmk#20862)
  ...
@jaygreco jaygreco deleted the fix_scramble_boot branch May 31, 2023 04:52
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants