Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Be able to configure upgrading of vim Plug plugins to use PlugUpdate! instead of only PlugUpdate #751

Closed
xylix opened this issue Aug 9, 2021 · 2 comments

Comments

@xylix
Copy link

xylix commented Aug 9, 2021

I want to suggest some general feature
For my use cases, PlugUpdate! (https://github.com/junegunn/vim-plug#pluginstall-and-plugupdate), which forces running of post-update hooks for plugins unconditionally, is useful. I would like an option to configure topgrade to use this command when running update with vim-plug.

More information
I would be interested in testing this feature from a side branch, and think I know how. I am also interested in programming it myself if the PR would be accepted.

@r-darwish
Copy link
Owner

The commands are handled here. I'm not much of a vim expert, but can you tell me what to change in order to user PlugUpdate! when some specific environment variable is set? I will set the environment variable in Topgrade's code.

@xylix
Copy link
Author

xylix commented Nov 3, 2021

Sorry for late response, I had missed the response.

Just

if $ENVVAR
    PlugUpdate!
else
    PlugUpdate
endif

should work.

r-darwish added a commit that referenced this issue Dec 9, 2021
* Add an option to force vim plug update (fix #751)

* Rustfmt

* Update src/config.rs

Co-authored-by: M*C*O <mcofficer@gmx.de>

Co-authored-by: M*C*O <mcofficer@gmx.de>
r-darwish added a commit that referenced this issue Dec 9, 2021
* Bedrock Linux (fix #745)

* Add more distributions

* fix

* fix

* Fix

* Merge

* Move pacnew to the correct location

* Version bump

* Correct spelling for GNOME Shell extensions update (#778)

* fix gnome shell extensions update object path (#788)

* config: ArchPackageManager should be snake_case (#784)

* config: ArchPackageManager should be snake_case

* Remove unnecessary strum macro

* Add arch_package_manager to config.example.toml

* Add release pipeline

* Run GNOME update only when using GNOME

* Delete travis file and appveyor

* Bump

* Support rust 1.51.0 (#789)

* Cross compilation

* Bump

* fix: GNOME detection for customized version (#790)

Signed-off-by: Noel Georgi <git@frezbo.dev>

* Add a flag to disable showing Arch Linux news (fix #786)

* Bump

* Update pacstall (fix #769)

* Add an option to force vim plug update (#795)

* Add an option to force vim plug update (fix #751)

* Rustfmt

* Update src/config.rs

Co-authored-by: M*C*O <mcofficer@gmx.de>

Co-authored-by: M*C*O <mcofficer@gmx.de>

* Add new step pacdiff (#796)

* Add Support for Spicetify (#798)

* Look for ~/.config/emacs directory in Windows (fix #766)

* Pass --force to doom when -y is set (fix #799)

* Implement cleanup for flatpak (#801)

* Cleanup flatpak

* Fix compile error

* Make sure we only move our values at the very end

* Access config.cleanup() through ExecutionContext

* Improve man page (#803)

Wordings & argument format

* Avoid running remote topgrade on the current host (fix #804) (#807)

* Merge the command line and the configuration flags of --only and --disable (fix #805) (#806)

* Merge the command line and the configuration flags of --only and --disable (fix #805)

* Fix

* Fix rust requirement in the readme

* Selective yes (fix #802) (#808)

* Selective yes flag (fix #802)

* Selective yes flag (fix #802)

* selective yes

* MacOS

* Fix bedrock detection

* Bedrock fixes

* format

* Fedora fixes

Co-authored-by: Björn Daase <bjoern.daase@gmail.com>
Co-authored-by: modularTaco <37046961+modularTaco@users.noreply.github.com>
Co-authored-by: M*C*O <mcofficer@gmx.de>
Co-authored-by: Noel Georgi <git@frezbo.dev>
Co-authored-by: Manuel Hässig <mhaessig@users.noreply.github.com>
Co-authored-by: Janek <27jf@pm.me>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants