Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

fix: GNOME detection for customized version #790

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

frezbo
Copy link
Contributor

@frezbo frezbo commented Oct 29, 2021

Signed-off-by: Noel Georgi git@frezbo.dev

Standards checklist:

  • The PR title is descriptive.
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself
    • I also tested that Topgrade skips the step where needed

Outputs:

echo $XDG_CURRENT_DESKTOP
pop:GNOME

Testing that gnome get's detected

./target/debug/topgrade --only gnome_shell_extensions

―― 11:05:19 - Gnome Shell extensions ―――――――――――――――――――――――――――――――――――――――――――
()

―― 11:05:19 - Summary ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
Gnome Shell Extensions: OK

Fixes: #779 (comment)

Signed-off-by: Noel Georgi <git@frezbo.dev>
@r-darwish r-darwish merged commit f235c56 into r-darwish:develop Oct 29, 2021
@frezbo frezbo deleted the fix/gnome-detection branch October 29, 2021 06:49
r-darwish pushed a commit that referenced this pull request Dec 9, 2021
Signed-off-by: Noel Georgi <git@frezbo.dev>
r-darwish added a commit that referenced this pull request Dec 9, 2021
* Bedrock Linux (fix #745)

* Add more distributions

* fix

* fix

* Fix

* Merge

* Move pacnew to the correct location

* Version bump

* Correct spelling for GNOME Shell extensions update (#778)

* fix gnome shell extensions update object path (#788)

* config: ArchPackageManager should be snake_case (#784)

* config: ArchPackageManager should be snake_case

* Remove unnecessary strum macro

* Add arch_package_manager to config.example.toml

* Add release pipeline

* Run GNOME update only when using GNOME

* Delete travis file and appveyor

* Bump

* Support rust 1.51.0 (#789)

* Cross compilation

* Bump

* fix: GNOME detection for customized version (#790)

Signed-off-by: Noel Georgi <git@frezbo.dev>

* Add a flag to disable showing Arch Linux news (fix #786)

* Bump

* Update pacstall (fix #769)

* Add an option to force vim plug update (#795)

* Add an option to force vim plug update (fix #751)

* Rustfmt

* Update src/config.rs

Co-authored-by: M*C*O <mcofficer@gmx.de>

Co-authored-by: M*C*O <mcofficer@gmx.de>

* Add new step pacdiff (#796)

* Add Support for Spicetify (#798)

* Look for ~/.config/emacs directory in Windows (fix #766)

* Pass --force to doom when -y is set (fix #799)

* Implement cleanup for flatpak (#801)

* Cleanup flatpak

* Fix compile error

* Make sure we only move our values at the very end

* Access config.cleanup() through ExecutionContext

* Improve man page (#803)

Wordings & argument format

* Avoid running remote topgrade on the current host (fix #804) (#807)

* Merge the command line and the configuration flags of --only and --disable (fix #805) (#806)

* Merge the command line and the configuration flags of --only and --disable (fix #805)

* Fix

* Fix rust requirement in the readme

* Selective yes (fix #802) (#808)

* Selective yes flag (fix #802)

* Selective yes flag (fix #802)

* selective yes

* MacOS

* Fix bedrock detection

* Bedrock fixes

* format

* Fedora fixes

Co-authored-by: Björn Daase <bjoern.daase@gmail.com>
Co-authored-by: modularTaco <37046961+modularTaco@users.noreply.github.com>
Co-authored-by: M*C*O <mcofficer@gmx.de>
Co-authored-by: Noel Georgi <git@frezbo.dev>
Co-authored-by: Manuel Hässig <mhaessig@users.noreply.github.com>
Co-authored-by: Janek <27jf@pm.me>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gnome Shell extensions attempts to update on Plasma and fails
2 participants