Skip to content

Conversation

@IndrajeetPatil
Copy link
Collaborator

Closes #1010

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022

Codecov Report

Merging #1013 (7d54201) into main (405030c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1013   +/-   ##
=======================================
  Coverage   91.20%   91.20%           
=======================================
  Files          46       46           
  Lines        2682     2682           
=======================================
  Hits         2446     2446           
  Misses        236      236           
Impacted Files Coverage Δ
R/environments.R 100.00% <ø> (ø)
R/nest.R 100.00% <ø> (ø)
R/nested-to-tree.R 92.85% <ø> (ø)
R/token-define.R 66.66% <ø> (ø)
R/ui-styling.R 100.00% <ø> (ø)
R/utils-navigate-nest.R 81.48% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@lorenzwalthert

This comment was marked as resolved.

@IndrajeetPatil

This comment was marked as resolved.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@IndrajeetPatil IndrajeetPatil requested a review from krlmlr October 1, 2022 15:11
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2022

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 423830d is merged into main:

  •   :ballot_box_with_check:cache_applying: 27.3ms -> 27.2ms [-0.97%, +0.35%]
  •   :ballot_box_with_check:cache_recording: 746ms -> 744ms [-0.74%, +0.13%]
  •   :ballot_box_with_check:without_cache: 1.86s -> 1.87s [-0.17%, +0.57%]

Further explanation regarding interpretation and methodology can be found in the documentation.

"else", "cond", "ELSE",
"in", "loop_cond", "IN",
"while", "loop_cond", "WHILE"
token <- rbind.data.frame(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option would be as.data.frame(matrix(ncol = 3, byrow = TRUE, c(...)))

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. But I think I will just retain it like this for now.

@IndrajeetPatil IndrajeetPatil merged commit 8105d43 into r-lib:main Oct 1, 2022
@IndrajeetPatil IndrajeetPatil deleted the 1010_tibble_suggests branch October 1, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove rematch2 and tibble dependencies

4 participants