-
Notifications
You must be signed in to change notification settings - Fork 71
Drop {tibble} as a hard dependency
#1013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop {tibble} as a hard dependency
#1013
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1013 +/- ##
=======================================
Coverage 91.20% 91.20%
=======================================
Files 46 46
Lines 2682 2682
=======================================
Hits 2446 2446
Misses 236 236
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 423830d is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
| "else", "cond", "ELSE", | ||
| "in", "loop_cond", "IN", | ||
| "while", "loop_cond", "WHILE" | ||
| token <- rbind.data.frame( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another option would be as.data.frame(matrix(ncol = 3, byrow = TRUE, c(...)))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion. But I think I will just retain it like this for now.
Closes #1010