Skip to content

Conversation

@IndrajeetPatil
Copy link
Collaborator

Closes #954

I created a local website for the package and can confirm that the suggested solution indeed solves the issue.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if b7b1a4e is merged into main:

  •   :ballot_box_with_check:cache_applying: 29ms -> 28.7ms [-3.92%, +1.73%]
  •   :ballot_box_with_check:cache_recording: 1.24s -> 1.24s [-1.15%, +1.3%]
  •   :ballot_box_with_check:without_cache: 3.19s -> 3.19s [-2.83%, +2.43%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert
Copy link
Collaborator

Thank you @IndrajeetPatil, I also added a news billet for that fix here 🥳

@lorenzwalthert lorenzwalthert merged commit 7f85dfe into r-lib:main Jun 16, 2022
@IndrajeetPatil IndrajeetPatil deleted the 954_ansi_escape_hide branch June 16, 2022 14:12
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if d186b13 is merged into main:

  •   :ballot_box_with_check:cache_applying: 24.7ms -> 24.6ms [-2.75%, +2.33%]
  •   :ballot_box_with_check:cache_recording: 1.01s -> 1.01s [-1.28%, +1.6%]
  •   :ballot_box_with_check:without_cache: 2.71s -> 2.71s [-1.02%, +1.46%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ANSI escape codes showing on the website

2 participants