Skip to content

Conversation

@IndrajeetPatil
Copy link
Collaborator

Follow up on #956
Related to #954

This indeed fixes the issue for that chunk:

Screenshot 2022-06-16 at 16 55 54

Follow up on #956
Related to #954
@codecov-commenter
Copy link

Codecov Report

Merging #957 (e339820) into main (7f85dfe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #957   +/-   ##
=======================================
  Coverage   89.88%   89.88%           
=======================================
  Files          47       47           
  Lines        2609     2609           
=======================================
  Hits         2345     2345           
  Misses        264      264           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f85dfe...e339820. Read the comment docs.

@lorenzwalthert
Copy link
Collaborator

Perfect, thanks. Just for the sake of consistency, we'd like to include all PRs in NEWS.md. I'll edit it after merging this time.

@lorenzwalthert lorenzwalthert merged commit 486f2f4 into r-lib:main Jun 16, 2022
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 0db87c5 is merged into main:

  •   :ballot_box_with_check:cache_applying: 29.6ms -> 29.6ms [-0.73%, +0.94%]
  •   :ballot_box_with_check:cache_recording: 1.26s -> 1.26s [-0.3%, +0.39%]
  •   :ballot_box_with_check:without_cache: 3.4s -> 3.42s [-0.19%, +1.13%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants