Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with upstream fork #8

Merged

Conversation

dsaxton-1password
Copy link
Collaborator

Pulls in latest changes from https://github.com/singer-io/tap-google-ads/tree/main which includes an update to API version 15.

dsprayberry and others added 8 commits August 11, 2022 11:00
* Make tap-tester suite use end_date to reduce test run-time

* update integration tets to account for end date usage, add a unittest

* fix typo in tests

* save test logs as artifacts

Co-authored-by: kspeer <kspeer@stitchdata.com>
* v11 and library bump

* Trying another library version for tests

* protobuf version decrease to meet google ads lib reqs
* Bump google-ads client library to the minimum package version that
supports the v12 api

See https://developers.google.com/google-ads/api/docs/client-libs#python
for more details

* Update API_VERSION

* Remove fields

https://developers.google.com/google-ads/api/docs/diff-tool/v12/versus-v11/diffs/common/ad_type_infos

---------

Co-authored-by: Dylan Sprayberry <28106103+dsprayberry@users.noreply.github.com>
* updated api version to V13
* updated changelog
* api version changes

* removed segments.product_bidding_category_level1

* removed segments.product_bidding_category_level2,3,4 and 5

* adding again product_bidding_category_level fields

* product_bidding_category_level... replaced with product_category_level..
@dsaxton-1password dsaxton-1password merged commit 73f0c39 into rae89:main Jan 9, 2024
@dsaxton-1password dsaxton-1password deleted the sync-with-upstream-fork branch January 9, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants