google-ads updated api version to V13 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somethingmorerelevant
requested review from
dsprayberry and
luandy64
and removed request for
dsprayberry
|
Could you fill out the "Risks" section of the PR description? Also, I see the integration tests are failing. Are we sure the tap does not need any changes to be compatible with v13? |
Current failure looks to be a authentication error, i have re-run the tests to verify it wasn't just a one time error. |
bryantgray
approved these changes
Apr 20, 2023
niko-n
added a commit
to Peliqan-io/tap-google-ads
that referenced
this pull request
Sep 18, 2023
google-ads updated api version to V13 (singer-io#82)
rae89
added a commit
to rae89/tap-google-ads
that referenced
this pull request
Sep 28, 2023
* Make tap-tester suite use end_date to reduce test runtime (singer-io#71) * Make tap-tester suite use end_date to reduce test run-time * update integration tets to account for end date usage, add a unittest * fix typo in tests * save test logs as artifacts Co-authored-by: kspeer <kspeer@stitchdata.com> * TDL-21755 v11 and library bump (singer-io#79) * v11 and library bump * Trying another library version for tests * protobuf version decrease to meet google ads lib reqs * Version bump and changelog for PR 79 (singer-io#80) * TDL-21689 and TDL-21756 Bump to v12 (singer-io#76) * Bump google-ads client library to the minimum package version that supports the v12 api See https://developers.google.com/google-ads/api/docs/client-libs#python for more details * Update API_VERSION * Remove fields https://developers.google.com/google-ads/api/docs/diff-tool/v12/versus-v11/diffs/common/ad_type_infos --------- Co-authored-by: Dylan Sprayberry <28106103+dsprayberry@users.noreply.github.com> * Changelog entry and version bump for PR 76 (singer-io#78) * google-ads updated api version to V13 (singer-io#82) * updated api version to V13 * updated changelog --------- Co-authored-by: Dylan <28106103+dsprayberry@users.noreply.github.com> Co-authored-by: kspeer <kspeer@stitchdata.com> Co-authored-by: Andy Lu <andy@stitchdata.com> Co-authored-by: Vishal <vpachpinde@talend.com> Co-authored-by: Robert Espinoza <robert.espinoza@agilebits.com>
dsaxton-1password
added a commit
to rae89/tap-google-ads
that referenced
this pull request
Jan 9, 2024
* Make tap-tester suite use end_date to reduce test runtime (singer-io#71) * Make tap-tester suite use end_date to reduce test run-time * update integration tets to account for end date usage, add a unittest * fix typo in tests * save test logs as artifacts Co-authored-by: kspeer <kspeer@stitchdata.com> * TDL-21755 v11 and library bump (singer-io#79) * v11 and library bump * Trying another library version for tests * protobuf version decrease to meet google ads lib reqs * Version bump and changelog for PR 79 (singer-io#80) * TDL-21689 and TDL-21756 Bump to v12 (singer-io#76) * Bump google-ads client library to the minimum package version that supports the v12 api See https://developers.google.com/google-ads/api/docs/client-libs#python for more details * Update API_VERSION * Remove fields https://developers.google.com/google-ads/api/docs/diff-tool/v12/versus-v11/diffs/common/ad_type_infos --------- Co-authored-by: Dylan Sprayberry <28106103+dsprayberry@users.noreply.github.com> * Changelog entry and version bump for PR 76 (singer-io#78) * google-ads updated api version to V13 (singer-io#82) * updated api version to V13 * updated changelog * api version changes to v15 (singer-io#86) * api version changes * removed segments.product_bidding_category_level1 * removed segments.product_bidding_category_level2,3,4 and 5 * adding again product_bidding_category_level fields * product_bidding_category_level... replaced with product_category_level.. --------- Co-authored-by: Dylan <28106103+dsprayberry@users.noreply.github.com> Co-authored-by: kspeer <kspeer@stitchdata.com> Co-authored-by: Andy Lu <andy@stitchdata.com> Co-authored-by: Vishal <vpachpinde@talend.com> Co-authored-by: rdeshmukh15 <107538720+rdeshmukh15@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
QA steps
Risks
The schemas of the core streams are controlled by the sdk library, however the generated catalogs do not show any changes to schema definitions
Rollback steps