Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tap-tester suite use end_date to reduce test runtime #71

Merged
merged 4 commits into from
Aug 11, 2022
Merged

Make tap-tester suite use end_date to reduce test runtime #71

merged 4 commits into from
Aug 11, 2022

Conversation

dsprayberry
Copy link
Contributor

Description of change

Add end_date to base.py so that incremental streams under test stop requests at 04/01/22 to reduce runtime.

QA steps

  • automated tests passing
  • manual qa steps passing
  • ran test suite locally

Risks

Rollback steps

  • revert this branch

luandy64
luandy64 requested changes Aug 10, 2022
View reviewed changes
tests/test_google_ads_bookmarks.py Outdated
@@ -32,7 +32,7 @@ def assertIsDateFormat(self, value, str_format):
def test_run(self):
"""
Testing that the tap sets and uses bookmarks correctly where
state < (today - converstion window), therefore the state should be used
state < (end_date - converstion window), therefore the state should be used
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un typo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed.

@kspeer825 kspeer825 requested a review from luandy64 August 11, 2022 13:07
@kspeer825 kspeer825 merged commit 2038950 into main Aug 11, 2022
@kspeer825 kspeer825 deleted the add-end-date-to-tap-tester branch August 11, 2022 15:00
@kspeer825 kspeer825 added the testing QA work. No src code changes. label Aug 11, 2022
rae89 added a commit to rae89/tap-google-ads that referenced this pull request Mar 3, 2023
@rae89 @dsprayberry @luandy64
2023-03-2 sync fork (#2)
d98c0b2 
* Make tap-tester suite use end_date to reduce test runtime (singer-io#71)

* Make tap-tester suite use end_date to reduce test run-time

* update integration tets to account for end date usage, add a unittest

* fix typo in tests

* save test logs as artifacts

Co-authored-by: kspeer <kspeer@stitchdata.com>

* TDL-21755 v11 and library bump (singer-io#79)

* v11 and library bump

* Trying another library version for tests

* protobuf version decrease to meet google ads lib reqs

* Version bump and changelog for PR 79 (singer-io#80)

* TDL-21689 and TDL-21756 Bump to v12 (singer-io#76)

* Bump google-ads client library to the minimum package version that
supports the v12 api

See https://developers.google.com/google-ads/api/docs/client-libs#python
for more details

* Update API_VERSION

* Remove fields

https://developers.google.com/google-ads/api/docs/diff-tool/v12/versus-v11/diffs/common/ad_type_infos

---------

Co-authored-by: Dylan Sprayberry <28106103+dsprayberry@users.noreply.github.com>

* Changelog entry and version bump for PR 76 (singer-io#78)

* Robert/add properties (#1)

---------

Co-authored-by: Dylan <28106103+dsprayberry@users.noreply.github.com>
Co-authored-by: kspeer <kspeer@stitchdata.com>
Co-authored-by: Andy Lu <andy@stitchdata.com>
rae89 added a commit to rae89/tap-google-ads that referenced this pull request Sep 28, 2023
@rae89 @dsprayberry @luandy64
2023-03-2 sync fork (#2)
e9085de 
* Make tap-tester suite use end_date to reduce test runtime (singer-io#71)

* Make tap-tester suite use end_date to reduce test run-time

* update integration tets to account for end date usage, add a unittest

* fix typo in tests

* save test logs as artifacts

Co-authored-by: kspeer <kspeer@stitchdata.com>

* TDL-21755 v11 and library bump (singer-io#79)

* v11 and library bump

* Trying another library version for tests

* protobuf version decrease to meet google ads lib reqs

* Version bump and changelog for PR 79 (singer-io#80)

* TDL-21689 and TDL-21756 Bump to v12 (singer-io#76)

* Bump google-ads client library to the minimum package version that
supports the v12 api

See https://developers.google.com/google-ads/api/docs/client-libs#python
for more details

* Update API_VERSION

* Remove fields

https://developers.google.com/google-ads/api/docs/diff-tool/v12/versus-v11/diffs/common/ad_type_infos

---------

Co-authored-by: Dylan Sprayberry <28106103+dsprayberry@users.noreply.github.com>

* Changelog entry and version bump for PR 76 (singer-io#78)

* Robert/add properties (#1)

---------

Co-authored-by: Dylan <28106103+dsprayberry@users.noreply.github.com>
Co-authored-by: kspeer <kspeer@stitchdata.com>
Co-authored-by: Andy Lu <andy@stitchdata.com>
rae89 added a commit to rae89/tap-google-ads that referenced this pull request Sep 28, 2023
@rae89 @dsprayberry @luandy64
2023-03-2 sync fork (#2)
950e47d 
* Make tap-tester suite use end_date to reduce test runtime (singer-io#71)

* Make tap-tester suite use end_date to reduce test run-time

* update integration tets to account for end date usage, add a unittest

* fix typo in tests

* save test logs as artifacts

Co-authored-by: kspeer <kspeer@stitchdata.com>

* TDL-21755 v11 and library bump (singer-io#79)

* v11 and library bump

* Trying another library version for tests

* protobuf version decrease to meet google ads lib reqs

* Version bump and changelog for PR 79 (singer-io#80)

* TDL-21689 and TDL-21756 Bump to v12 (singer-io#76)

* Bump google-ads client library to the minimum package version that
supports the v12 api

See https://developers.google.com/google-ads/api/docs/client-libs#python
for more details

* Update API_VERSION

* Remove fields

https://developers.google.com/google-ads/api/docs/diff-tool/v12/versus-v11/diffs/common/ad_type_infos

---------

Co-authored-by: Dylan Sprayberry <28106103+dsprayberry@users.noreply.github.com>

* Changelog entry and version bump for PR 76 (singer-io#78)

* Robert/add properties (#1)

---------

Co-authored-by: Dylan <28106103+dsprayberry@users.noreply.github.com>
Co-authored-by: kspeer <kspeer@stitchdata.com>
Co-authored-by: Andy Lu <andy@stitchdata.com>
rae89 added a commit to rae89/tap-google-ads that referenced this pull request Sep 28, 2023
@rae89 @dsprayberry @luandy64
2023-03-2 sync fork (#2)
5668043 
* Make tap-tester suite use end_date to reduce test runtime (singer-io#71)

* Make tap-tester suite use end_date to reduce test run-time

* update integration tets to account for end date usage, add a unittest

* fix typo in tests

* save test logs as artifacts

Co-authored-by: kspeer <kspeer@stitchdata.com>

* TDL-21755 v11 and library bump (singer-io#79)

* v11 and library bump

* Trying another library version for tests

* protobuf version decrease to meet google ads lib reqs

* Version bump and changelog for PR 79 (singer-io#80)

* TDL-21689 and TDL-21756 Bump to v12 (singer-io#76)

* Bump google-ads client library to the minimum package version that
supports the v12 api

See https://developers.google.com/google-ads/api/docs/client-libs#python
for more details

* Update API_VERSION

* Remove fields

https://developers.google.com/google-ads/api/docs/diff-tool/v12/versus-v11/diffs/common/ad_type_infos

---------

Co-authored-by: Dylan Sprayberry <28106103+dsprayberry@users.noreply.github.com>

* Changelog entry and version bump for PR 76 (singer-io#78)

* Robert/add properties (#1)

---------

Co-authored-by: Dylan <28106103+dsprayberry@users.noreply.github.com>
Co-authored-by: kspeer <kspeer@stitchdata.com>
Co-authored-by: Andy Lu <andy@stitchdata.com>
rae89 added a commit to rae89/tap-google-ads that referenced this pull request Sep 28, 2023
@rae89 @dsprayberry
@luandy64 @somethingmorerelevant
Robert/20230928/sync fork (#4)
7e6cc89 
* Make tap-tester suite use end_date to reduce test runtime (singer-io#71)

* Make tap-tester suite use end_date to reduce test run-time

* update integration tets to account for end date usage, add a unittest

* fix typo in tests

* save test logs as artifacts

Co-authored-by: kspeer <kspeer@stitchdata.com>

* TDL-21755 v11 and library bump (singer-io#79)

* v11 and library bump

* Trying another library version for tests

* protobuf version decrease to meet google ads lib reqs

* Version bump and changelog for PR 79 (singer-io#80)

* TDL-21689 and TDL-21756 Bump to v12 (singer-io#76)

* Bump google-ads client library to the minimum package version that
supports the v12 api

See https://developers.google.com/google-ads/api/docs/client-libs#python
for more details

* Update API_VERSION

* Remove fields

https://developers.google.com/google-ads/api/docs/diff-tool/v12/versus-v11/diffs/common/ad_type_infos

---------

Co-authored-by: Dylan Sprayberry <28106103+dsprayberry@users.noreply.github.com>

* Changelog entry and version bump for PR 76 (singer-io#78)

* google-ads updated api version to V13 (singer-io#82)

* updated api version to V13
* updated changelog

---------

Co-authored-by: Dylan <28106103+dsprayberry@users.noreply.github.com>
Co-authored-by: kspeer <kspeer@stitchdata.com>
Co-authored-by: Andy Lu <andy@stitchdata.com>
Co-authored-by: Vishal <vpachpinde@talend.com>
Co-authored-by: Robert Espinoza <robert.espinoza@agilebits.com>
dsaxton-1password added a commit to rae89/tap-google-ads that referenced this pull request Jan 9, 2024
@dsaxton-1password @dsprayberry
@luandy64 @somethingmorerelevant @rdeshmukh15
Sync with upstream fork (#8)
73f0c39 
* Make tap-tester suite use end_date to reduce test runtime (singer-io#71)

* Make tap-tester suite use end_date to reduce test run-time

* update integration tets to account for end date usage, add a unittest

* fix typo in tests

* save test logs as artifacts

Co-authored-by: kspeer <kspeer@stitchdata.com>

* TDL-21755 v11 and library bump (singer-io#79)

* v11 and library bump

* Trying another library version for tests

* protobuf version decrease to meet google ads lib reqs

* Version bump and changelog for PR 79 (singer-io#80)

* TDL-21689 and TDL-21756 Bump to v12 (singer-io#76)

* Bump google-ads client library to the minimum package version that
supports the v12 api

See https://developers.google.com/google-ads/api/docs/client-libs#python
for more details

* Update API_VERSION

* Remove fields

https://developers.google.com/google-ads/api/docs/diff-tool/v12/versus-v11/diffs/common/ad_type_infos

---------

Co-authored-by: Dylan Sprayberry <28106103+dsprayberry@users.noreply.github.com>

* Changelog entry and version bump for PR 76 (singer-io#78)

* google-ads updated api version to V13 (singer-io#82)

* updated api version to V13
* updated changelog

* api version changes to v15 (singer-io#86)

* api version changes

* removed segments.product_bidding_category_level1

* removed segments.product_bidding_category_level2,3,4 and 5

* adding again product_bidding_category_level fields

* product_bidding_category_level... replaced with product_category_level..

---------

Co-authored-by: Dylan <28106103+dsprayberry@users.noreply.github.com>
Co-authored-by: kspeer <kspeer@stitchdata.com>
Co-authored-by: Andy Lu <andy@stitchdata.com>
Co-authored-by: Vishal <vpachpinde@talend.com>
Co-authored-by: rdeshmukh15 <107538720+rdeshmukh15@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kspeer825 kspeer825 kspeer825 left review comments

@luandy64 luandy64 luandy64 approved these changes

Assignees
No one assigned
Labels
testing QA work. No src code changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsprayberry @luandy64 @kspeer825