-
Notifications
You must be signed in to change notification settings - Fork 49
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix tests broken by rapids-logger changes (#775)
#765 required an admin merge on this repository to break a circular dependency between this repository and rmm because rapids-cmake provides a centralized `rapids_cpm_rmm` function. Unfortunately, because of how certain tests in this repo were set up, they could not be tested against a fork (like #765 did) without manually copying over branches to the fork, so that was not done. Now that the rmm PR is merged, we can see that there are a few issues to be ironed out with the tests here. In particular, since rmm no longer clones fmt, the pin testing needs to be updated to not look for it. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Bradley Dice (https://github.com/bdice) URL: #775
- Loading branch information
Showing
3 changed files
with
7 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters