Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests broken by rapids-logger changes #775

Merged
merged 7 commits into from
Feb 11, 2025

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Feb 10, 2025

Description

#765 required an admin merge on this repository to break a circular dependency between this repository and rmm because rapids-cmake provides a centralized rapids_cpm_rmm function. Unfortunately, because of how certain tests in this repo were set up, they could not be tested against a fork (like #765 did) without manually copying over branches to the fork, so that was not done. Now that the rmm PR is merged, we can see that there are a few issues to be ironed out with the tests here. In particular, since rmm no longer clones fmt, the pin testing needs to be updated to not look for it.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@vyasr vyasr changed the title Test CI Fix tests broken by #765 Feb 11, 2025
@vyasr vyasr changed the title Fix tests broken by #765 Fix tests broken by rapids-logger changes Feb 11, 2025
@vyasr vyasr self-assigned this Feb 11, 2025
@vyasr vyasr added bug Something isn't working non-breaking Introduces a non-breaking change labels Feb 11, 2025
@vyasr vyasr marked this pull request as ready for review February 11, 2025 01:40
@vyasr vyasr requested a review from a team as a code owner February 11, 2025 01:40
@vyasr
Copy link
Contributor Author

vyasr commented Feb 11, 2025

/merge

@rapids-bot rapids-bot bot merged commit 9220596 into rapidsai:branch-25.04 Feb 11, 2025
17 checks passed
@vyasr vyasr deleted the test_latest branch February 11, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants