Switch to using rapids-logger as a library #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
breaking
vyasr
force-pushed
the
feat/rapids_logger_library
branch
from
3b2c8a3 to
076af41
Compare
|
I'm expecting tests to fail for the moment. I'll update those once I have RAPIDS builds working with this change. |
vyasr
commented
Feb 4, 2025
vyasr
commented
Feb 4, 2025
bdice
approved these changes
Feb 10, 2025
|
The remaining failures here are because there are tests that pull rmm and there is a catch-22 with this PR and rapidsai/rmm#1808. I'll request an admin merge here so that I can rerun and get CI passing on the rmm PR to merge that one. |
7 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
#765 required an admin merge on this repository to break a circular dependency between this repository and rmm because rapids-cmake provides a centralized `rapids_cpm_rmm` function. Unfortunately, because of how certain tests in this repo were set up, they could not be tested against a fork (like #765 did) without manually copying over branches to the fork, so that was not done. Now that the rmm PR is merged, we can see that there are a few issues to be ironed out with the tests here. In particular, since rmm no longer clones fmt, the pin testing needs to be updated to not look for it. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Bradley Dice (https://github.com/bdice) URL: #775
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes
rapids_cpm_rapids_loggerto use the new shared library version ofrapids_loggerinstead of the old C++ file generation approach. In addition to changing the versions.json file, there are a couple of associated changes to the function and also some small cleanup.Contributes to rapidsai/build-planning#104.
Checklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))