Fix for Pisound kernel module in Real Time kernel configuration. #2873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When handler of data_available interrupt is fired, queue_work ends up getting called and it can block on a spin lock which is not allowed in interrupt context. The fix was to run the handler from a thread context instead.
|
Thank you! Here's the pull request for RT branch: #2874 |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Mar 8, 2019
kernel: lan78xx: EEE support is now a PHY property See: raspberrypi/linux#2882 kernel: config: Add CONFIG_FB_TFT_SH1106=m See: raspberrypi/linux#2876 kernel: Fix for Pisound kernel module in Real Time kernel configuration See: raspberrypi/linux#2873 kernel: allo-katana: Added mute stream func See: raspberrypi/linux#2577 firmware: raspivid: Stop --raw option resetting --raw-format to YUV See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=189830&start=25#p1432589 firmware: Fixed up overflow in microsecond timer See: raspberrypi/userland#535
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Mar 8, 2019
kernel: lan78xx: EEE support is now a PHY property See: raspberrypi/linux#2882 kernel: config: Add CONFIG_FB_TFT_SH1106=m See: raspberrypi/linux#2876 kernel: Fix for Pisound kernel module in Real Time kernel configuration See: raspberrypi/linux#2873 kernel: allo-katana: Added mute stream func See: raspberrypi/linux#2577 firmware: raspivid: Stop --raw option resetting --raw-format to YUV See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=189830&start=25#p1432589 firmware: Fixed up overflow in microsecond timer See: raspberrypi/userland#535
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handler of data_available interrupt is fired, queue_work ends up getting called and it can block on a spin lock which is not allowed in interrupt context. The fix was to run the handler from a thread context instead.
Exactly the same fix should be applied to rpi-4.14.y-rt.