Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed up overflow in microsecond timer #535

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Fixed up overflow in microsecond timer #535

merged 1 commit into from
Mar 4, 2019

Conversation

JamesH65
Copy link
Collaborator

@JamesH65 JamesH65 commented Mar 4, 2019

Was using a 32 bit calculation when should have been 64bit.

Fixed up overflow in microsecond timer
5962783 
Was using a 32 bit calculation when should have been 64bit.
@JamesH65 JamesH65 requested a review from 6by9 March 4, 2019 11:52
@JamesH65
Copy link
Collaborator Author

JamesH65 commented Mar 4, 2019

Note: deliberately left some not quite right mismatches in types (assigning uint to int etc), they will be fixed in a future PR. This just fixes the issue in hand, of timelapse mode dying after an hour or so due to a 32 bit overflow.

@pelwell pelwell merged commit aa79238 into raspberrypi:master Mar 4, 2019
@JamesH65 JamesH65 mentioned this pull request Mar 4, 2019
Open
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Mar 8, 2019
@popcornmix
kernel: Bump to 4.19.27
fd15e07 
kernel: lan78xx: EEE support is now a PHY property
See: raspberrypi/linux#2882

kernel: config: Add CONFIG_FB_TFT_SH1106=m
See: raspberrypi/linux#2876

kernel: Fix for Pisound kernel module in Real Time kernel configuration
See: raspberrypi/linux#2873

kernel: allo-katana: Added mute stream func
See: raspberrypi/linux#2577

firmware: raspivid: Stop --raw option resetting --raw-format to YUV
See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=189830&start=25#p1432589

firmware: Fixed up overflow in microsecond timer
See: raspberrypi/userland#535
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request Mar 8, 2019
@popcornmix
kernel: Bump to 4.19.27
29952e8 
kernel: lan78xx: EEE support is now a PHY property
See: raspberrypi/linux#2882

kernel: config: Add CONFIG_FB_TFT_SH1106=m
See: raspberrypi/linux#2876

kernel: Fix for Pisound kernel module in Real Time kernel configuration
See: raspberrypi/linux#2873

kernel: allo-katana: Added mute stream func
See: raspberrypi/linux#2577

firmware: raspivid: Stop --raw option resetting --raw-format to YUV
See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=189830&start=25#p1432589

firmware: Fixed up overflow in microsecond timer
See: raspberrypi/userland#535
@6by9 6by9 mentioned this pull request Mar 25, 2019
Open
mkreisl added a commit to xbianonpi/xbian-package-firmware that referenced this pull request Oct 6, 2019
@mkreisl
verup and ...
9606587 
- firmware: camera/image_encode: Add timestamp to frames encoded with image_encode
  See: raspberrypi/linux#2351

- firmware: camera_subsystem: Clean up disable_camera_led handling

- firmware: smservice: Add defines for VPU allocations
- smservice: Add support for reporting the supported version to the host

- firmware: Camplus: cdi: Remove requirement for calibration functions

- firmware: isp: Reinstate lres shift parameter accidentally dropped with gamma changes
  See: #1108

- firmware: mmal_ril: List all 4 Bayer orders if the IL component says it supports Bayer

- firmware: raspivid: Stop --raw option resetting --raw-format to YUV
  See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=189830&start=25#p1432589

- firmware: Fixed up overflow in microsecond timer
  See: raspberrypi/userland#535

- firmware: smservice: Avoid a double free

- firmware: arm_loader/display: All the framebuffer allocation to be made on the ARM

- firmware: isp_tuners: Fix memory leak in error path

- firmware: testc: Fix dps parsing

- firmware: camera_subsystem: Fix hardware sync pulses off disable_camera_led

- firmware: Replace the remaining direct users of C(mask_gpu_interrupt[0|1])

- firmware: arm_display: Kick transposer for the rainbow screen if required
- firmware: dispmanx: Do not allow transpose if using Full KMS
  See: raspberrypi/linux#2891

- firmware: Revert: arm_loader/display: All the framebuffer allocation to be made on the ARM

- firmware: arm_loader: Further conditionals for passing in a frame buffer

- firmware: di_adv: Drop back to fast if QPUs are masked off

- firmware: Fix AWB exception bug

- firmware: Updates for Pi4

- firmware: Add missing licence file

- firmware: 2711: CORE, EMMC & BVB clock updates for WiFi / 4Kp60
- firmware: 711: Use boost instead of fixed freq for 4Kp60

- firmware: hvs: Emulate the EOLn interrupt with a timer reset from VSTART
  See: #1154

- firmware: Add support for Rec2020 colour space in vc_image, IL, and MMAL

- firmware: Fix composite mode on devices up to Pi3B+
  See: #1166

- firmware: Fixes for core_freq_min causing failure on HDMI1
  See: http://git/vc4/vc4/merge_requests/529

- firmware: hdmi: Don't release previous boost until mode set is complete
  See: #1159

- firmware: bcm_host: Adjust for 64-bit physical addresses
  See: #1161

- firmware: arm_loader: Shrink most stubs back to 256 bytes, add arm64 GIC stub
  See: raspberrypi/linux#3032

- firmware: arm_dispmanx: Add support for setting the colour encoding

- firmware: dmalib: Fix Lite channel interrupt usage, and macro name

- firmware: Force overscan off when using LCDs
  See: #1173

- firmware: cec: Fix crash when using CEC with HDMI1

- firmware: arm_display: Fix race condition initialising CEC

- firmware: hdmi: Always use boost frequency for initial mode set
  See: #1159

- firmware: AWB: Fix usage for IR operation
  See: #1167

- firmware: arm_loader: Support CLOCK_EMMC2 from GET_CLOCK_RATE
  See: #1179

- firmware: arm_loader: Force word alignment for the DTB
  See: #1175

- firmware: clock_2711: don't set reserved values for KA in PLL KAIP registers

- firmware: Assorted minor fixes for tvservice -o

- firmware: Rename hdmi_enable_4k to hdmi_enable_4kp60

- firmware: Revert: clock_2711: don't set reserved values for KA in PLL KAIP registers

- firmware: dispmanx: Fix handling of disable_overscan to not disable it totally
  See: raspberrypi/linux#3059

- firmware: power: Enable/disable H264 and ISP clocks with domain

- firmware: arm_loader: arm_64bit=0 should disable loading of kernel8.img

- firmware: dt-blob: CM has no activity LED

- firmware: AWB updates
  See: #1167

-firmware: Change order of display remapping for default display number

- firmware: AWB: Set default number of stats regions for RPi AWB
  See: #1198

- firmware: Fix composite interrupt HVS channel

- firmware: scalarlib: Fix width setting for SCALERLIB_PIXEL_FORMAT_YUV10COL

- firmware: vcmailbox: Add a new SET_AUDIO_LDO_STATE mailbox command

- firmware: Add mailbox call to report the HDMI timings

- firmware: H264: Set the decoder cache AXI burst length to the same as the encoder

- firmware: gencmd: Fix gencmd max result length
- firmware: bootloader_config: New gencmd to read the EEPROM config

- firmware: pwm_audio: Use PWM1 on BCM2838 unless remapped
  See: #1178

- firmware: Fixups for missing code changes from Pi4 branch
  See: #1201

- firmware: pwm_audio: Use the correct DREQs on Pi4
  See: #1214

- firmware: pixelvalve_2711: Alter back porch for widths of 1366
  See: #1202

- firmware: Clear the SMIDSW1 display interrupt flag on startup

- firmware: dt-blob: Declare Pi 4B's SD_IO voltage selector

- firmware: Fix to allow HDMI audio port route setting
  See: raspberrypi/linux#3100

- firmware: AWB: Allow user to set manual gains for the RPi algorithm

- firmware: arm_loader: Fix disabling of audio before reboot

- firmware: fixed up the custom CVT values to use correct group

- firmware: hdmi: Add independent table entries for hdmi_timings on each display
  See: #1218

- firmware: arm_loader: Fix initial_turbo getting stuck
  See: #1005

- firmware: clock_2711: don't set reserved values for KA in PLL KAIP registers

- firmware: arm_loader: Use platform_get_min_core_voltage for actual min voltage

- firmware: clock: Remember disable state across clock changes

- firmware: platform: pi4: Reduce min core voltage to 810mV

- firmware: arm_dt: Use boost to force turbo mode rather than modifying core_freq_min for uart

- firmware: arm_loader: Add optional flag to add_boost and get_boost calls

- firmware: avs_2711: Move margin from init structure to run time

- firmware: platform: fix get_min_default

- firmware: arm_loader: Use AP_CLOCK_T for clock_iterator for easier debugging

- firmware: AWB: Fix for manual WB settings in capture
  See: #1215

- firmware: sdhost_arasan: Disable busy wait on EMMC_STATUS_NEW_CARD_DATA_SET

- firmware: power: Add 2711-specific PMIC compensation values

- firmware: platform: Remove 10mV of margin

- firmware: Revamp file loading logic

- firmware: power: Allow reading uncached voltage

- firmware: arm_loader: Request KMS to use CVT timings

- firmware: vc_image: Default YUVUV to non-tall mode, with flag if required

- firmware: ldconfig: Implement [pi2/pi3/pi3+] using board types
  See: #1242

- firmware: Avoid defaulting to 64-bit kernel on older Pi

- firmware: Port file loading revamp to master

- firmware: platform: Set up emmc clock earlier

- firmware: hdmi: Implement platform_display_power on 2711
  See: #1224

- firmware: arm_loader: Pass overscan settings to the kernel

- firmware: arm_loader: Add option disable_fw_kms_setup to stop FKMS setup by FW

- firmware: hdmi: Use pixel clock multiplier to determine the core clock

- firmware: Fixups for composite output mode
  See: #1223

- firmware: platform: Allow display_power to be queried from gencmd
  See: #1224

- firmware: arm_loader: Fix no-DT and upstream handling
  See: #1250

- firmware: Round up HDMI0 minimum core clock

- firmware: board_info: Support bcm2710- and bcm2837- Pi 2 DTBs
  See: raspberrypi/linux#3234

- firmware: power: bcm2711: Rescale the GPIO pad power

- firmware: brfs: Add GENET driver for 2711

- firmware: bootloader_state: Add network state and bootmode configuration

- firmware: bootloader_state: Fix mask for EEPROM header magic

- firmware: arm_loader: Fix initial_turbo getting stuck
  See: #1005

- firmware: ldconfig: Support [edid=*] to mean any HDMI monitor
  See: #1136

- firmware: image_fx: Remove restriction that output stride must match input stride

- firmware: image_fx: Remove spamming log line

- firmware: platform: Switch to divide by one when arm_freq exceeds 2GHz

- firmware: Add EMMC support to 2711 Arasan EMMC driver

- firmware: arm_loader: Use /memory@0 if found
  See: raspberrypi/linux#3244

- firmware: bootloader_state: Fix length for bootloader_config

- firmware: arasan_emmc: Fix STB_GPIOOVERRIDE for MMC1 in network boot

- firmware: bfs: Verify that eth FS has not been closed before using
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@6by9 6by9 6by9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamesH65 @6by9 @pelwell