Update Aspect.php

[denise-kao]

Fix instance type error when using AnnotatedWithMatcher

In AnnotatedWithMatcher.php, matchesMethod assert $method is \Ray\Aop\ReflectionMethod

But in Aspect.php, using ReflectionMethod as a parameter causes AnnotatedWithMatcher is always not working.

Summary by CodeRabbit

• Bug Fixes

  • Updated the context of the ReflectionClass used in the application to ensure the correct implementation is referenced, enhancing stability and performance.

• Refactor

  • Clarified the source of the ReflectionClass for better maintainability without altering the existing functionality of the method.

[coderabbitai]

Walkthrough

The change involves modifying the createBind method in the src/Aspect.php file to utilize the ReflectionClass from the Ray\Aop namespace instead of the global ReflectionClass. This adjustment clarifies the source of the ReflectionClass, ensuring the correct implementation is referenced without altering the method's functionality.

Changes

File	Change Summary
src/Aspect.php	Updated createBind method to use ReflectionClass from the Ray\Aop namespace instead of the global ReflectionClass.

Poem

In the meadow where bunnies hop,
A change was made, oh what a swap!
Reflection now from AOP's light,
Guides our code to shine so bright.
With every leap, we celebrate,
A clearer path, oh isn’t it great! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

Early access features: disabled

We are currently testing the following features in early access:

• Anthropic claude-3-5-sonnet for code reviews: Anthropic claims that the new Claude model has stronger code understanding and code generation capabilities than their previous models. Note: Our default code review model was also updated late last week. Please compare the quality of the reviews between the two models by toggling the early access feature.

Note:

• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
• Please join our Discord Community to provide feedback and report issues on the discussion post.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.20%. Comparing base (d1b79b7) to head (3af54e5).
Report is 46 commits behind head on 2.x.

Additional details and impacted files

@@              Coverage Diff              @@
##                 2.x     #218      +/-   ##
=============================================
- Coverage     100.00%   91.20%   -8.80%     
- Complexity       196      230      +34     
=============================================
  Files             26       27       +1     
  Lines            512      591      +79     
=============================================
+ Hits             512      539      +27     
- Misses             0       52      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1b2d410 and 3af54e5.

Files selected for processing (1)

• src/Aspect.php (1 hunks)

Additional comments not posted (1)

src/Aspect.php (1)

201-201: LGTM!

The change to use \Ray\Aop\ReflectionClass instead of the global ReflectionClass is approved. It clarifies the source of the ReflectionClass, ensuring the correct implementation is referenced, which is consistent with the PR objective of addressing the instance type error encountered when utilizing the AnnotatedWithMatcher.

[koriym]

@denise-kao Thanks. It was an easy mistake that should not have happened!

[koriym]

Released as v2.16.2
https://github.com/ray-di/Ray.Aop/releases/tag/2.16.2