Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full featured Raindrop.io extension (new extension suggestion) #2203

Closed
aiotter opened this issue Jul 7, 2022 · 11 comments
Closed

Full featured Raindrop.io extension (new extension suggestion) #2203

aiotter opened this issue Jul 7, 2022 · 11 comments
Labels
extension Issues related to one of the extensions in the Store feature request New feature or improvement wontfix This will not be worked on

Comments

@aiotter
Copy link
Contributor

aiotter commented Jul 7, 2022

Extension – Raindrop.io

Author: @lardissone

Describe the feature and the current behavior/state.
I want to add these new features:

  • Use OAuth2 instead of the current Bearer token.
  • Show detailed bookmark preview instead of only the title and the favicon.
  • Add an access to the permanent copy of the bookmarked page (premium feature of raindrop.io)

Who will benefit from this feature?
Raindrop.io users

Any Other info.
The biggest problem is the huge number of changes. And the change in authentication method can break the other people's workflows. So I'm planning to create a new extension.

The fundamental objective of the extension is the same as the current extension. Will the new extension get accepted? How should I name it?

@aiotter aiotter added extension Issues related to one of the extensions in the Store feature request New feature or improvement labels Jul 7, 2022
@mathieudutour
Copy link
Member

And the change in authentication method can break the other people's workflows. So I'm planning to create a new extension.

Not necessarily. For the Notion extension we support both: if the token is set (eg. old users), use that - otherwise use oauth

@lardissone
Copy link
Contributor

Interesting suggestions!

I will work on OAuth support (didn't noticed Raycast added support for it).
And then I can work on detail view.

@lardissone
Copy link
Contributor

@aiotter @mathieudutour I just noticed that Raindrop API only supports authentication using client_secret. Not sure if there's a way already in Raycast to do requests to non-PKCE APIs or if there's another way to implement it.

@mathieudutour
Copy link
Member

You can use a PKCE proxy: https://github.com/mathieudutour/pkce-proxy

@lardissone
Copy link
Contributor

@mathieudutour yes, but I think this should be hosted by Raycast.

I mean, I wouldn't use an extension that uses a proxy hosted by the extension creator. Your proxy looks great, but anyone can attach a logger or whatever to steal credentials. WDYT?

@mathieudutour
Copy link
Member

yep you're right.

If you want, you can fork the proxy, make the changes required to make it work for Raindrop, and then I can deploy it on a raycast server - I can give you the client id aftwerward

@aiotter
Copy link
Contributor Author

aiotter commented Jul 8, 2022

Wait, I didn't mean I want all those features to be implemented by @lardissone alone. If you're ready to check PR, I can add an detailed preview for my first step. Or do you already have a good idea about implementing it?

@lardissone
Copy link
Contributor

@mathieudutour that would be great! I've been asking Raindrop support if they plans to add PKCE support anytime soon.

@aiotter I had been working on upgrade to Detail view, still requires some tuning but this is what I have:

2022-07-08T12.07.10-converted.mp4

@aiotter
Copy link
Contributor Author

aiotter commented Jul 9, 2022

Okay, I opened this issue for a purpose of my contribution, but if you want to do all the things by yourself keep going. I'll keep this issue open.
I've already done some of my implementation at the time when I created this issue, and got some extra progress after that. I wish I had known that you wanted to implement by yourself beforehand.

Please ask maintainers to close this issue when you don't need it anymore.

@lardissone
Copy link
Contributor

@aiotter Sure. Feel free to contribute! I just had something already made on my computer but not yet released/finished and wanted to show you the status.
Let me know if you like this way I can push this to my fork so you can review it before releasing it here.

@stale
Copy link

stale bot commented Aug 31, 2022

This issue/pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs in the next 7 days to keep our backlog clean. Thanks for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 31, 2022
@stale stale bot closed this as completed Sep 11, 2022
colebemis added a commit to colebemis/raycast-extensions that referenced this issue Apr 29, 2024
- Update raycast images
- Update raycast copy
- Merge branch \'contributions/merge-1714401066006496000\'
- Merge pull request raycast#2323 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- Add uncaughtException handler (raycast#2321)
- Don\'t throw an error if stitching doesn\'t see \`[DONE]\` (raycast#2320)
- Merge pull request raycast#2317 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- telemetry: record disk space avail/used at \`/\` (raycast#2313)
- Merge pull request raycast#2315 from githubnext/dsyme/bsl22
- update baselines
- Merge pull request raycast#2311 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- Merge pull request raycast#2312 from githubnext/fix-terminal-error
- Fix terminal error on narrow viewports
- Out of disk space: improve remove code (raycast#2305)
- Merge pull request raycast#2307 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- Make useLongerSpecs experiment private (raycast#2306)
- Bump redis to higher networking and size (raycast#2300)
- Merge pull request raycast#2301 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- Merge pull request raycast#2299 from githubnext/terminal-fix
- Adjust terminal z-index
- Merge pull request raycast#2296 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- approximate counting of tokens (raycast#2288)
- Fix layering (raycast#2294)
- Merge pull request raycast#2290 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- Merge pull request raycast#2289 from githubnext/drifkin/avoid-bad-deployment
- hardcode user IDs to avoid uk1 deployment
- Merge pull request raycast#2278 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- telemetry: use better instance IDs, add loadavg stats (raycast#2286)
- Merge pull request raycast#2282 from githubnext/more-guest-tweaks
- Two other tweaks for guest mode
- Merge pull request raycast#2280 from githubnext/fix-guest-mode
- Fix guest mode bugs
- add App Service-compatible SSH support (raycast#2274)
- Merge pull request raycast#2275 from githubnext/terkelg/2271
- Consistently use prod settings for staging (raycast#2268)
- fix and also prevent animation if layout is the same
- Merge pull request raycast#2267 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- telemetry: more resource stats and code fixes (raycast#2269)
- telemetry: report simple resource usage statistics every 30 seconds (raycast#2264)
- Merge pull request raycast#2261 from githubnext/integrate/staging-to-main
- Synchronize env vars between deployment slots for \`update\` (raycast#2263)
- Merge remote-tracking branch \'origin/staging\'
- Fix initial layout animation (raycast#2259)
- Merge pull request raycast#2250 from githubnext/integrate/staging-to-main
- Merge pull request raycast#2255 from githubnext/terkelg/hotfix
- Hide info button on empty timeline items (raycast#2256)
- Make file-tree and code scroll independently
- Fix FileExplorer (raycast#2241)
- Fix layout trigger raycast#2244 (raycast#2245)
- Allow editing branch name before PR creation (raycast#2247)
- fix playwright tests (raycast#2249)
- Merge pull request raycast#2238 from githubnext/integrate/main-to-staging
- Merge pull request raycast#2237 from githubnext/drifkin/stats-privileges
- only allow site devs to see stats info
- Merge pull request raycast#2236 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- Fix info button overlap (raycast#2234)
- Merge pull request raycast#2232 from githubnext/integrate/staging-to-main
- Use absolute URL for og image (raycast#2231)
- Merge pull request raycast#2227 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Last-minute polish 🕚💅 (raycast#2229)
- Add Open Graph image for social media sharing (raycast#2228)
- Merge pull request raycast#2225 from githubnext/info-tips
- add info about dashboards and exported dashboards (raycast#2226)
- Add copy for the spec/plan/implementation panel\'s info tips
- Merge pull request raycast#2219 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Update mobile previews (raycast#2223)
- Fix Monaco overlays + misc ✨  (raycast#2217)
- Merge pull request raycast#2215 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Better rate limit error message (raycast#2191)
- Create codespaces-faq.md (raycast#2189)
- Update playbook.md (raycast#2209)
- Make error for OAuth app restrictions more useful (raycast#2214)
- Merge pull request raycast#2204 from githubnext/integrate/main-to-staging
- Merge pull request raycast#2202 from githubnext/eaftan/feedback-link-update
- Merge pull request raycast#2203 from githubnext/dsyme/redeploy
- redeploy to different sku
- Use onClick instead of href
- Update \'Give feedback\' link to direct to user manual
- Merge pull request raycast#2200 from githubnext/integrate/production-to-staging
- tweak logging
- fix isSiteDev determination
- fix test failure
- Merge branch \'staging\' of https://github.com/githubnext/copilot-workspace into production
- make corrections
- Merge pull request raycast#2196 from githubnext/integrate/main-to-staging
- Merge pull request raycast#2194 from githubnext/integrate/staging-to-production
- Merge pull request raycast#2199 from githubnext/dsyme/af
- fix auth
- fix auth
- Merge remote-tracking branch \'origin/main\' into staging
- Merge pull request raycast#2195 from githubnext/colebemis/label-template-repos
- auth fix for guests
- Display label for template repositories on /new page
- Merge pull request raycast#2193 from githubnext/osortega/codespaces-auth-fix
- Merge branch \'main\' of https://github.com/githubnext/copilot-workspace into osortega/codespaces-auth-fix
- Merge remote-tracking branch \'origin/staging\' into production
- Merge pull request raycast#2187 from githubnext/integrate/main-to-staging
- File syncer fix
- Merge remote-tracking branch \'origin/main\' into staging
- Polish exit dialogs (raycast#2190)
- Add note about adding actors to the copilot_workspace_signup feature flag (raycast#2188)
- telemetry: record model call timing (raycast#2184)
- bump sizes of web app (raycast#2186)
- Merge pull request raycast#2182 from githubnext/osortega/message-update
- Merge pull request raycast#2181 from githubnext/integrate/staging-to-production
- Update error message regex
- Merge remote-tracking branch \'origin/staging\' into production
- Merge pull request raycast#2168 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Describe commit messages slightly differently to pull request descriptions (raycast#2180)
- Disable keyboard undo for now (raycast#2173)
- adds skeleton waitlist management workflow (raycast#2177)
- Merge pull request raycast#2164 from githubnext/integrate/staging-to-production
- Make file diffs scrollable while streaming (raycast#2170)
- Fix task description overflow (raycast#2171)
- telemetry: record endpoint and endpoint mode (completion or chat) (raycast#2169)
- Fix streaming of PR descriptions/commit messages in dialog (raycast#2159)
- Don\'t speculate on change of implementation (raycast#2161)
- telemetry: add stitch number to model call telemetry (raycast#2167)
- Ignore vim swapfiles in the file syncer (raycast#2162)
- Merge remote-tracking branch \'origin/staging\' into production
- Merge pull request raycast#2158 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Fix caching of model calls (raycast#2163)
- Add "Start Task" command to Raycase extension (raycast#2160)
- Limit session loading to 500 most recent sessions (raycast#2154)
- Add eslint config to raycast extension
- Update raycast readme
- Merge branch \'raycast-2\' of github.com:githubnext/semantic-workspace into raycast-2
- Fix lint issues
- Merge branch \'main\' into raycast-2
- Update default repo
- Add "Start Task" command to Raycase extension
- Merge pull request raycast#2149 from githubnext/integrate/staging-to-production
- Merge remote-tracking branch \'origin/staging\' into production
- Merge pull request raycast#2157 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Merge pull request raycast#2155 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Merge pull request raycast#2150 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Merge pull request raycast#2130 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Merge pull request raycast#2124 from githubnext/integrate/staging-to-production
- Merge pull request raycast#2128 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Merge pull request raycast#2122 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Codespaces auth fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension Issues related to one of the extensions in the Store feature request New feature or improvement wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants