Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update Obsidian Extension] Tag Filter, Markdown Controls for Edit Note, Templates for Append Action & More #2231

Merged
merged 9 commits into from
Jul 12, 2022

Conversation

marcjulianschwarz
Copy link
Contributor

@marcjulianschwarz marcjulianschwarz commented Jul 11, 2022

Description

  • Add tag filter to filter results in Search Note and Pinned Notes command by tags (YAML frontmatter and inline)
  • Add Random Note command which opens a random note in Quick Look (all actions available)
  • Edit Note action now supports markdown controls (e.g. cmd + b for bold and cmd + i for italic)
  • Append to Note and Append Selected Text to Note actions now support all templates
  • Add template preference for both Append to Note and Append Selected Text to Note actions
  • Use {content} for Append Selected Text to Note action
  • Add templates {selected}, {selectedText} for selected Text
  • Add templates {\n}, {newline}, {nl} for new line
  • Add shorter template {clip} for clipboard
  • Add Default Content and Fill Form with Default Values settings for Create Note command
  • Add Show in Finder action for all vault selection lists
  • Minor fixes

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements OP is author The OP of the PR is the author of the extension labels Jul 11, 2022
@marcjulianschwarz
Copy link
Contributor Author

marcjulianschwarz commented Jul 11, 2022

Wonder why it failed building.
It built just fine on my local copy using npm run build.

Edit: seems like the rename didnt get pushed correctly

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Thanks for your contribution 💪

With Random Note I get an empty list
CleanShot 2022-07-12 at 06 24 10@2x

I have a few notes as you can see here
CleanShot 2022-07-12 at 06 25 06@2x

Is this a bug you can look into?

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

@pernielsentikaer pernielsentikaer self-assigned this Jul 12, 2022
@marcjulianschwarz
Copy link
Contributor Author

Hi @pernielsentikaer,

thanks for pointing this out.
Should be fixed now.

@pernielsentikaer
Copy link
Collaborator

Hi @marcjulianschwarz 👋

It seems to work much better now; there is only one thing that I stumbled upon while testing Random Note

Navigation titles should not be changed in the root commands only when you push to a new view

Do you have a solution on how you can do this?

add nav title change in child views
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we for Random Note should also not set the title, maybe better add #header in the markdown instead, is this possible?

}

return (
<Form
navigationTitle={"Create Note"}
navigationTitle={"Create Note for " + vault.name}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
navigationTitle={"Create Note for " + vault.name}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh now I see where the problem is.

If you have multiple vaults the navigation titles only appear in the child views. This happens when you have only one vault.
I think then we can remove all the navigation title changes. Will push a fix.

error with selected text template
@marcjulianschwarz
Copy link
Contributor Author

marcjulianschwarz commented Jul 12, 2022

Removed the navigation title changes for commands when they are used with only one vault. For multiple vaults the changes will happen in a child view after a vault has been selected.

And removed the {selectedText} template as there were issues with the getSelectedText function not throwing an error but waiting, not resolving the promise.
Will investigate into this issue more for the next release.

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@pernielsentikaer pernielsentikaer merged commit 91660da into raycast:main Jul 12, 2022
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/marcjulian/obsidian

colebemis added a commit to colebemis/raycast-extensions that referenced this pull request Apr 29, 2024
- Update raycast images
- Update raycast copy
- Merge branch \'contributions/merge-1714401066006496000\'
- Merge pull request raycast#2323 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- Add uncaughtException handler (raycast#2321)
- Don\'t throw an error if stitching doesn\'t see \`[DONE]\` (raycast#2320)
- Merge pull request raycast#2317 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- telemetry: record disk space avail/used at \`/\` (raycast#2313)
- Merge pull request raycast#2315 from githubnext/dsyme/bsl22
- update baselines
- Merge pull request raycast#2311 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- Merge pull request raycast#2312 from githubnext/fix-terminal-error
- Fix terminal error on narrow viewports
- Out of disk space: improve remove code (raycast#2305)
- Merge pull request raycast#2307 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- Make useLongerSpecs experiment private (raycast#2306)
- Bump redis to higher networking and size (raycast#2300)
- Merge pull request raycast#2301 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- Merge pull request raycast#2299 from githubnext/terminal-fix
- Adjust terminal z-index
- Merge pull request raycast#2296 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- approximate counting of tokens (raycast#2288)
- Fix layering (raycast#2294)
- Merge pull request raycast#2290 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- Merge pull request raycast#2289 from githubnext/drifkin/avoid-bad-deployment
- hardcode user IDs to avoid uk1 deployment
- Merge pull request raycast#2278 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- telemetry: use better instance IDs, add loadavg stats (raycast#2286)
- Merge pull request raycast#2282 from githubnext/more-guest-tweaks
- Two other tweaks for guest mode
- Merge pull request raycast#2280 from githubnext/fix-guest-mode
- Fix guest mode bugs
- add App Service-compatible SSH support (raycast#2274)
- Merge pull request raycast#2275 from githubnext/terkelg/2271
- Consistently use prod settings for staging (raycast#2268)
- fix and also prevent animation if layout is the same
- Merge pull request raycast#2267 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- telemetry: more resource stats and code fixes (raycast#2269)
- telemetry: report simple resource usage statistics every 30 seconds (raycast#2264)
- Merge pull request raycast#2261 from githubnext/integrate/staging-to-main
- Synchronize env vars between deployment slots for \`update\` (raycast#2263)
- Merge remote-tracking branch \'origin/staging\'
- Fix initial layout animation (raycast#2259)
- Merge pull request raycast#2250 from githubnext/integrate/staging-to-main
- Merge pull request raycast#2255 from githubnext/terkelg/hotfix
- Hide info button on empty timeline items (raycast#2256)
- Make file-tree and code scroll independently
- Fix FileExplorer (raycast#2241)
- Fix layout trigger raycast#2244 (raycast#2245)
- Allow editing branch name before PR creation (raycast#2247)
- fix playwright tests (raycast#2249)
- Merge pull request raycast#2238 from githubnext/integrate/main-to-staging
- Merge pull request raycast#2237 from githubnext/drifkin/stats-privileges
- only allow site devs to see stats info
- Merge pull request raycast#2236 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- Fix info button overlap (raycast#2234)
- Merge pull request raycast#2232 from githubnext/integrate/staging-to-main
- Use absolute URL for og image (raycast#2231)
- Merge pull request raycast#2227 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Last-minute polish 🕚💅 (raycast#2229)
- Add Open Graph image for social media sharing (raycast#2228)
- Merge pull request raycast#2225 from githubnext/info-tips
- add info about dashboards and exported dashboards (raycast#2226)
- Add copy for the spec/plan/implementation panel\'s info tips
- Merge pull request raycast#2219 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Update mobile previews (raycast#2223)
- Fix Monaco overlays + misc ✨  (raycast#2217)
- Merge pull request raycast#2215 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Better rate limit error message (raycast#2191)
- Create codespaces-faq.md (raycast#2189)
- Update playbook.md (raycast#2209)
- Make error for OAuth app restrictions more useful (raycast#2214)
- Merge pull request raycast#2204 from githubnext/integrate/main-to-staging
- Merge pull request raycast#2202 from githubnext/eaftan/feedback-link-update
- Merge pull request raycast#2203 from githubnext/dsyme/redeploy
- redeploy to different sku
- Use onClick instead of href
- Update \'Give feedback\' link to direct to user manual
- Merge pull request raycast#2200 from githubnext/integrate/production-to-staging
- tweak logging
- fix isSiteDev determination
- fix test failure
- Merge branch \'staging\' of https://github.com/githubnext/copilot-workspace into production
- make corrections
- Merge pull request raycast#2196 from githubnext/integrate/main-to-staging
- Merge pull request raycast#2194 from githubnext/integrate/staging-to-production
- Merge pull request raycast#2199 from githubnext/dsyme/af
- fix auth
- fix auth
- Merge remote-tracking branch \'origin/main\' into staging
- Merge pull request raycast#2195 from githubnext/colebemis/label-template-repos
- auth fix for guests
- Display label for template repositories on /new page
- Merge pull request raycast#2193 from githubnext/osortega/codespaces-auth-fix
- Merge branch \'main\' of https://github.com/githubnext/copilot-workspace into osortega/codespaces-auth-fix
- Merge remote-tracking branch \'origin/staging\' into production
- Merge pull request raycast#2187 from githubnext/integrate/main-to-staging
- File syncer fix
- Merge remote-tracking branch \'origin/main\' into staging
- Polish exit dialogs (raycast#2190)
- Add note about adding actors to the copilot_workspace_signup feature flag (raycast#2188)
- telemetry: record model call timing (raycast#2184)
- bump sizes of web app (raycast#2186)
- Merge pull request raycast#2182 from githubnext/osortega/message-update
- Merge pull request raycast#2181 from githubnext/integrate/staging-to-production
- Update error message regex
- Merge remote-tracking branch \'origin/staging\' into production
- Merge pull request raycast#2168 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Describe commit messages slightly differently to pull request descriptions (raycast#2180)
- Disable keyboard undo for now (raycast#2173)
- adds skeleton waitlist management workflow (raycast#2177)
- Merge pull request raycast#2164 from githubnext/integrate/staging-to-production
- Make file diffs scrollable while streaming (raycast#2170)
- Fix task description overflow (raycast#2171)
- telemetry: record endpoint and endpoint mode (completion or chat) (raycast#2169)
- Fix streaming of PR descriptions/commit messages in dialog (raycast#2159)
- Don\'t speculate on change of implementation (raycast#2161)
- telemetry: add stitch number to model call telemetry (raycast#2167)
- Ignore vim swapfiles in the file syncer (raycast#2162)
- Merge remote-tracking branch \'origin/staging\' into production
- Merge pull request raycast#2158 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Fix caching of model calls (raycast#2163)
- Add "Start Task" command to Raycase extension (raycast#2160)
- Limit session loading to 500 most recent sessions (raycast#2154)
- Add eslint config to raycast extension
- Update raycast readme
- Merge branch \'raycast-2\' of github.com:githubnext/semantic-workspace into raycast-2
- Fix lint issues
- Merge branch \'main\' into raycast-2
- Update default repo
- Add "Start Task" command to Raycase extension
- Merge pull request raycast#2149 from githubnext/integrate/staging-to-production
- Merge remote-tracking branch \'origin/staging\' into production
- Merge pull request raycast#2157 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Merge pull request raycast#2155 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Merge pull request raycast#2150 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Merge pull request raycast#2130 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Merge pull request raycast#2124 from githubnext/integrate/staging-to-production
- Merge pull request raycast#2128 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Merge pull request raycast#2122 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Codespaces auth fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements OP is author The OP of the PR is the author of the extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants