Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new extension: dlmoji #2289

Merged
merged 19 commits into from
Aug 24, 2022
Merged

Conversation

Hydrapse
Copy link
Contributor

Description

An intelligent Emoji Dictionary helps to get related Emojis, Phrases, and AI-powered Translations in Raycast.

Features

  1. Supports Chinese & English Emoji Search
  2. Supports Semantic, Verbatim, or Blended Emoji Translation
  3. Gets related Emojis 🧐 or Emoji Phrases 🛌🏃‍♀️ with Explanations

Screencast

dlmoji-1

dlmoji-3

Config-Panel

Checklist

@raycastbot raycastbot added the new extension Label for PRs with new extensions label Jul 16, 2022
@raycastbot
Copy link
Collaborator

Congratulation on your new Raycast extension! 🚀

We will review it shortly. Once the PR is approved and merged, the extension will be available on the Store.

@Hydrapse Hydrapse closed this Jul 17, 2022
@Hydrapse Hydrapse reopened this Jul 17, 2022
@danielsequeira danielsequeira self-assigned this Jul 19, 2022
@Hydrapse
Copy link
Contributor Author

Hi @danielsequeira,
Sorry for bothering you. I'm wondering if something goes wrong, or something I can do to progress the review.
Looking forward to your reply!

@danielsequeira
Copy link
Contributor

Sorry @Hydrapse, I completely forgot about this one. I will have a look at it this week.

@danielsequeira
Copy link
Contributor

@Hydrapse one question, why the name DLmoji?

@danielsequeira
Copy link
Contributor

On another note, I think we will need to improve the UX a bit on the extension. In cases where the emoji description is too long, it doesn't look good to render it in the action panel and there are cases where even the action panel doesn't have enough space for it:
dlmoji 2022-07-27 at 13 28 09

I would suggest for you to use our detail component: https://developers.raycast.com/api-reference/user-interface/detail where we could have a detail section for each emoji and allow the entire description to be rendered.

@Hydrapse
Copy link
Contributor Author

@Hydrapse one question, why the name DLmoji?

That's because I follow the nomenclature of deepmoji.
DLmoji means emoji search powered by Deep Learning or comparable intelligent APIs, which can handle phrase or sentence level queries, different from the existing Emoji Search extension.

@danielsequeira
Copy link
Contributor

@Hydrapse one question, why the name DLmoji?

That's because I follow the nomenclature of deepmoji. DLmoji means emoji search powered by Deep Learning or comparable intelligent APIs, which can handle phrase or sentence level queries, different from the existing Emoji Search extension.

Got you! Thanks for the explanation. I think in that case it would probably make sense to mention deep learning in the package.json description and in the readme. I can imagine a lot of people like myself not really knowing what it means and that can affect the searches in the store for this extension

@Hydrapse
Copy link
Contributor Author

ok, I got it. I'll update the description and try to improve the UX by following the advice 😉

@danielsequeira
Copy link
Contributor

@Hydrapse ping here, do you still plan to finalise this PR?

@Hydrapse
Copy link
Contributor Author

Sorry for being late. I've added the Detail Page for Emoji description and updated the Readme & package.json description.
Please have a look. Thanks.
image

<ActionPanel.Section title="EmojiAll">
<Action.Push
icon={Icon.Document}
title="Description"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title="Description"
title="View Description"

let enText: string = queryText
if (hasChinese) {
// const res = await fetchDeepl(queryText)
// enText = res.data.data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove commented code


// let data = new FormData();
// data.append('keywords', queryText)
// data.append('lang', lang)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove commented code

}),
{
headers: {
// 'Content-Type': 'multipart/form-data',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove commented code


return finalData.map((text, idx) => {
return {
// title: finalData.length - 1 === idx && idx > 0 ? "All" : truncate(text),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove commented code

@danielsequeira
Copy link
Contributor

danielsequeira commented Aug 17, 2022

@Hydrapse thanks for the changes, I just added a few more comments, once they are addressed we should be good to merge this.

Also could you update your screenshots to include the new changes to the extension?

@Hydrapse
Copy link
Contributor Author

Thanks @danielsequeira. I've committed all your changes.

@danielsequeira
Copy link
Contributor

@Hydrapse thanks for the changes. One last thing I forgot, since it is not possible to read the entire description while in the List view and because you now have the View Description option, I think it makes sense to remove the description text from the list items:
dlmoji 2022-08-22 at 13 43 20

@Hydrapse
Copy link
Contributor Author

The API service of "deepmoji Emotion Analysis" is right here (for Test Only):

http://106.55.173.219:18878/

I think it might benefit the final testing 😊.

image

@danielsequeira
Copy link
Contributor

All looks good @Hydrapse, I just noticed though that now that you removed the description from the list items, your screenshots are not correct, because they still show the description and this can confuse users. Could you update them? If you do it in the next few hours, we can still merge and publish this today 🙂

@Hydrapse
Copy link
Contributor Author

Besides updating all the screenshots in README and metadata, I also add a new feature.

I've found another Emoji Translation API, which is a perfect substitute for the "18dao Chinese Verbatim" API. Then I merge this new API into the Emoji Translation Section, which works for "Chinese To Emoji" Translation and "Emoji To Text" Translation:
image
image

@danielsequeira danielsequeira merged commit 557d323 into raycast:main Aug 24, 2022
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/Hydrapse/dlmoji

@Hydrapse Hydrapse deleted the Hydrapse-dlmoji branch August 24, 2022 22:42
colebemis added a commit to colebemis/raycast-extensions that referenced this pull request Apr 29, 2024
- Update raycast images
- Update raycast copy
- Merge branch \'contributions/merge-1714401066006496000\'
- Merge pull request raycast#2323 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- Add uncaughtException handler (raycast#2321)
- Don\'t throw an error if stitching doesn\'t see \`[DONE]\` (raycast#2320)
- Merge pull request raycast#2317 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- telemetry: record disk space avail/used at \`/\` (raycast#2313)
- Merge pull request raycast#2315 from githubnext/dsyme/bsl22
- update baselines
- Merge pull request raycast#2311 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- Merge pull request raycast#2312 from githubnext/fix-terminal-error
- Fix terminal error on narrow viewports
- Out of disk space: improve remove code (raycast#2305)
- Merge pull request raycast#2307 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- Make useLongerSpecs experiment private (raycast#2306)
- Bump redis to higher networking and size (raycast#2300)
- Merge pull request raycast#2301 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- Merge pull request raycast#2299 from githubnext/terminal-fix
- Adjust terminal z-index
- Merge pull request raycast#2296 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- approximate counting of tokens (raycast#2288)
- Fix layering (raycast#2294)
- Merge pull request raycast#2290 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- Merge pull request raycast#2289 from githubnext/drifkin/avoid-bad-deployment
- hardcode user IDs to avoid uk1 deployment
- Merge pull request raycast#2278 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- telemetry: use better instance IDs, add loadavg stats (raycast#2286)
- Merge pull request raycast#2282 from githubnext/more-guest-tweaks
- Two other tweaks for guest mode
- Merge pull request raycast#2280 from githubnext/fix-guest-mode
- Fix guest mode bugs
- add App Service-compatible SSH support (raycast#2274)
- Merge pull request raycast#2275 from githubnext/terkelg/2271
- Consistently use prod settings for staging (raycast#2268)
- fix and also prevent animation if layout is the same
- Merge pull request raycast#2267 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- telemetry: more resource stats and code fixes (raycast#2269)
- telemetry: report simple resource usage statistics every 30 seconds (raycast#2264)
- Merge pull request raycast#2261 from githubnext/integrate/staging-to-main
- Synchronize env vars between deployment slots for \`update\` (raycast#2263)
- Merge remote-tracking branch \'origin/staging\'
- Fix initial layout animation (raycast#2259)
- Merge pull request raycast#2250 from githubnext/integrate/staging-to-main
- Merge pull request raycast#2255 from githubnext/terkelg/hotfix
- Hide info button on empty timeline items (raycast#2256)
- Make file-tree and code scroll independently
- Fix FileExplorer (raycast#2241)
- Fix layout trigger raycast#2244 (raycast#2245)
- Allow editing branch name before PR creation (raycast#2247)
- fix playwright tests (raycast#2249)
- Merge pull request raycast#2238 from githubnext/integrate/main-to-staging
- Merge pull request raycast#2237 from githubnext/drifkin/stats-privileges
- only allow site devs to see stats info
- Merge pull request raycast#2236 from githubnext/integrate/staging-to-main
- Merge remote-tracking branch \'origin/staging\'
- Fix info button overlap (raycast#2234)
- Merge pull request raycast#2232 from githubnext/integrate/staging-to-main
- Use absolute URL for og image (raycast#2231)
- Merge pull request raycast#2227 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Last-minute polish 🕚💅 (raycast#2229)
- Add Open Graph image for social media sharing (raycast#2228)
- Merge pull request raycast#2225 from githubnext/info-tips
- add info about dashboards and exported dashboards (raycast#2226)
- Add copy for the spec/plan/implementation panel\'s info tips
- Merge pull request raycast#2219 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Update mobile previews (raycast#2223)
- Fix Monaco overlays + misc ✨  (raycast#2217)
- Merge pull request raycast#2215 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Better rate limit error message (raycast#2191)
- Create codespaces-faq.md (raycast#2189)
- Update playbook.md (raycast#2209)
- Make error for OAuth app restrictions more useful (raycast#2214)
- Merge pull request raycast#2204 from githubnext/integrate/main-to-staging
- Merge pull request raycast#2202 from githubnext/eaftan/feedback-link-update
- Merge pull request raycast#2203 from githubnext/dsyme/redeploy
- redeploy to different sku
- Use onClick instead of href
- Update \'Give feedback\' link to direct to user manual
- Merge pull request raycast#2200 from githubnext/integrate/production-to-staging
- tweak logging
- fix isSiteDev determination
- fix test failure
- Merge branch \'staging\' of https://github.com/githubnext/copilot-workspace into production
- make corrections
- Merge pull request raycast#2196 from githubnext/integrate/main-to-staging
- Merge pull request raycast#2194 from githubnext/integrate/staging-to-production
- Merge pull request raycast#2199 from githubnext/dsyme/af
- fix auth
- fix auth
- Merge remote-tracking branch \'origin/main\' into staging
- Merge pull request raycast#2195 from githubnext/colebemis/label-template-repos
- auth fix for guests
- Display label for template repositories on /new page
- Merge pull request raycast#2193 from githubnext/osortega/codespaces-auth-fix
- Merge branch \'main\' of https://github.com/githubnext/copilot-workspace into osortega/codespaces-auth-fix
- Merge remote-tracking branch \'origin/staging\' into production
- Merge pull request raycast#2187 from githubnext/integrate/main-to-staging
- File syncer fix
- Merge remote-tracking branch \'origin/main\' into staging
- Polish exit dialogs (raycast#2190)
- Add note about adding actors to the copilot_workspace_signup feature flag (raycast#2188)
- telemetry: record model call timing (raycast#2184)
- bump sizes of web app (raycast#2186)
- Merge pull request raycast#2182 from githubnext/osortega/message-update
- Merge pull request raycast#2181 from githubnext/integrate/staging-to-production
- Update error message regex
- Merge remote-tracking branch \'origin/staging\' into production
- Merge pull request raycast#2168 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Describe commit messages slightly differently to pull request descriptions (raycast#2180)
- Disable keyboard undo for now (raycast#2173)
- adds skeleton waitlist management workflow (raycast#2177)
- Merge pull request raycast#2164 from githubnext/integrate/staging-to-production
- Make file diffs scrollable while streaming (raycast#2170)
- Fix task description overflow (raycast#2171)
- telemetry: record endpoint and endpoint mode (completion or chat) (raycast#2169)
- Fix streaming of PR descriptions/commit messages in dialog (raycast#2159)
- Don\'t speculate on change of implementation (raycast#2161)
- telemetry: add stitch number to model call telemetry (raycast#2167)
- Ignore vim swapfiles in the file syncer (raycast#2162)
- Merge remote-tracking branch \'origin/staging\' into production
- Merge pull request raycast#2158 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Fix caching of model calls (raycast#2163)
- Add "Start Task" command to Raycase extension (raycast#2160)
- Limit session loading to 500 most recent sessions (raycast#2154)
- Add eslint config to raycast extension
- Update raycast readme
- Merge branch \'raycast-2\' of github.com:githubnext/semantic-workspace into raycast-2
- Fix lint issues
- Merge branch \'main\' into raycast-2
- Update default repo
- Add "Start Task" command to Raycase extension
- Merge pull request raycast#2149 from githubnext/integrate/staging-to-production
- Merge remote-tracking branch \'origin/staging\' into production
- Merge pull request raycast#2157 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Merge pull request raycast#2155 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Merge pull request raycast#2150 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Merge pull request raycast#2130 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Merge pull request raycast#2124 from githubnext/integrate/staging-to-production
- Merge pull request raycast#2128 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Merge pull request raycast#2122 from githubnext/integrate/main-to-staging
- Merge remote-tracking branch \'origin/main\' into staging
- Codespaces auth fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new extension Label for PRs with new extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants