Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a command to download the Hermes Sampling Profiler to a local machine #1246

Merged
merged 68 commits into from
Sep 4, 2020
Merged

feat: add a command to download the Hermes Sampling Profiler to a local machine #1246

merged 68 commits into from
Sep 4, 2020

Commits on Jul 7, 2020

  1. added adb commands

    @jessieAnhNguyen
    jessieAnhNguyen committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    1167db0 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. feat: implemented download hermes profile command

    @jessieAnhNguyen
    jessieAnhNguyen committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    2047721 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2020

  1. deleted unused adbkit packages

    @jessieAnhNguyen
    jessieAnhNguyen committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    4af2cbe View commit details
    Browse the repository at this point in the history

  2. changed files excluded node modules

    @jessieAnhNguyen
    jessieAnhNguyen committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    98e1ecf View commit details
    Browse the repository at this point in the history

  3. handled edge case when there's no file

    @jessieAnhNguyen
    jessieAnhNguyen committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    24a248b View commit details
    Browse the repository at this point in the history

  4. deleted unnecessary changes

    @jessieAnhNguyen
    jessieAnhNguyen committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    b720baf View commit details
    Browse the repository at this point in the history

  5. deleted unnecessary changes 2

    @jessieAnhNguyen
    jessieAnhNguyen committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    4c0fb45 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2020

  1. Merge pull request #2 from MLH-Fellowship/jessie 

    Implemented command to download the Hermes Sampling Profiler to a local machine
    @jessieAnhNguyen
    jessieAnhNguyen committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    defc7b7 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2020

  1. added transformer files

    @jessieAnhNguyen
    jessieAnhNguyen committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    b5d1d3c View commit details
    Browse the repository at this point in the history

  2. implemented --verbose flag

    @jessieAnhNguyen
    jessieAnhNguyen committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    89837ae View commit details
    Browse the repository at this point in the history

  3. Merge branch 'jessie-cli2' into test/transformer

    @jessieAnhNguyen
    jessieAnhNguyen committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    23cd80c View commit details
    Browse the repository at this point in the history

  4. integrated transformer tool with CLI

    @jessieAnhNguyen
    jessieAnhNguyen committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    3e7c6f4 View commit details
    Browse the repository at this point in the history

  5. implemented --raw flag

    @jessieAnhNguyen
    jessieAnhNguyen committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    cbc0c28 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2020

  1. deleted changelog comments and fixed small changes

    @jessieAnhNguyen
    jessieAnhNguyen committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    28a55d4 View commit details
    Browse the repository at this point in the history

  2. changed wording

    @jessieAnhNguyen
    jessieAnhNguyen committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    680eccb View commit details
    Browse the repository at this point in the history

  3. deleted unused event types and remove unused dev dependencies

    @jessieAnhNguyen
    jessieAnhNguyen committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    ef6bb10 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2020

  1. generated source map through

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    2285b38 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2020

  1. Merge pull request #4 from MLH-Fellowship/test/transformer 

    Integrated transformer tool into CLI
    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    86c8110 View commit details
    Browse the repository at this point in the history

  2. fixed SHA-1 error

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    652290d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/MLH-Fellowship/cli into f… 

    …eat/generate-source-map
    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    deffdd2 View commit details
    Browse the repository at this point in the history

  4. implemented the source map steps

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    f560481 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. added transformer package and profile-hermes.md

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    e3fe062 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #6 from MLH-Fellowship/feat/generate-source-map 

    Feat/generate source map
    @jevakallio
    jevakallio committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    1cff3c8 View commit details
    Browse the repository at this point in the history

  3. Rename command to profile-hermes

    @jessieAnhNguyen @jevakallio
    jessieAnhNguyen authored and jevakallio committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    ca07916 View commit details
    Browse the repository at this point in the history

  4. Improve command line output examples

    @jessieAnhNguyen @jevakallio
    jessieAnhNguyen authored and jevakallio committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    867b6b2 View commit details
    Browse the repository at this point in the history

  5. Extract source map functionality to its own file

    @jessieAnhNguyen @jevakallio
    jessieAnhNguyen authored and jevakallio committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    7ee8fc6 View commit details
    Browse the repository at this point in the history

  6. Readability improvements (@todo: fix @todo comments)

    @jessieAnhNguyen @jevakallio
    jessieAnhNguyen authored and jevakallio committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    4e0dd95 View commit details
    Browse the repository at this point in the history

  7. upgrade hermes-profile-transformer package 

    implemented @todo get only the .cpuprofile from cache/
add a few verbose logs
edited profile-hermes.md
    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    c422253 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2020

  1. implemented @todo: remove axios and use node-fetch 

    add the usage to commands.md
delete the profile-hermes.md
    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    3d9d04e View commit details
    Browse the repository at this point in the history

  2. deleted small unintended changes and removed axios

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    29e55ca View commit details
    Browse the repository at this point in the history

  3. removed axios package and deleted unnecessary changes

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    1078bdb View commit details
    Browse the repository at this point in the history

  4. removed source-map related packages

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    e050ab2 View commit details
    Browse the repository at this point in the history

  5. added new line after each logger

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    b955db9 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #7 from MLH-Fellowship/chore/pre-publish 

    Pre-publish changes before making a PR to RN CLI
    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    e086ec9 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' of https://github.com/MLH-Fellowship/cli

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    423424f View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2020

  1. upgraded hermes-profile-transformer package to latest

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    b37a804 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2020

  1. moved profile-hermes folder out of cli to a separate package cli-hermes

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    2f93778 View commit details
    Browse the repository at this point in the history

  2. deleted the command from projectCommands in cli

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    ed90c7e View commit details
    Browse the repository at this point in the history

  3. re-added the command in the projectCommands

    @saphal1998 @jessieAnhNguyen
    saphal1998 authored and jessieAnhNguyen committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    aacd874 View commit details
    Browse the repository at this point in the history

  4. removed unused dependencies from cli

    @saphal1998 @jessieAnhNguyen
    saphal1998 authored and jessieAnhNguyen committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    86cba71 View commit details
    Browse the repository at this point in the history

  5. added cli-hermes to the list of yarn link

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    48b1b0f View commit details
    Browse the repository at this point in the history

  6. Merge pull request #9 from MLH-Fellowship/movePackage 

    Move the command to a different package in `packages/cli-hermes`
    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    e53ee19 View commit details
    Browse the repository at this point in the history

  7. removed unused @types/ip dependency

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    e3ff688 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'upstream/master'

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    f5e51e1 View commit details
    Browse the repository at this point in the history

  9. added @types/ip dependency in cli-hermes

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    a0ad665 View commit details
    Browse the repository at this point in the history

  10. moved @types/ip to dev dependency

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    1735396 View commit details
    Browse the repository at this point in the history

  11. added type definition for cli-hermes

    @saphal1998 @jessieAnhNguyen
    saphal1998 authored and jessieAnhNguyen committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    1b0438b View commit details
    Browse the repository at this point in the history

  12. fixed type definition

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    5ebb4ba View commit details
    Browse the repository at this point in the history

  13. Added cli-hermes ref to tsconfig in packages/cli

    @saphal1998
    saphal1998 committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    236b038 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'master' of github.com:MLH-Fellowship/cli

    @saphal1998
    saphal1998 committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    8da90e5 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2020

  1. Removed unnecessary code comment 

    Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
    @jessieAnhNguyen @thymikee
    jessieAnhNguyen and thymikee committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    f7cb658 View commit details
    Browse the repository at this point in the history

  2. made changes based on PR review

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    c85506e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/MLH-Fellowship/cli

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    125836c View commit details
    Browse the repository at this point in the history

  4. added a verbose log

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    b7dbb5e View commit details
    Browse the repository at this point in the history

  5. added cli-platform-android as a dependency

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    27f14d9 View commit details
    Browse the repository at this point in the history

  6. added cli-platform-android as a dependency in cli

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    02263ae View commit details
    Browse the repository at this point in the history

  7. Fixing path in tsconfig

    @saphal1998
    saphal1998 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    8fc1b01 View commit details
    Browse the repository at this point in the history

  8. Merge conflict

    @saphal1998
    saphal1998 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    bfc08b2 View commit details
    Browse the repository at this point in the history

  9. Added type defs of platform-android to cli-hermes, path fixed

    @saphal1998
    saphal1998 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    4478249 View commit details
    Browse the repository at this point in the history

  10. Fixed chalk version on cli-hermes

    @saphal1998
    saphal1998 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    93acfcd View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2020

  1. removed unnecessary comment

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    9607160 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master'

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    4e50329 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/MLH-Fellowship/cli

    @jessieAnhNguyen
    jessieAnhNguyen committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    dcabe01 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2020

  1. changed --filename flag and throw real error

    @jessieAnhNguyen
    jessieAnhNguyen committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    3e97a31 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #10 from MLH-Fellowship/review/edit 

    Changed based on PR's reviews
    @jessieAnhNguyen
    jessieAnhNguyen committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    f4b4041 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Fix catch block in profile-hermes/index to match the error thrown

    @saphal1998
    saphal1998 committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    75095c5 View commit details
    Browse the repository at this point in the history

  2. Typecast error as CLIError

    @saphal1998
    saphal1998 committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    32a917e View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Apply suggestions from code review 

    - Fixed `filename` nit in the `commands.md` file
- Improved debugging by logging an error in case source maps could not be fetched

Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
    @saphal1998 @thymikee
    saphal1998 and thymikee committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    8d6fb8f View commit details
    Browse the repository at this point in the history