feature: ark version differentiation #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
==========================================
- Coverage 83.56% 83.51% -0.06%
==========================================
Files 51 52 +1
Lines 5483 5538 +55
==========================================
+ Hits 4582 4625 +43
- Misses 901 913 +12
☔ View full report in Codecov by Sentry. |
Me neither - I chatted w/ Remco and he was also OK with it.
This changes the feature flag name, does that warrant semver major maybe? Remco said ideally we could do this for all |
gakonst
approved these changes
Jul 21, 2023
| @@ -47,7 +47,8 @@ thiserror = "1.0" | |||
| # support | |||
| alloy-rlp = { version = "0.3", optional = true } | |||
| arbitrary = { version = "1", optional = true } | |||
| ark-ff = { version = "0.4", optional = true } | |||
| ark-ff-04 = { version = "0.4.0", package = "ark-ff", optional = true } | |||
Comment on lines
+21
to
+27
| macro_rules! impl_from_ark { | ||
| ($ark:ty, $bits:expr, $limbs:expr) => { | ||
| impl From<$ark> for Uint<$bits, $limbs> { | ||
| fn from(value: $ark) -> Self { | ||
| Self::from_limbs(value.0) | ||
| } | ||
| } |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #240
Solution
ark_ff_04.rs.ark_ff.rsark-ffark-ff-04Considerations:
To avoid a backwards-incompatible interface change, the newer ark functionality has the qualified feature-name
ark-ff-04. This preserves the current released behavior of--feature ark-ff, but users may not expect new functionality to be behind the more-involved feature flagDon't love the name
ark-ff-04This PR makes the ark changes semver minor. Previous changes were semver major
PR Checklist