Update aliases.rs #303
Closed
Update aliases.rs #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
reviewed
Sep 3, 2023
src/aliases.rs
Outdated
| @@ -56,6 +56,7 @@ alias! { | |||
| U384 B384 (384, 6); | |||
| U448 B448 (448, 7); | |||
| U512 B512 (512, 8); | |||
| U784 B784 (784, 12); | |||
There was a problem hiding this comment.
the LIMBS param needs to be 13. 64 * 12 == 768, which will not quite fit 784 bits
There was a problem hiding this comment.
yeah it should be U768 and B768, sorry
There was a problem hiding this comment.
ah cool. mind pushing a commit to change that?
|
succeeded here: #310 because i messed up the branch updating :D |
|
Thanks @prestwich , sorry for being a bit sloppy here |
|
Nah i was also a bit sloppy lol. We're dealing with some dep issues right now, so this will go in once those are resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add U784 and B784 aliases
This is useful because 96 bytes is the length
BlsSignatureused in, for example, MEV-Boost (relays accept signatures in this format).