Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Placeholder] fix: restrict parity-scale-codec to <3.6.7 #311

Closed
wants to merge 1 commit into from

Conversation

prestwich
Copy link
Collaborator

@prestwich prestwich commented Sep 11, 2023

Workaround for paritytech/parity-scale-codec#520

Don't merge unless upstream fix never appears

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@prestwich prestwich self-assigned this Sep 11, 2023
@prestwich prestwich added the bug Something isn't working label Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06% 🎉

Comparison is base (da9f1a4) 80.35% compared to head (7764c03) 80.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
+ Coverage   80.35%   80.42%   +0.06%     
==========================================
  Files          54       54              
  Lines        5996     5996              
==========================================
+ Hits         4818     4822       +4     
+ Misses       1178     1174       -4     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prestwich prestwich mentioned this pull request Sep 12, 2023
3 tasks
@prestwich prestwich changed the title fix: restrict parity-scale-codec to <3.6.7 [Placeholder] fix: restrict parity-scale-codec to <3.6.7 Sep 12, 2023
@prestwich
Copy link
Collaborator Author

closing in favor of #320 and #313

@prestwich prestwich closed this Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant