Skip to content

DEV: update ACL categories for search commands #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

dwdougherty
Copy link
Collaborator

@dwdougherty dwdougherty commented Feb 13, 2025

DOC-4853

Hi @raz-mon. I've updated the ACL categories for all the search commands according to the document you linked to me. Please take a look.

@dwdougherty dwdougherty added dev CE 8.0 Redis Community Edition 8.0 (future) labels Feb 13, 2025
@dwdougherty dwdougherty requested a review from raz-mon February 13, 2025 15:50
@dwdougherty dwdougherty self-assigned this Feb 13, 2025
Copy link
Contributor

Staging links:
https://redis.io/docs/staging/DOC-4853/commands/ft._list/
https://redis.io/docs/staging/DOC-4853/commands/ft.aliasadd/
https://redis.io/docs/staging/DOC-4853/commands/ft.aliasdel/
https://redis.io/docs/staging/DOC-4853/commands/ft.aliasupdate/
https://redis.io/docs/staging/DOC-4853/commands/ft.alter/
https://redis.io/docs/staging/DOC-4853/commands/ft.config-get/
https://redis.io/docs/staging/DOC-4853/commands/ft.config-help/
https://redis.io/docs/staging/DOC-4853/commands/ft.config-set/
https://redis.io/docs/staging/DOC-4853/commands/ft.create/
https://redis.io/docs/staging/DOC-4853/commands/ft.cursor-del/
https://redis.io/docs/staging/DOC-4853/commands/ft.cursor-read/
https://redis.io/docs/staging/DOC-4853/commands/ft.dictadd/
https://redis.io/docs/staging/DOC-4853/commands/ft.dictdel/
https://redis.io/docs/staging/DOC-4853/commands/ft.dictdump/
https://redis.io/docs/staging/DOC-4853/commands/ft.dropindex/
https://redis.io/docs/staging/DOC-4853/commands/ft.explain/
https://redis.io/docs/staging/DOC-4853/commands/ft.explaincli/
https://redis.io/docs/staging/DOC-4853/commands/ft.info/
https://redis.io/docs/staging/DOC-4853/commands/ft.profile/
https://redis.io/docs/staging/DOC-4853/commands/ft.search/
https://redis.io/docs/staging/DOC-4853/commands/ft.spellcheck/
https://redis.io/docs/staging/DOC-4853/commands/ft.sugadd/
https://redis.io/docs/staging/DOC-4853/commands/ft.sugdel/
https://redis.io/docs/staging/DOC-4853/commands/ft.sugget/
https://redis.io/docs/staging/DOC-4853/commands/ft.suglen/
https://redis.io/docs/staging/DOC-4853/commands/ft.syndump/
https://redis.io/docs/staging/DOC-4853/commands/ft.synupdate/
https://redis.io/docs/staging/DOC-4853/commands/ft.tagvals/

@dwdougherty dwdougherty removed the request for review from raz-mon February 14, 2025 14:44
@dwdougherty dwdougherty merged commit 147d1fa into community-edition-8 Feb 14, 2025
5 checks passed
@dwdougherty dwdougherty deleted the DOC-4853 branch February 14, 2025 14:45
dwdougherty added a commit that referenced this pull request Apr 7, 2025
* Edits for CE 8.0

* More edits for CE 8.0

* More edits for CE 8.0

* DEV: module configuration changes for CE8 (#956)

* DEV: CONFIG for modules changes for CE8

* Renaming file

* Apply suggestions from Rachel's code review

Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>

* Apply suggestions from Rachel's code review (part 2)

Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>

* Apply suggestions from Lior's code review

* Apply suggestions from Lior's code review (part 2)

---------

Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>

* DEV: ACL changes for CE8 (#975)

* DEV: ACL changes for CE8

* Applied suggestions from Lior's code review (part 1)

* Applied suggestions from Lior's code review (part 2)

* Fix for something completely unrelated

* Applied suggestions from Lior's code review (part 3)

* async io threads (#1020)

* DEV: update ACL categories for search commands (#1165)

* DEV+OP: add CE8 changes to INFO cmd & Prometheus for RS pages (#1170)

* DEV+OP: add CE8 changes to INFO cmd & Prometheus for RS pages

* Apply review comments.

Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>

* Apply review comments.

---------

Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>

* DEV: collapse cmd categories and remove Stack from layouts and cmd pages (#1180)

* DEV: deprecate dialogs 1, 3, and 4; config. changes (#1197)

* DEV: update modules API docs for CE8 RC1 (#1207)

* DEV: add new HFE commands (#1204)

* DEV: some corrections for the previous merge... (#1211)

* DEV: add new HFE commands

* DEV: correct previous merge

* DEV: update installation docs for CE8 (#1218)

* DEV: initial commit of installation docs for CE8

* DEV: 2nd commit of installation docs for CE8

* DEV: 3rd commit of installation docs for CE8

* Apply suggestions from code review

Thank you, @mich-elle-luna!

Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com>

* Some more patching via to using

* Patch up botched merge text

* Remove more instances of Redis Stack

* Apply code review comments

* Add ACL info related to index creation

* Replace instances of baseurl with relref

* Remove vector-set.md page (prematurely added)

* Minor update to archived installation page

* DEV: add build from source procedures (#1319)

* DEV: add build from source procedures

* Apply review comments; added AlmaLinux and Ubuntu (Focal) pages

* Apply review comments; merged alma/rocky pages; added stubs for macOS

* Added macOS 13/14 page

* Apply code review comments and issues found whilst testing

* Bug fix

* Change titles per Lior

* Remove bash requirement from alma/rocky; it's already there

* Remove banner as instructs are complete

* DEV: point to GitHub for source downloads (#1358)

* DEV: point to GitHub for source downloads

* Adding the remaining pages

* Finalize the build instructions

* DEV: add new vector set data type and command pages (#1334)

* Initial commit of vector set docs

* Add'l commit of vector set docs

* Add'l commit of vector set docs

* Adding data type and command pages

* Added RESP2 and RESP3 return information

* Fix some atrocious grammar on the vs index page.

* A few more quick fixes

* Apply suggestions from code review

Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com>

* Apply review comments

Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com>

* Apply preview banner + misc. fixes

---------

Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com>

* Typo fix

* Update modules-api-ref.md from script

* Update docker installation instructions

* Update brew installation instructions

* Add what's new info

* Update snap installation instructions

---------

Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>
Co-authored-by: Yuan Wang <wangyuancode@163.com>
Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com>
dwdougherty added a commit that referenced this pull request May 1, 2025
* Edits for CE 8.0

* More edits for CE 8.0

* More edits for CE 8.0

* DEV: module configuration changes for CE8 (#956)

* DEV: CONFIG for modules changes for CE8

* Renaming file

* Apply suggestions from Rachel's code review

Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>

* Apply suggestions from Rachel's code review (part 2)

Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>

* Apply suggestions from Lior's code review

* Apply suggestions from Lior's code review (part 2)

---------

Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>

* DEV: ACL changes for CE8 (#975)

* DEV: ACL changes for CE8

* Applied suggestions from Lior's code review (part 1)

* Applied suggestions from Lior's code review (part 2)

* Fix for something completely unrelated

* Applied suggestions from Lior's code review (part 3)

* async io threads (#1020)

* DEV: update ACL categories for search commands (#1165)

* DEV+OP: add CE8 changes to INFO cmd & Prometheus for RS pages (#1170)

* DEV+OP: add CE8 changes to INFO cmd & Prometheus for RS pages

* Apply review comments.

Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>

* Apply review comments.

---------

Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>

* DEV: collapse cmd categories and remove Stack from layouts and cmd pages (#1180)

* DEV: deprecate dialogs 1, 3, and 4; config. changes (#1197)

* DEV: update modules API docs for CE8 RC1 (#1207)

* DEV: add new HFE commands (#1204)

* DEV: some corrections for the previous merge... (#1211)

* DEV: add new HFE commands

* DEV: correct previous merge

* DEV: update installation docs for CE8 (#1218)

* DEV: initial commit of installation docs for CE8

* DEV: 2nd commit of installation docs for CE8

* DEV: 3rd commit of installation docs for CE8

* Apply suggestions from code review

Thank you, @mich-elle-luna!

Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com>

* Some more patching via to using

* Patch up botched merge text

* Remove more instances of Redis Stack

* Apply code review comments

* Add ACL info related to index creation

* Replace instances of baseurl with relref

* Remove vector-set.md page (prematurely added)

* Minor update to archived installation page

* DEV: add build from source procedures (#1319)

* DEV: add build from source procedures

* Apply review comments; added AlmaLinux and Ubuntu (Focal) pages

* Apply review comments; merged alma/rocky pages; added stubs for macOS

* Added macOS 13/14 page

* Apply code review comments and issues found whilst testing

* Bug fix

* Change titles per Lior

* Remove bash requirement from alma/rocky; it's already there

* Remove banner as instructs are complete

* DEV/OP: Redis Open Source brand changes

* Remove superfluous files

* Update newly added files

* Update newly added files; again

* Update dt>json>ram page

* Update what's new page

* Coupla more updates

* Minor update to product landing page

* Banner and ordering updates

* Apply suggestions from code review

Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>

* Remove macOS 15 build instructions

---------

Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>
Co-authored-by: Yuan Wang <wangyuancode@163.com>
Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CE 8.0 Redis Community Edition 8.0 (future) dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant