DEV: some corrections for the previous merge... #1211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-stark-redis
approved these changes
Feb 25, 2025
|
Thank you @cmilesb and @andy-stark-redis! |
dwdougherty
added a commit
that referenced
this pull request
Apr 7, 2025
* Edits for CE 8.0 * More edits for CE 8.0 * More edits for CE 8.0 * DEV: module configuration changes for CE8 (#956) * DEV: CONFIG for modules changes for CE8 * Renaming file * Apply suggestions from Rachel's code review Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com> * Apply suggestions from Rachel's code review (part 2) Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com> * Apply suggestions from Lior's code review * Apply suggestions from Lior's code review (part 2) --------- Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com> * DEV: ACL changes for CE8 (#975) * DEV: ACL changes for CE8 * Applied suggestions from Lior's code review (part 1) * Applied suggestions from Lior's code review (part 2) * Fix for something completely unrelated * Applied suggestions from Lior's code review (part 3) * async io threads (#1020) * DEV: update ACL categories for search commands (#1165) * DEV+OP: add CE8 changes to INFO cmd & Prometheus for RS pages (#1170) * DEV+OP: add CE8 changes to INFO cmd & Prometheus for RS pages * Apply review comments. Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com> * Apply review comments. --------- Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com> * DEV: collapse cmd categories and remove Stack from layouts and cmd pages (#1180) * DEV: deprecate dialogs 1, 3, and 4; config. changes (#1197) * DEV: update modules API docs for CE8 RC1 (#1207) * DEV: add new HFE commands (#1204) * DEV: some corrections for the previous merge... (#1211) * DEV: add new HFE commands * DEV: correct previous merge * DEV: update installation docs for CE8 (#1218) * DEV: initial commit of installation docs for CE8 * DEV: 2nd commit of installation docs for CE8 * DEV: 3rd commit of installation docs for CE8 * Apply suggestions from code review Thank you, @mich-elle-luna! Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com> * Some more patching via to using * Patch up botched merge text * Remove more instances of Redis Stack * Apply code review comments * Add ACL info related to index creation * Replace instances of baseurl with relref * Remove vector-set.md page (prematurely added) * Minor update to archived installation page * DEV: add build from source procedures (#1319) * DEV: add build from source procedures * Apply review comments; added AlmaLinux and Ubuntu (Focal) pages * Apply review comments; merged alma/rocky pages; added stubs for macOS * Added macOS 13/14 page * Apply code review comments and issues found whilst testing * Bug fix * Change titles per Lior * Remove bash requirement from alma/rocky; it's already there * Remove banner as instructs are complete * DEV: point to GitHub for source downloads (#1358) * DEV: point to GitHub for source downloads * Adding the remaining pages * Finalize the build instructions * DEV: add new vector set data type and command pages (#1334) * Initial commit of vector set docs * Add'l commit of vector set docs * Add'l commit of vector set docs * Adding data type and command pages * Added RESP2 and RESP3 return information * Fix some atrocious grammar on the vs index page. * A few more quick fixes * Apply suggestions from code review Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com> * Apply review comments Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com> * Apply preview banner + misc. fixes --------- Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com> * Typo fix * Update modules-api-ref.md from script * Update docker installation instructions * Update brew installation instructions * Add what's new info * Update snap installation instructions --------- Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com> Co-authored-by: Yuan Wang <wangyuancode@163.com> Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com> Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com>
dwdougherty
added a commit
that referenced
this pull request
May 1, 2025
* Edits for CE 8.0 * More edits for CE 8.0 * More edits for CE 8.0 * DEV: module configuration changes for CE8 (#956) * DEV: CONFIG for modules changes for CE8 * Renaming file * Apply suggestions from Rachel's code review Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com> * Apply suggestions from Rachel's code review (part 2) Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com> * Apply suggestions from Lior's code review * Apply suggestions from Lior's code review (part 2) --------- Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com> * DEV: ACL changes for CE8 (#975) * DEV: ACL changes for CE8 * Applied suggestions from Lior's code review (part 1) * Applied suggestions from Lior's code review (part 2) * Fix for something completely unrelated * Applied suggestions from Lior's code review (part 3) * async io threads (#1020) * DEV: update ACL categories for search commands (#1165) * DEV+OP: add CE8 changes to INFO cmd & Prometheus for RS pages (#1170) * DEV+OP: add CE8 changes to INFO cmd & Prometheus for RS pages * Apply review comments. Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com> * Apply review comments. --------- Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com> * DEV: collapse cmd categories and remove Stack from layouts and cmd pages (#1180) * DEV: deprecate dialogs 1, 3, and 4; config. changes (#1197) * DEV: update modules API docs for CE8 RC1 (#1207) * DEV: add new HFE commands (#1204) * DEV: some corrections for the previous merge... (#1211) * DEV: add new HFE commands * DEV: correct previous merge * DEV: update installation docs for CE8 (#1218) * DEV: initial commit of installation docs for CE8 * DEV: 2nd commit of installation docs for CE8 * DEV: 3rd commit of installation docs for CE8 * Apply suggestions from code review Thank you, @mich-elle-luna! Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com> * Some more patching via to using * Patch up botched merge text * Remove more instances of Redis Stack * Apply code review comments * Add ACL info related to index creation * Replace instances of baseurl with relref * Remove vector-set.md page (prematurely added) * Minor update to archived installation page * DEV: add build from source procedures (#1319) * DEV: add build from source procedures * Apply review comments; added AlmaLinux and Ubuntu (Focal) pages * Apply review comments; merged alma/rocky pages; added stubs for macOS * Added macOS 13/14 page * Apply code review comments and issues found whilst testing * Bug fix * Change titles per Lior * Remove bash requirement from alma/rocky; it's already there * Remove banner as instructs are complete * DEV/OP: Redis Open Source brand changes * Remove superfluous files * Update newly added files * Update newly added files; again * Update dt>json>ram page * Update what's new page * Coupla more updates * Minor update to product landing page * Banner and ordering updates * Apply suggestions from code review Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com> * Remove macOS 15 build instructions --------- Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com> Co-authored-by: Yuan Wang <wangyuancode@163.com> Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com> Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...that I forgot to commit. These changes were already reviewed, so this just needs tacit approval from one of the writers.