Skip to content

DEV: ACL changes for CE8 #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 13, 2024
Merged

DEV: ACL changes for CE8 #975

merged 5 commits into from
Dec 13, 2024

Conversation

dwdougherty
Copy link
Collaborator

@dwdougherty dwdougherty commented Dec 11, 2024 •
edited
Loading

DOC-4581

Note to reviewers: in cases where certain commands were marked "fast?" in the PRD, in direct conflict with the notes about how they should be marked (O(1) = @fast, anything else = @slow), I've left no @fast/@slow annotation. I can sort this later.

@dwdougherty dwdougherty added do not merge yet ros 8.0 Redis Open Source 8.0 labels Dec 11, 2024
@dwdougherty dwdougherty requested review from LiorKogan and a team December 11, 2024 17:29
@dwdougherty dwdougherty self-assigned this Dec 11, 2024
@dwdougherty dwdougherty changed the base branch from main to community-edition-8 December 11, 2024 17:31
LiorKogan
LiorKogan reviewed Dec 11, 2024
View reviewed changes
LiorKogan
LiorKogan reviewed Dec 11, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Staging links:
https://redis.io/docs/staging/DOC-4581/commands/acl-cat/
https://redis.io/docs/staging/DOC-4581/commands/bf.add/
https://redis.io/docs/staging/DOC-4581/commands/bf.card/
https://redis.io/docs/staging/DOC-4581/commands/bf.exists/
https://redis.io/docs/staging/DOC-4581/commands/bf.info/
https://redis.io/docs/staging/DOC-4581/commands/bf.insert/
https://redis.io/docs/staging/DOC-4581/commands/bf.loadchunk/
https://redis.io/docs/staging/DOC-4581/commands/bf.madd/
https://redis.io/docs/staging/DOC-4581/commands/bf.mexists/
https://redis.io/docs/staging/DOC-4581/commands/bf.reserve/
https://redis.io/docs/staging/DOC-4581/commands/bf.scandump/
https://redis.io/docs/staging/DOC-4581/commands/cf.add/
https://redis.io/docs/staging/DOC-4581/commands/cf.addnx/
https://redis.io/docs/staging/DOC-4581/commands/cf.count/
https://redis.io/docs/staging/DOC-4581/commands/cf.del/
https://redis.io/docs/staging/DOC-4581/commands/cf.exists/
https://redis.io/docs/staging/DOC-4581/commands/cf.info/
https://redis.io/docs/staging/DOC-4581/commands/cf.insert/
https://redis.io/docs/staging/DOC-4581/commands/cf.insertnx/
https://redis.io/docs/staging/DOC-4581/commands/cf.loadchunk/
https://redis.io/docs/staging/DOC-4581/commands/cf.mexists/
https://redis.io/docs/staging/DOC-4581/commands/cf.reserve/
https://redis.io/docs/staging/DOC-4581/commands/cf.scandump/
https://redis.io/docs/staging/DOC-4581/commands/cms.incrby/
https://redis.io/docs/staging/DOC-4581/commands/cms.info/
https://redis.io/docs/staging/DOC-4581/commands/cms.initbydim/
https://redis.io/docs/staging/DOC-4581/commands/cms.initbyprob/
https://redis.io/docs/staging/DOC-4581/commands/cms.merge/
https://redis.io/docs/staging/DOC-4581/commands/cms.query/
https://redis.io/docs/staging/DOC-4581/commands/ft._list/

LiorKogan
LiorKogan reviewed Dec 12, 2024
View reviewed changes
@dwdougherty dwdougherty merged commit 161f6a7 into community-edition-8 Dec 13, 2024
5 checks passed
@dwdougherty dwdougherty deleted the DOC-4581 branch December 13, 2024 16:14
dwdougherty added a commit that referenced this pull request Apr 7, 2025
@dwdougherty @rrelledge
@ShooterIT @andy-stark-redis @mich-elle-luna
DEV/OP: cumulative changes for Redis CE 8 (#1219)
cb9b677 
* Edits for CE 8.0

* More edits for CE 8.0

* More edits for CE 8.0

* DEV: module configuration changes for CE8 (#956)

* DEV: CONFIG for modules changes for CE8

* Renaming file

* Apply suggestions from Rachel's code review

Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>

* Apply suggestions from Rachel's code review (part 2)

Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>

* Apply suggestions from Lior's code review

* Apply suggestions from Lior's code review (part 2)

---------

Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>

* DEV: ACL changes for CE8 (#975)

* DEV: ACL changes for CE8

* Applied suggestions from Lior's code review (part 1)

* Applied suggestions from Lior's code review (part 2)

* Fix for something completely unrelated

* Applied suggestions from Lior's code review (part 3)

* async io threads (#1020)

* DEV: update ACL categories for search commands (#1165)

* DEV+OP: add CE8 changes to INFO cmd & Prometheus for RS pages (#1170)

* DEV+OP: add CE8 changes to INFO cmd & Prometheus for RS pages

* Apply review comments.

Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>

* Apply review comments.

---------

Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>

* DEV: collapse cmd categories and remove Stack from layouts and cmd pages (#1180)

* DEV: deprecate dialogs 1, 3, and 4; config. changes (#1197)

* DEV: update modules API docs for CE8 RC1 (#1207)

* DEV: add new HFE commands (#1204)

* DEV: some corrections for the previous merge... (#1211)

* DEV: add new HFE commands

* DEV: correct previous merge

* DEV: update installation docs for CE8 (#1218)

* DEV: initial commit of installation docs for CE8

* DEV: 2nd commit of installation docs for CE8

* DEV: 3rd commit of installation docs for CE8

* Apply suggestions from code review

Thank you, @mich-elle-luna!

Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com>

* Some more patching via to using

* Patch up botched merge text

* Remove more instances of Redis Stack

* Apply code review comments

* Add ACL info related to index creation

* Replace instances of baseurl with relref

* Remove vector-set.md page (prematurely added)

* Minor update to archived installation page

* DEV: add build from source procedures (#1319)

* DEV: add build from source procedures

* Apply review comments; added AlmaLinux and Ubuntu (Focal) pages

* Apply review comments; merged alma/rocky pages; added stubs for macOS

* Added macOS 13/14 page

* Apply code review comments and issues found whilst testing

* Bug fix

* Change titles per Lior

* Remove bash requirement from alma/rocky; it's already there

* Remove banner as instructs are complete

* DEV: point to GitHub for source downloads (#1358)

* DEV: point to GitHub for source downloads

* Adding the remaining pages

* Finalize the build instructions

* DEV: add new vector set data type and command pages (#1334)

* Initial commit of vector set docs

* Add'l commit of vector set docs

* Add'l commit of vector set docs

* Adding data type and command pages

* Added RESP2 and RESP3 return information

* Fix some atrocious grammar on the vs index page.

* A few more quick fixes

* Apply suggestions from code review

Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com>

* Apply review comments

Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com>

* Apply preview banner + misc. fixes

---------

Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com>

* Typo fix

* Update modules-api-ref.md from script

* Update docker installation instructions

* Update brew installation instructions

* Add what's new info

* Update snap installation instructions

---------

Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>
Co-authored-by: Yuan Wang <wangyuancode@163.com>
Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com>
dwdougherty added a commit that referenced this pull request May 1, 2025
@dwdougherty @rrelledge
@ShooterIT @andy-stark-redis @mich-elle-luna
DOC-5048 (#1484)
fc4eb4a 
* Edits for CE 8.0

* More edits for CE 8.0

* More edits for CE 8.0

* DEV: module configuration changes for CE8 (#956)

* DEV: CONFIG for modules changes for CE8

* Renaming file

* Apply suggestions from Rachel's code review

Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>

* Apply suggestions from Rachel's code review (part 2)

Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>

* Apply suggestions from Lior's code review

* Apply suggestions from Lior's code review (part 2)

---------

Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>

* DEV: ACL changes for CE8 (#975)

* DEV: ACL changes for CE8

* Applied suggestions from Lior's code review (part 1)

* Applied suggestions from Lior's code review (part 2)

* Fix for something completely unrelated

* Applied suggestions from Lior's code review (part 3)

* async io threads (#1020)

* DEV: update ACL categories for search commands (#1165)

* DEV+OP: add CE8 changes to INFO cmd & Prometheus for RS pages (#1170)

* DEV+OP: add CE8 changes to INFO cmd & Prometheus for RS pages

* Apply review comments.

Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>

* Apply review comments.

---------

Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>

* DEV: collapse cmd categories and remove Stack from layouts and cmd pages (#1180)

* DEV: deprecate dialogs 1, 3, and 4; config. changes (#1197)

* DEV: update modules API docs for CE8 RC1 (#1207)

* DEV: add new HFE commands (#1204)

* DEV: some corrections for the previous merge... (#1211)

* DEV: add new HFE commands

* DEV: correct previous merge

* DEV: update installation docs for CE8 (#1218)

* DEV: initial commit of installation docs for CE8

* DEV: 2nd commit of installation docs for CE8

* DEV: 3rd commit of installation docs for CE8

* Apply suggestions from code review

Thank you, @mich-elle-luna!

Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com>

* Some more patching via to using

* Patch up botched merge text

* Remove more instances of Redis Stack

* Apply code review comments

* Add ACL info related to index creation

* Replace instances of baseurl with relref

* Remove vector-set.md page (prematurely added)

* Minor update to archived installation page

* DEV: add build from source procedures (#1319)

* DEV: add build from source procedures

* Apply review comments; added AlmaLinux and Ubuntu (Focal) pages

* Apply review comments; merged alma/rocky pages; added stubs for macOS

* Added macOS 13/14 page

* Apply code review comments and issues found whilst testing

* Bug fix

* Change titles per Lior

* Remove bash requirement from alma/rocky; it's already there

* Remove banner as instructs are complete

* DEV/OP: Redis Open Source brand changes

* Remove superfluous files

* Update newly added files

* Update newly added files; again

* Update dt>json>ram page

* Update what's new page

* Coupla more updates

* Minor update to product landing page

* Banner and ordering updates

* Apply suggestions from code review

Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>

* Remove macOS 15 build instructions

---------

Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>
Co-authored-by: Yuan Wang <wangyuancode@163.com>
Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiorKogan LiorKogan LiorKogan left review comments

@raz-mon raz-mon raz-mon left review comments

@cmilesb cmilesb cmilesb approved these changes

Assignees

@dwdougherty dwdougherty

Labels
ros 8.0 Redis Open Source 8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dwdougherty @LiorKogan @raz-mon @cmilesb