Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better removal of hiredis warning #1726

Merged
merged 2 commits into from
Nov 21, 2021
Merged

Better removal of hiredis warning #1726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
530cc5a
remove warning + bump version
Nov 18, 2021
85b32a8
remove warning + bump version
Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion redis/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def int_or_str(value):
return value


__version__ = "4.0.1"
__version__ = "4.0.2"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if the version shouldn't be bumped here (I copied this from #1721)



VERSION = tuple(map(int_or_str, __version__.split('.')))
Expand Down
4 changes: 0 additions & 4 deletions redis/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import os
import socket
import threading
import warnings
import weakref

from redis.exceptions import (
Expand Down Expand Up @@ -67,9 +66,6 @@
# only use byte buffer if hiredis supports it
if not HIREDIS_SUPPORTS_BYTE_BUFFER:
HIREDIS_USE_BYTE_BUFFER = False
else:
msg = "redis-py works best with hiredis. Please consider installing"
warnings.warn(msg)

SYM_STAR = b'*'
SYM_DOLLAR = b'$'
Expand Down