Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing hiredis warning #1721

Merged
merged 1 commit into from
Nov 17, 2021
Merged

removing hiredis warning #1721

merged 1 commit into from
Nov 17, 2021

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Nov 17, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2021

Codecov Report

Merging #1721 (fe68b7d) into master (c02d720) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1721      +/-   ##
==========================================
+ Coverage   89.03%   89.08%   +0.05%     
==========================================
  Files          53       53              
  Lines       11078    11075       -3     
==========================================
+ Hits         9863     9866       +3     
+ Misses       1215     1209       -6     
Impacted Files Coverage Δ
redis/connection.py 71.61% <ø> (+0.14%) ⬆️
redis/__init__.py 84.61% <100.00%> (ø)
tests/test_search.py 98.85% <0.00%> (+0.28%) ⬆️
tests/conftest.py 93.50% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c02d720...fe68b7d. Read the comment docs.

@chayim chayim merged commit e74ed19 into master Nov 17, 2021
@chayim chayim deleted the ck-hiredis-remove-and-4.01 branch November 17, 2021 09:54
@chayim chayim added the bug Bug label Nov 17, 2021
@pcmoritz
Copy link

Would it also make sense to remove the warning in https://github.com/redis/redis-py/pull/1721/files#diff-45b6ba995a827b484d3ef97cb806d336bf058ff9678b04cf371200ea53e584d0L76 ? We have been running into problems with hiredis on Apple Silicon (M1) and Windows, so for us it is preferable to run the redis module without hiredis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants