Better removal of hiredis warning #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuisawesome
commented
Nov 18, 2021
| @@ -37,7 +37,7 @@ def int_or_str(value): | |||
| return value | |||
|
|
|||
|
|
|||
| __version__ = "4.0.1" | |||
| __version__ = "4.0.2" | |||
There was a problem hiding this comment.
Let me know if the version shouldn't be bumped here (I copied this from #1721)
6 tasks
|
@chayim would you mind reviewing this PR when you get the chance? |
|
Thank you @wuisawesome I thought I had them all. Much appreciated! |
chayim
approved these changes
Nov 18, 2021
|
No problem @chayim , do you happen to have a timeline for when the next patch release will be out? |
6 tasks
|
Definitely next week. Ideally early. I want to fix a couple of issues with json and include that ideally. |
qiluo-msft
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jan 10, 2022
…#9704) Reverts #9317 Since upstream fixed the issue redis/redis-py#1726 We can continue use latest version on master branch. Fixes #9318
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
It looks like #1721 intended to remove the hiredis warning, but didn't fully remove it when byte buffers aren't available.
This PR tries to do the same thing, but remove the error message in the other case.
Closes #1725
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.