Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

based on the following issues and prs, looks like the warning message can be skipped, using the newer version is good. #9318

Closed
qiluo-msft opened this issue Nov 19, 2021 · 2 comments · Fixed by #9704 · May be fixed by #9319
Closed

based on the following issues and prs, looks like the warning message can be skipped, using the newer version is good. #9318

qiluo-msft opened this issue Nov 19, 2021 · 2 comments · Fixed by #9704 · May be fixed by #9319
Assignees
@qiluo-msft
Labels
Triaged this issue has been triaged

Comments

@qiluo-msft
Copy link
Collaborator

@qiluo-msft , based on the following issues and prs, looks like the warning message can be skipped, using the newer version is good.
Maybe we can improve the test case, explicitly ignore the warning.
https://github.com/redis/redis-py/pull/1726/files
redis/redis-py#1725
redis/redis-py#1721

Originally posted by @xumia in #9317 (comment)
@qiluo-msft qiluo-msft self-assigned this Nov 19, 2021
@qiluo-msft
Copy link
Collaborator Author

@xumia Thanks for the suggestion! I am working on it.

@qiluo-msft qiluo-msft mentioned this issue Nov 19, 2021
Open
5 tasks
@zhangyanzhao zhangyanzhao added the Triaged this issue has been triaged label Dec 8, 2021
@zhangyanzhao
Copy link
Collaborator

handled already

@qiluo-msft qiluo-msft mentioned this issue Jan 8, 2022
Merged
qiluo-msft added a commit that referenced this issue Jan 10, 2022
@qiluo-msft
Revert "[sonic-slave]: Fix redis version during pip3 install (#9317)" (…
5f524e2 
…#9704)

Reverts #9317
Since upstream fixed the issue redis/redis-py#1726
We can continue use latest version on master branch.

Fixes #9318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qiluo-msft qiluo-msft

Labels
Triaged this issue has been triaged
Projects
None yet
Milestone
No milestone
2 participants
@zhangyanzhao @qiluo-msft