Spell-check README.markdown #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
FlashSheridan
commented
May 10, 2024
FlashSheridan
commented
- “Itineraries” was pretty clearly the intended meaning, and could affect comprehension.
- “prefined” ⇒ “defined” was somewhat speculative.
Extending loads require a G_SEXT or G_ZEXT. The combining is done in the PreLegalizerCombiner. Truncating stores require a G_TRUNC, which is combined in the InstructionSelector. The change also requires changing the cond.ll test case, because the comparison is flipped in one of the combiners.
Adds isLoadFromStackSlot(), isStoreToStackSlot(), and getInstSizeInBytes().
Adds the branch relaxation pass and the required methods in InstrInfo. Misses a test case!
Return type and parameters must be zeroext or signext.
This is required to support double type with a register pair. Turns out that this requires changes to the RegisterBankInfo class. The committed code crashes the compiler as before, so there is no harm in comitting this first.
Also sets missing isMoveReg flag to mov instructions.
Also fixes some flags at jmp/branch/trap instructions.
Use ValueMapping/NumOperands variables to make call to getInstructionMapping() at end of function.
The offsets only need to consider the argument area, not the whole stack size.
Now Hello World works!
Add a working example to illustrate status of development.
redstar
force-pushed
the
main-m88k
branch
3 times, most recently
from
0434d80 to
cf4bc09
Compare
redstar
force-pushed
the
main-m88k
branch
2 times, most recently
from
3531b36 to
ee9fe89
Compare
redstar
force-pushed
the
main-m88k
branch
3 times, most recently
from
f80d0b6 to
d229e50
Compare
redstar
force-pushed
the
main-m88k
branch
4 times, most recently
from
d3c34f7 to
068b25f
Compare
redstar
force-pushed
the
main-m88k
branch
2 times, most recently
from
4f6b48d to
2b58802
Compare
redstar
force-pushed
the
main-m88k
branch
3 times, most recently
from
ec43c1f to
2ea48fc
Compare
redstar
force-pushed
the
main-m88k
branch
2 times, most recently
from
3a93b6f to
bd44745
Compare
redstar
force-pushed
the
main-m88k
branch
3 times, most recently
from
6d9c275 to
0a4105f
Compare
redstar
force-pushed
the
main-m88k
branch
2 times, most recently
from
25831f5 to
d6f3391
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.