Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server error if the checkout is made from a library that does not have any pick-up location #2318

Closed
pronguen opened this issue Aug 19, 2021 · 0 comments · Fixed by #2431
Closed

Server error if the checkout is made from a library that does not have any pick-up location #2318

pronguen opened this issue Aug 19, 2021 · 0 comments · Fixed by #2431
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend f: professional ui Professional interface p-High High priority (to be solved in the 2-3 next months)

Comments

@pronguen
Copy link
Contributor

pronguen commented Aug 19, 2021 •
edited
Loading

Describe the bug

Server error if the checkout is made from a library that does not have any pick-up location.

Linked issue: #2419

To Reproduce

  1. Log in in library A
  2. Remove all pick-up locations of library A
  3. Do a checkout
  4. See error

Expected behavior

Pick-up locations of the transaction library have no impact on the checkout.

Context

Additional context

Error received in console:
error: None is not of type 'string' Failed validating 'type' in schema['properties']['transaction_location_pid']: {'title': 'Transaction location PID', 'type': 'string'}On instance['transaction_location_pid']: None
@pronguen pronguen added f: circulation Concerns the circulation interface or backend f: professional ui Professional interface bug Breaks something but is not blocking p-High High priority (to be solved in the 2-3 next months) labels Aug 19, 2021
@pronguen pronguen mentioned this issue Sep 29, 2021
Closed
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 3, 2021
circulation: support non-circulating libraries
a61071e 
The transaction locations of a library is selected in the list of pickup
locations of the library.  This causes issues with libraries that have
no pickup location setted.

With this commit, for libraries with no pickup locations the system
considers the first library location as transaction location for
circulation transactions. These libraries can now checkout items
directly from other libraries and once checked-in back they go
in_transit.
It is still mandatory to setup library hours and notification
settings before checkout items.

* Upgrades to invenio-circulation v1.0.0a34.
* Supports checkout of items of libraries with no opening hours externally.
* Fixes problem when in transit flash message was always displaying the pickup library.
* Fixes situation A of the issue 2419.
* Supports fixed checkout of items of libraries with no opening hours externally.
* Supports checkout of items of libraries with no pickup locations.
* Closes rero#2367.
* Closes rero#2318.
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly mentioned this issue Nov 3, 2021
Merged
7 tasks
BadrAly pushed a commit that referenced this issue Nov 16, 2021
circulation: support non-circulating libraries
6cd62bb 
The transaction locations of a library is selected in the list of pickup
locations of the library.  This causes issues with libraries that have
no pickup location setted.

With this commit, for libraries with no pickup locations the system
considers the first library location as transaction location for
circulation transactions. These libraries can now checkout items
directly from other libraries and once checked-in back they go
in_transit.
It is still mandatory to setup library hours and notification
settings before checkout items.

* Upgrades to invenio-circulation v1.0.0a34.
* Supports checkout of items of libraries with no opening hours externally.
* Fixes problem when in transit flash message was always displaying the pickup library.
* Fixes situation A of the issue 2419.
* Supports fixed checkout of items of libraries with no opening hours externally.
* Supports checkout of items of libraries with no pickup locations.
* Closes #2367.
* Closes #2318.
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@pronguen pronguen added this to the v1.7.0 milestone Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend f: professional ui Professional interface p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

circulation: support non-circulating libraries BadrAly/rero-ils
1 participant
@pronguen