Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkout possible only after cancelling the request of the patron #2367

Closed
iGormilhit opened this issue Sep 6, 2021 · 1 comment · Fixed by #2431
Closed

Checkout possible only after cancelling the request of the patron #2367

iGormilhit opened this issue Sep 6, 2021 · 1 comment · Fixed by #2431
Assignees
@BadrAly
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend p-High High priority (to be solved in the 2-3 next months)

Comments

@iGormilhit
Copy link

Describe the bug

Patron A checked out an item (pid: 1858489, org 1). Patron B requested this item. Patron A checked the item in. Patron B came to the desk to borrow it, but the circulation interface refused to check it out, because it was already on loan. The librarian cancelled the request of patron B and the checkout was possible.

To Reproduce

Still to be reproduced.

Expected behavior

After the checkin by the patron A, the item should be in a state that allow the checkout for the patron B.

Context
@iGormilhit iGormilhit added f: circulation Concerns the circulation interface or backend needs info bug Breaks something but is not blocking p-High High priority (to be solved in the 2-3 next months) labels Sep 6, 2021
@pronguen pronguen added this to the v1.6.0 milestone Sep 21, 2021
@BadrAly BadrAly self-assigned this Sep 22, 2021
@BadrAly
Copy link

BadrAly commented Sep 22, 2021

This behaviour can be reproduced in three cases (checkout of ITEM_AT_DESK loan):

  1. when there are two ITEM_ON_LOAN loans for the same transactions. The validate action cancels the first loan and then changes the state of the PENDING loan to ITEM_AT_DESK. When the systems tries to checkout the ITEM_AT_DESK loan, it finds another ITEM_ON_LOAN loan and it fails. This case is fixed in 1.5.0 (fix to prevent having duplicate loans at checkout).

  2. when the owning library of the item has no location with is_pickup= True. -> additional analysis in progress

  3. when item status remains on_loan after a successful checkin (problem related to indexing of item after loan change). -> additional analysis in progress

@pronguen pronguen mentioned this issue Sep 28, 2021
Closed
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 1, 2021
circulation: manage non-circulating libraries
4577c0e 
With this commit, for libraries with no pickup locations
the system considers the first library location as transaction
location for circulation transactions.

* Allows requests on items of non-circulating libraries at external locations.
* Closes rero#2367

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly mentioned this issue Oct 1, 2021
Merged
7 tasks
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 1, 2021
circulation: manage non-circulating libraries
1853d62 
With this commit, for libraries with no pickup locations
the system considers the first library location as transaction
location for circulation transactions.

* Allows requests on items of non-circulating libraries at external locations.
* Closes rero#2367
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 1, 2021
circulation: manage non-circulating libraries
9d1cbb8 
With this commit, for libraries with no pickup locations
the system considers the first library location as transaction
location for circulation transactions.

* Allows requests on items of non-circulating libraries at external locations.
* Closes rero#2367
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 5, 2021
circulation: manage non-circulating libraries
735cb75 
In older versions, the transaction locations of a library are
selected from the list of pickup locations of the library.
This causes a problem for libraries have not setup a pickup location.

With this commit, for libraries with no pickup locations
the system considers the first library location as transaction
location for circulation transactions.

* Allows requests on items of non-circulating libraries at external locations.
* Closes rero#2367
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 5, 2021
circulation: manage non-circulating libraries
782d175 
In older versions, the transaction locations of a library are
selected from the list of pickup locations of the library.
This causes a problem for libraries have not setup a pickup location.

With this commit, for libraries with no pickup locations
the system considers the first library location as transaction
location for circulation transactions.

* Allows requests on items of non-circulating libraries at external locations.
* Closes rero#2367
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 6, 2021
circulation: manage non-circulating libraries
161387d 
In older versions, the transaction locations of a library are
selected from the list of pickup locations of the library.
This causes a problem for libraries have not setup a pickup location.

With this commit, for libraries with no pickup locations
the system considers the first library location as transaction
location for circulation transactions.

* Fixes problem when checkout of items of libraries with no opening hours was no possible.
* Allows requests on items of non-circulating libraries at external locations.
* Closes rero#2367
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 7, 2021
circulation: manage non-circulating libraries
1c7eb72 
In older versions, the transaction locations of a library are
selected from the list of pickup locations of the library.
This causes a problem for libraries have not setup a pickup location.

With this commit, for libraries with no pickup locations
the system considers the first library location as transaction
location for circulation transactions.

* Fixes problem when checkout of items of libraries with no opening hours was no possible.
* Allows requests on items of non-circulating libraries at external locations.
* Closes rero#2367
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@iGormilhit iGormilhit modified the milestones: v1.6.0, v1.7.0 Oct 14, 2021
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 15, 2021
circulation: support non-circulating libraries
b80fbf0 
The transaction locations of a library is selected in the list of pickup
locations of the library.  This causes issues with libraries that have
no pickup location setted.

With this commit, for libraries with no pickup locations the system
considers the first library location as transaction location for
circulation transactions. These libraries can now checkout items
directly from other libraries and once checked-in back they go
in_transit.

* Supports checkout of items of libraries with no opening hours.
* Allows requests on items of non-circulating libraries at external
  locations.
* Closes rero#2367, rero#2419.
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 15, 2021
circulation: support non-circulating libraries
7cfd350 
The transaction locations of a library is selected in the list of pickup
locations of the library.  This causes issues with libraries that have
no pickup location setted.

With this commit, for libraries with no pickup locations the system
considers the first library location as transaction location for
circulation transactions. These libraries can now checkout items
directly from other libraries and once checked-in back they go
in_transit.
It is still mandatory to setup library hours and notification
settings before checkout items.

* Supports checkout of items of libraries with no opening hours.
* Allows requests on items of non-circulating libraries at external
  locations.
* Closes rero#2367, rero#2419.
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 26, 2021
circulation: support non-circulating libraries
e907207 
The transaction locations of a library is selected in the list of pickup
locations of the library.  This causes issues with libraries that have
no pickup location setted.

With this commit, for libraries with no pickup locations the system
considers the first library location as transaction location for
circulation transactions. These libraries can now checkout items
directly from other libraries and once checked-in back they go
in_transit.
It is still mandatory to setup library hours and notification
settings before checkout items.

* Upgrades to invenio-circulation v1.0.0a34.
* Supports checkout of items of libraries with no opening hours.
* Fixes problem when in transit flash message was always displaying the pickup library.
* Allows requests on items of non-circulating libraries at external
  locations.
* Closes rero#2367, rero#2419.
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 26, 2021
circulation: support non-circulating libraries
933e2de 
The transaction locations of a library is selected in the list of pickup
locations of the library.  This causes issues with libraries that have
no pickup location setted.

With this commit, for libraries with no pickup locations the system
considers the first library location as transaction location for
circulation transactions. These libraries can now checkout items
directly from other libraries and once checked-in back they go
in_transit.
It is still mandatory to setup library hours and notification
settings before checkout items.

* Upgrades to invenio-circulation v1.0.0a34.
* Supports checkout of items of libraries with no opening hours externally.
* Fixes problem when in transit flash message was always displaying the pickup library.
* Supports checkout of items of libraries with no pickup locations.
* Closes rero#2367.
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 26, 2021
circulation: support non-circulating libraries
122a2e9 
The transaction locations of a library is selected in the list of pickup
locations of the library.  This causes issues with libraries that have
no pickup location setted.

With this commit, for libraries with no pickup locations the system
considers the first library location as transaction location for
circulation transactions. These libraries can now checkout items
directly from other libraries and once checked-in back they go
in_transit.
It is still mandatory to setup library hours and notification
settings before checkout items.

* Upgrades to invenio-circulation v1.0.0a34.
* Supports checkout of items of libraries with no opening hours externally.
* Fixes problem when in transit flash message was always displaying the pickup library.
* Supports checkout of items of libraries with no pickup locations.
* Closes rero#2367.
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 26, 2021
circulation: support non-circulating libraries
5115a27 
The transaction locations of a library is selected in the list of pickup
locations of the library.  This causes issues with libraries that have
no pickup location setted.

With this commit, for libraries with no pickup locations the system
considers the first library location as transaction location for
circulation transactions. These libraries can now checkout items
directly from other libraries and once checked-in back they go
in_transit.
It is still mandatory to setup library hours and notification
settings before checkout items.

* Upgrades to invenio-circulation v1.0.0a34.
* Supports checkout of items of libraries with no opening hours externally.
* Fixes problem when in transit flash message was always displaying the pickup library.
* Supports checkout of items of libraries with no pickup locations.
* Closes rero#2367.
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 26, 2021
circulation: support non-circulating libraries
e4d0a6a 
The transaction locations of a library is selected in the list of pickup
locations of the library.  This causes issues with libraries that have
no pickup location setted.

With this commit, for libraries with no pickup locations the system
considers the first library location as transaction location for
circulation transactions. These libraries can now checkout items
directly from other libraries and once checked-in back they go
in_transit.
It is still mandatory to setup library hours and notification
settings before checkout items.

* Upgrades to invenio-circulation v1.0.0a34.
* Supports checkout of items of libraries with no opening hours externally.
* Fixes problem when in transit flash message was always displaying the pickup library.
* Fixes situation A of the issue 2419.
* Supports checkout of items of libraries with no pickup locations.
* Closes rero#2367.
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 28, 2021
circulation: support non-circulating libraries
797c0a5 
The transaction locations of a library is selected in the list of pickup
locations of the library.  This causes issues with libraries that have
no pickup location setted.

With this commit, for libraries with no pickup locations the system
considers the first library location as transaction location for
circulation transactions. These libraries can now checkout items
directly from other libraries and once checked-in back they go
in_transit.
It is still mandatory to setup library hours and notification
settings before checkout items.

* Upgrades to invenio-circulation v1.0.0a34.
* Supports checkout of items of libraries with no opening hours externally.
* Fixes problem when in transit flash message was always displaying the pickup library.
* Fixes situation A of the issue 2419.
* Supports checkout of items of libraries with no pickup locations.
* Closes rero#2367.
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 28, 2021
circulation: support non-circulating libraries
004e65d 
The transaction locations of a library is selected in the list of pickup
locations of the library.  This causes issues with libraries that have
no pickup location setted.

With this commit, for libraries with no pickup locations the system
considers the first library location as transaction location for
circulation transactions. These libraries can now checkout items
directly from other libraries and once checked-in back they go
in_transit.
It is still mandatory to setup library hours and notification
settings before checkout items.

* Upgrades to invenio-circulation v1.0.0a34.
* Supports checkout of items of libraries with no opening hours externally.
* Fixes problem when in transit flash message was always displaying the pickup library.
* Fixes situation A of the issue 2419.
* Supports checkout of items of libraries with no pickup locations.
* Closes rero#2367.
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 2, 2021
circulation: support non-circulating libraries
07bbad9 
The transaction locations of a library is selected in the list of pickup
locations of the library.  This causes issues with libraries that have
no pickup location setted.

With this commit, for libraries with no pickup locations the system
considers the first library location as transaction location for
circulation transactions. These libraries can now checkout items
directly from other libraries and once checked-in back they go
in_transit.
It is still mandatory to setup library hours and notification
settings before checkout items.

* Upgrades to invenio-circulation v1.0.0a34.
* Supports checkout of items of libraries with no opening hours externally.
* Fixes problem when in transit flash message was always displaying the pickup library.
* Fixes situation A of the issue 2419.
* Supports checkout of items of libraries with no pickup locations.
* Closes rero#2367.
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 2, 2021
circulation: support non-circulating libraries
7ecfd52 
The transaction locations of a library is selected in the list of pickup
locations of the library.  This causes issues with libraries that have
no pickup location setted.

With this commit, for libraries with no pickup locations the system
considers the first library location as transaction location for
circulation transactions. These libraries can now checkout items
directly from other libraries and once checked-in back they go
in_transit.
It is still mandatory to setup library hours and notification
settings before checkout items.

* Upgrades to invenio-circulation v1.0.0a34.
* Supports checkout of items of libraries with no opening hours externally.
* Fixes problem when in transit flash message was always displaying the pickup library.
* Fixes situation A of the issue 2419.
* Supports checkout of items of libraries with no pickup locations.
* Closes rero#2367.
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 3, 2021
circulation: support non-circulating libraries
a61071e 
The transaction locations of a library is selected in the list of pickup
locations of the library.  This causes issues with libraries that have
no pickup location setted.

With this commit, for libraries with no pickup locations the system
considers the first library location as transaction location for
circulation transactions. These libraries can now checkout items
directly from other libraries and once checked-in back they go
in_transit.
It is still mandatory to setup library hours and notification
settings before checkout items.

* Upgrades to invenio-circulation v1.0.0a34.
* Supports checkout of items of libraries with no opening hours externally.
* Fixes problem when in transit flash message was always displaying the pickup library.
* Fixes situation A of the issue 2419.
* Supports fixed checkout of items of libraries with no opening hours externally.
* Supports checkout of items of libraries with no pickup locations.
* Closes rero#2367.
* Closes rero#2318.
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit that referenced this issue Nov 16, 2021
circulation: support non-circulating libraries
6cd62bb 
The transaction locations of a library is selected in the list of pickup
locations of the library.  This causes issues with libraries that have
no pickup location setted.

With this commit, for libraries with no pickup locations the system
considers the first library location as transaction location for
circulation transactions. These libraries can now checkout items
directly from other libraries and once checked-in back they go
in_transit.
It is still mandatory to setup library hours and notification
settings before checkout items.

* Upgrades to invenio-circulation v1.0.0a34.
* Supports checkout of items of libraries with no opening hours externally.
* Fixes problem when in transit flash message was always displaying the pickup library.
* Fixes situation A of the issue 2419.
* Supports fixed checkout of items of libraries with no opening hours externally.
* Supports checkout of items of libraries with no pickup locations.
* Closes #2367.
* Closes #2318.
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BadrAly BadrAly

Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

circulation: support non-circulating libraries BadrAly/rero-ils
3 participants
@iGormilhit @pronguen @BadrAly